Web Animations: Update naming to reflect spec changes (issue 1113173003 by dstockwell@chromium.org)

[dstoc...@chromium.org]

Reviewers: shans, alancutter,

Description:
Web Animations: Update naming to reflect spec changes

KeyframeEffect -> KeyframeEffectModel (internal)
Animation -> KeyframeEffect
AnimationEffect -> EffectModel
AnimationNode -> AnimationEffect (internal), AnimationEffectReadOnly (idl)
AnimationPlayer -> Animation
Timing (internal), AnimationNodeTiming (idl), -> AnimationEffectTiming

Note, this does not rename:
* the WebCompositor* interfaces (for @loyso)
* or the devtools protocol (for @samli)

Follow on changes:
* remove EffectModel from idl, to be replaced by SharedKeyframeList
* rename InertAnimation to InertEffect
* expose other *ReadOnly interfaces and add support for treating
AnimationEffect
as a read only instance

BUG=483272

Please review this at https://codereview.chromium.org/1113173003/

Base URL: svn://svn.chromium.org/blink/trunk

Affected files (+3121, -5493 lines):
M LayoutTests/animations/resources/animation-test-helpers.js
M LayoutTests/transitions/interrupted-immediately.html
M LayoutTests/transitions/repeated-firing-background-color.html
M LayoutTests/transitions/transition-currentcolor.html
M LayoutTests/transitions/webkit-clip-path-equality.html
M LayoutTests/virtual/stable/webexposed/web-animations-api-expected.txt
M LayoutTests/web-animations-api/animation-constructor.html
M LayoutTests/web-animations-api/partial-keyframes.html
M LayoutTests/web-animations-api/timed-item.html
M LayoutTests/web-animations-api/timed-item-specified-getters.html
M LayoutTests/web-animations-api/timed-item-specified-setters.html
M LayoutTests/web-animations-api/timeline-play-animation.html
M LayoutTests/web-animations-api/timeline-updates-players.html
M LayoutTests/web-animations-api/transitions-replay.html
M LayoutTests/web-animations-api/w3c/get-animation-players.html
M LayoutTests/web-animations-api/w3c/get-css-players.html
M LayoutTests/webexposed/element-instance-property-listing-expected.txt
M LayoutTests/webexposed/global-interface-listing-expected.txt
M LayoutTests/webexposed/web-animations-api.html
M LayoutTests/webexposed/web-animations-api-expected.txt
M Source/core/animation/Animation.h
M Source/core/animation/Animation.cpp
M Source/core/animation/Animation.idl
M Source/core/animation/AnimationEffect.h
A + Source/core/animation/AnimationEffect.cpp
D Source/core/animation/AnimationEffect.idl
A + Source/core/animation/AnimationEffectReadOnly.idl
A + Source/core/animation/AnimationEffectTest.cpp
A + Source/core/animation/AnimationEffectTiming.h
A + Source/core/animation/AnimationEffectTiming.cpp
A + Source/core/animation/AnimationEffectTiming.idl
D Source/core/animation/AnimationNode.h
D Source/core/animation/AnimationNode.cpp
D Source/core/animation/AnimationNode.idl
D Source/core/animation/AnimationNodeTest.cpp
D Source/core/animation/AnimationNodeTiming.h
D Source/core/animation/AnimationNodeTiming.cpp
M Source/core/animation/AnimationPlayer.h
M Source/core/animation/AnimationPlayer.cpp
M Source/core/animation/AnimationPlayer.idl
M Source/core/animation/AnimationPlayerTest.cpp
M Source/core/animation/AnimationStack.h
M Source/core/animation/AnimationStack.cpp
M Source/core/animation/AnimationStackTest.cpp
M Source/core/animation/AnimationTest.cpp
M Source/core/animation/AnimationTimeline.h
M Source/core/animation/AnimationTimeline.cpp
M Source/core/animation/AnimationTimeline.idl
M Source/core/animation/AnimationTimelineTest.cpp
D Source/core/animation/AnimationTimingProperties.idl
M Source/core/animation/CompositorAnimations.h
M Source/core/animation/CompositorAnimations.cpp
M Source/core/animation/CompositorAnimationsImpl.h
M Source/core/animation/CompositorAnimationsTest.cpp
M Source/core/animation/CompositorPendingAnimations.h
M Source/core/animation/CompositorPendingAnimations.cpp
M Source/core/animation/ComputedTimingProperties.idl
M Source/core/animation/DocumentAnimations.h
M Source/core/animation/DocumentAnimations.cpp
M Source/core/animation/EffectInput.h
M Source/core/animation/EffectInput.cpp
M Source/core/animation/EffectInputTest.cpp
A + Source/core/animation/EffectModel.h
A + Source/core/animation/EffectModel.idl
M Source/core/animation/ElementAnimation.h
M Source/core/animation/ElementAnimation.idl
M Source/core/animation/ElementAnimations.h
M Source/core/animation/ElementAnimations.cpp
M Source/core/animation/InertAnimation.h
M Source/core/animation/InertAnimation.cpp
M Source/core/animation/Keyframe.h
A + Source/core/animation/KeyframeEffect.h
A + Source/core/animation/KeyframeEffect.cpp
A + Source/core/animation/KeyframeEffect.idl
M Source/core/animation/KeyframeEffectModel.h
M Source/core/animation/KeyframeEffectModel.cpp
M Source/core/animation/KeyframeEffectModelTest.cpp
A + Source/core/animation/KeyframeEffectOptions.idl
A + Source/core/animation/KeyframeEffectTest.cpp
M Source/core/animation/SampledEffect.h
M Source/core/animation/SampledEffect.cpp
M Source/core/animation/StringKeyframe.h
M Source/core/animation/StringKeyframe.cpp
D Source/core/animation/Timing.idl
M Source/core/animation/TimingCalculations.h
M Source/core/animation/TimingCalculationsTest.cpp
M Source/core/animation/TimingInput.h
M Source/core/animation/TimingInput.cpp
M Source/core/animation/TimingInputTest.cpp
M Source/core/animation/animatable/AnimatableValueKeyframe.h
M Source/core/animation/animatable/AnimatableValueKeyframe.cpp
M Source/core/animation/css/CSSAnimationUpdate.h
M Source/core/animation/css/CSSAnimations.h
M Source/core/animation/css/CSSAnimations.cpp
M Source/core/core.gypi
M Source/core/css/resolver/StyleResolver.cpp
M Source/core/dom/Document.cpp
M Source/core/frame/UseCounter.h
M Source/core/inspector/InspectorAnimationAgent.h
M Source/core/inspector/InspectorAnimationAgent.cpp
M Source/core/inspector/InspectorInstrumentation.idl
M Source/core/inspector/InspectorTraceEvents.h
M Source/core/inspector/InspectorTraceEvents.cpp
M Source/core/style/KeyframeList.cpp

[alanc...@chromium.org]

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/animations/resources/animation-test-helpers.js
File LayoutTests/animations/resources/animation-test-helpers.js (right):

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/animations/resources/animation-test-helpers.js#newcode208
LayoutTests/animations/resources/animation-test-helpers.js:208:
log('Pausing at time: ' + timeMs + ', current players: ' +
document.timeline.getAnimations().length);
s/player/animation/

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/animation-constructor.html
File LayoutTests/web-animations-api/animation-constructor.html (right):

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/animation-constructor.html#newcode14
LayoutTests/web-animations-api/animation-constructor.html:14: var
animation = new KeyframeEffect(element, keyframes, timingObject);
s/animation/keyframeEffect/g

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/timed-item-specified-getters.html
File LayoutTests/web-animations-api/timed-item-specified-getters.html
(right):

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/timed-item-specified-getters.html#newcode13
LayoutTests/web-animations-api/timed-item-specified-getters.html:13: var
animationBasic = new KeyframeEffect(element, keyframes);
s/animation/keyframeEffect/g

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/timed-item-specified-setters.html
File LayoutTests/web-animations-api/timed-item-specified-setters.html
(right):

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/timed-item-specified-setters.html#newcode13
LayoutTests/web-animations-api/timed-item-specified-setters.html:13: var
animation = new KeyframeEffect(element, keyframes);
s/animation/keyframeEffect/

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/timed-item.html
File LayoutTests/web-animations-api/timed-item.html (right):

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/timed-item.html#newcode14
LayoutTests/web-animations-api/timed-item.html:14: var animation = new
KeyframeEffect(element, keyframes);
s/animation/keyframeEffect/g

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/timeline-play-animation.html
File LayoutTests/web-animations-api/timeline-play-animation.html
(right):

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/timeline-play-animation.html#newcode14
LayoutTests/web-animations-api/timeline-play-animation.html:14: var
animation = new KeyframeEffect(element,
s/animation/keyframeEffect/g

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/timeline-updates-players.html
File LayoutTests/web-animations-api/timeline-updates-players.html
(right):

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/timeline-updates-players.html#newcode11
LayoutTests/web-animations-api/timeline-updates-players.html:11: var
animation = new KeyframeEffect(element, [{left: '0px'}, {left:
'100px'}], 10);
s/animation/keyframeEffect/
s/players.html/animations.html/

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/transitions-replay.html
File LayoutTests/web-animations-api/transitions-replay.html (right):

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/transitions-replay.html#newcode20
LayoutTests/web-animations-api/transitions-replay.html:20: var player =
document.timeline.getAnimations()[0];
s/player/animation/

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/w3c/get-animation-players.html
File LayoutTests/web-animations-api/w3c/get-animation-players.html
(right):

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/w3c/get-animation-players.html#newcode18
LayoutTests/web-animations-api/w3c/get-animation-players.html:18: var
player = element.animate([], 1000);
s/player/animation/g
s/players.html/animations.html/

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/w3c/get-css-players.html
File LayoutTests/web-animations-api/w3c/get-css-players.html (right):

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/w3c/get-css-players.html#newcode25
LayoutTests/web-animations-api/w3c/get-css-players.html:25: var players
= document.timeline.getAnimations();
s/players/animations/g

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/Animation.cpp
File Source/core/animation/Animation.cpp (right):

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/Animation.cpp#newcode618
Source/core/animation/Animation.cpp:618: return
EventTargetNames::AnimationPlayer;
Should this change?

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/AnimationStackTest.cpp
File Source/core/animation/AnimationStackTest.cpp (right):

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/AnimationStackTest.cpp#newcode66
Source/core/animation/AnimationStackTest.cpp:66:
PassRefPtrWillBeRawPtr<KeyframeEffect>
makeAnimation(PassRefPtrWillBeRawPtr<EffectModel> effect, double
duration = 10)
makeKeyframeEffect?

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/AnimationStackTest.cpp#newcode113
Source/core/animation/AnimationStackTest.cpp:113:
RefPtrWillBeRawPtr<Animation> player =
play(makeAnimation(makeEffectModel(CSSPropertyFontSize,
AnimatableDouble::create(1))).get(), 0);
s/player/animation/

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/AnimationTest.cpp
File Source/core/animation/AnimationTest.cpp (right):

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/AnimationTest.cpp#newcode89
Source/core/animation/AnimationTest.cpp:89:
RefPtrWillBePersistent<Animation> player;
s/player/animation/

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/AnimationTest.cpp#newcode688
Source/core/animation/AnimationTest.cpp:688:
RefPtrWillBeRawPtr<KeyframeEffect> animation = KeyframeEffect::create(0,
nullptr, timing);
s/animation/keyframeEffect/g

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/AnimationTimelineTest.cpp
File Source/core/animation/AnimationTimelineTest.cpp (right):

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/AnimationTimelineTest.cpp#newcode142
Source/core/animation/AnimationTimelineTest.cpp:142:
RefPtrWillBeRawPtr<KeyframeEffect> anim =
KeyframeEffect::create(element.get(), effect, timing);
s/anim/keyframeEffect/g

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/AnimationTimelineTest.cpp#newcode398
Source/core/animation/AnimationTimelineTest.cpp:398:
RefPtrWillBeRawPtr<Animation> player = timeline->play(0);
s/player/animation/

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/CompositorAnimationsTest.cpp
File Source/core/animation/CompositorAnimationsTest.cpp (right):

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/CompositorAnimationsTest.cpp#newcode1219
Source/core/animation/CompositorAnimationsTest.cpp:1219:
RefPtrWillBeRawPtr<KeyframeEffect> animation1 =
KeyframeEffect::create(element.get(), animationEffect1, timing);
s/animation/keyframeEffect/g

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/CompositorAnimationsTest.cpp#newcode1220
Source/core/animation/CompositorAnimationsTest.cpp:1220:
RefPtrWillBePersistent<Animation> player1 =
m_timeline->play(animation1.get());
s/player/animation/g

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/KeyframeEffect.h
File Source/core/animation/KeyframeEffect.h (right):

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/KeyframeEffect.h#newcode94
Source/core/animation/KeyframeEffect.h:94: void
downgradeToNormalAnimation() { m_priority = DefaultPriority; }
s/Animation//

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/KeyframeEffectTest.cpp
File Source/core/animation/KeyframeEffectTest.cpp (right):

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/KeyframeEffectTest.cpp#newcode52
Source/core/animation/KeyframeEffectTest.cpp:52: static
PassRefPtrWillBeRawPtr<KeyframeEffect> createAnimation(Element* element,
Vector<Dictionary> keyframeDictionaryVector, T timingInput,
ExceptionState& exceptionState)
s/animation/keyframeEffect/ig

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/KeyframeEffectTest.cpp#newcode359
Source/core/animation/KeyframeEffectTest.cpp:359:
RefPtrWillBeRawPtr<Animation> player =
document.timeline().play(animation.get());
s/animation/keyframeEffect/g
s/player/animation/g

https://codereview.chromium.org/1113173003/

[dstoc...@chromium.org]

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/animations/resources/animation-test-helpers.js
File LayoutTests/animations/resources/animation-test-helpers.js (right):

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/animations/resources/animation-test-helpers.js#newcode208
LayoutTests/animations/resources/animation-test-helpers.js:208:
log('Pausing at time: ' + timeMs + ', current players: ' +
document.timeline.getAnimations().length);

On 2015/05/05 at 01:04:50, alancutter wrote:
> s/player/animation/

Done ^_^

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/animation-constructor.html
File LayoutTests/web-animations-api/animation-constructor.html (right):

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/animation-constructor.html#newcode14
LayoutTests/web-animations-api/animation-constructor.html:14: var
animation = new KeyframeEffect(element, keyframes, timingObject);

On 2015/05/05 at 01:04:50, alancutter wrote:
> s/animation/keyframeEffect/g

DON

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/timed-item-specified-getters.html
File LayoutTests/web-animations-api/timed-item-specified-getters.html
(right):

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/timed-item-specified-getters.html#newcode13
LayoutTests/web-animations-api/timed-item-specified-getters.html:13: var
animationBasic = new KeyframeEffect(element, keyframes);

On 2015/05/05 at 01:04:51, alancutter wrote:
> s/animation/keyframeEffect/g

DONe

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/timed-item-specified-setters.html
File LayoutTests/web-animations-api/timed-item-specified-setters.html
(right):

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/timed-item-specified-setters.html#newcode13
LayoutTests/web-animations-api/timed-item-specified-setters.html:13: var
animation = new KeyframeEffect(element, keyframes);

On 2015/05/05 at 01:04:51, alancutter wrote:
> s/animation/keyframeEffect/

done

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/timed-item.html
File LayoutTests/web-animations-api/timed-item.html (right):

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/timed-item.html#newcode14
LayoutTests/web-animations-api/timed-item.html:14: var animation = new
KeyframeEffect(element, keyframes);

On 2015/05/05 at 01:04:51, alancutter wrote:
> s/animation/keyframeEffect/g

Done..

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/timeline-play-animation.html
File LayoutTests/web-animations-api/timeline-play-animation.html
(right):

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/timeline-play-animation.html#newcode14
LayoutTests/web-animations-api/timeline-play-animation.html:14: var
animation = new KeyframeEffect(element,

On 2015/05/05 at 01:04:51, alancutter wrote:
> s/animation/keyframeEffect/g

Done!

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/timeline-updates-players.html
File LayoutTests/web-animations-api/timeline-updates-players.html
(right):

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/timeline-updates-players.html#newcode11
LayoutTests/web-animations-api/timeline-updates-players.html:11: var
animation = new KeyframeEffect(element, [{left: '0px'}, {left:
'100px'}], 10);

On 2015/05/05 at 01:04:51, alancutter wrote:
> s/animation/keyframeEffect/
> s/players.html/animations.html/

Done! (but not the file)

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/transitions-replay.html
File LayoutTests/web-animations-api/transitions-replay.html (right):

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/transitions-replay.html#newcode20
LayoutTests/web-animations-api/transitions-replay.html:20: var player =
document.timeline.getAnimations()[0];

On 2015/05/05 at 01:04:51, alancutter wrote:
> s/player/animation/

DONE!

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/w3c/get-animation-players.html
File LayoutTests/web-animations-api/w3c/get-animation-players.html
(right):

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/w3c/get-animation-players.html#newcode18
LayoutTests/web-animations-api/w3c/get-animation-players.html:18: var
player = element.animate([], 1000);

On 2015/05/05 at 01:04:51, alancutter wrote:
> s/player/animation/g
> s/players.html/animations.html/

50% done1!

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/w3c/get-css-players.html
File LayoutTests/web-animations-api/w3c/get-css-players.html (right):

https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/web-animations-api/w3c/get-css-players.html#newcode25
LayoutTests/web-animations-api/w3c/get-css-players.html:25: var players
= document.timeline.getAnimations();

On 2015/05/05 at 01:04:51, alancutter wrote:
> s/players/animations/g

YAAAY done.

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/Animation.cpp
File Source/core/animation/Animation.cpp (right):

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/Animation.cpp#newcode618
Source/core/animation/Animation.cpp:618: return
EventTargetNames::AnimationPlayer;

On 2015/05/05 at 01:04:51, alancutter wrote:
> Should this change?

Yes, but we'll wait for the spec update.

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/AnimationStackTest.cpp
File Source/core/animation/AnimationStackTest.cpp (right):

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/AnimationStackTest.cpp#newcode66
Source/core/animation/AnimationStackTest.cpp:66:
PassRefPtrWillBeRawPtr<KeyframeEffect>
makeAnimation(PassRefPtrWillBeRawPtr<EffectModel> effect, double
duration = 10)

On 2015/05/05 at 01:04:51, alancutter wrote:
> makeKeyframeEffect?

Done.

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/AnimationStackTest.cpp#newcode113
Source/core/animation/AnimationStackTest.cpp:113:
RefPtrWillBeRawPtr<Animation> player =
play(makeAnimation(makeEffectModel(CSSPropertyFontSize,
AnimatableDouble::create(1))).get(), 0);

On 2015/05/05 at 01:04:51, alancutter wrote:
> s/player/animation/

Done.

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/AnimationTest.cpp
File Source/core/animation/AnimationTest.cpp (right):

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/AnimationTest.cpp#newcode89
Source/core/animation/AnimationTest.cpp:89:
RefPtrWillBePersistent<Animation> player;

On 2015/05/05 at 01:04:51, alancutter wrote:
> s/player/animation/

Done!

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/AnimationTest.cpp#newcode688
Source/core/animation/AnimationTest.cpp:688:
RefPtrWillBeRawPtr<KeyframeEffect> animation = KeyframeEffect::create(0,
nullptr, timing);

On 2015/05/05 at 01:04:51, alancutter wrote:
> s/animation/keyframeEffect/g

Done!!!

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/AnimationTimelineTest.cpp
File Source/core/animation/AnimationTimelineTest.cpp (right):

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/AnimationTimelineTest.cpp#newcode142
Source/core/animation/AnimationTimelineTest.cpp:142:
RefPtrWillBeRawPtr<KeyframeEffect> anim =
KeyframeEffect::create(element.get(), effect, timing);

On 2015/05/05 at 01:04:51, alancutter wrote:
> s/anim/keyframeEffect/g

Done!!!!

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/AnimationTimelineTest.cpp#newcode398
Source/core/animation/AnimationTimelineTest.cpp:398:
RefPtrWillBeRawPtr<Animation> player = timeline->play(0);

On 2015/05/05 at 01:04:51, alancutter wrote:
> s/player/animation/

DONE!

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/CompositorAnimationsTest.cpp
File Source/core/animation/CompositorAnimationsTest.cpp (right):

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/CompositorAnimationsTest.cpp#newcode1219
Source/core/animation/CompositorAnimationsTest.cpp:1219:
RefPtrWillBeRawPtr<KeyframeEffect> animation1 =
KeyframeEffect::create(element.get(), animationEffect1, timing);

On 2015/05/05 at 01:04:51, alancutter wrote:
> s/animation/keyframeEffect/g

Done!

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/CompositorAnimationsTest.cpp#newcode1220
Source/core/animation/CompositorAnimationsTest.cpp:1220:
RefPtrWillBePersistent<Animation> player1 =
m_timeline->play(animation1.get());

On 2015/05/05 at 01:04:51, alancutter wrote:
> s/player/animation/g

DONE!!

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/KeyframeEffect.h
File Source/core/animation/KeyframeEffect.h (right):

https://codereview.chromium.org/1113173003/diff/170001/Source/core/animation/KeyframeEffect.h#newcode94
Source/core/animation/KeyframeEffect.h:94: void
downgradeToNormalAnimation() { m_priority = DefaultPriority; }

On 2015/05/05 01:04:51, alancutter wrote:
> s/Animation//

Done.

https://codereview.chromium.org/1113173003/

[alanc...@chromium.org]

rslgtm

https://codereview.chromium.org/1113173003/

[alanc...@chromium.org]

On 2015/05/05 at 04:07:01, alancutter wrote:
> rslgtm

rs=lgtm

https://codereview.chromium.org/1113173003/

[commi...@chromium.org]

CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1113173003/200106


https://codereview.chromium.org/1113173003/

[commi...@chromium.org]

Try jobs failed on following builders:
mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/54378)

https://codereview.chromium.org/1113173003/

[commi...@chromium.org]

CQ is trying da patch. Follow status at

https://chromium-cq-status.appspot.com/patch-status/1113173003/220001


https://codereview.chromium.org/1113173003/

[commi...@chromium.org]

CQ is trying da patch. Follow status at

https://chromium-cq-status.appspot.com/patch-status/1113173003/240001


https://codereview.chromium.org/1113173003/

[commi...@chromium.org]

Try jobs failed on following builders:

linux_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_compile_dbg/builds/7935)

https://codereview.chromium.org/1113173003/

[commi...@chromium.org]

CQ is trying da patch. Follow status at

https://chromium-cq-status.appspot.com/patch-status/1113173003/260001


https://codereview.chromium.org/1113173003/

[commi...@chromium.org]

Try jobs failed on following builders:

mac_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/43928)

https://codereview.chromium.org/1113173003/

[commi...@chromium.org]

CQ is trying da patch. Follow status at

https://chromium-cq-status.appspot.com/patch-status/1113173003/280001


https://codereview.chromium.org/1113173003/

[commi...@chromium.org]

Committed patchset #16 (id:280001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194961

https://codereview.chromium.org/1113173003/