DevTools: Instantly rescale Perfmon chart on start up. [chromium/src : master]

Alexei Filippov (Gerrit)

unread,

Oct 19, 2017, 7:23:02 PM10/19/17

to apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Andrey Kosyakov, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

This change is ready for review.

View Change

To view, visit change 729043. To unsubscribe, or for help writing mail filters, visit settings.

Andrey Kosyakov (Gerrit)

unread,

Oct 19, 2017, 7:54:45 PM10/19/17

to Alexei Filippov, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

View Change

1 comment:

File third_party/WebKit/Source/devtools/front_end/timeline/PerformanceMonitor.js:
- Patch Set #1, Line 217: return 10;
  What's 10?!

To view, visit change 729043. To unsubscribe, or for help writing mail filters, visit settings.

Alexei Filippov (Gerrit)

unread,

Oct 19, 2017, 8:11:34 PM10/19/17

to apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Andrey Kosyakov, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

View Change

1 comment:

File third_party/WebKit/Source/devtools/front_end/timeline/PerformanceMonitor.js:

- Patch Set #1, Line 217: return 10;
  What's 10?!

- Default value for max scale when the chart is [yet] empty.

To view, visit change 729043. To unsubscribe, or for help writing mail filters, visit settings.

Andrey Kosyakov (Gerrit)

unread,

Oct 20, 2017, 6:05:11 PM10/20/17

to Alexei Filippov, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Patch set 1:Code-Review +1

View Change

To view, visit change 729043. To unsubscribe, or for help writing mail filters, visit settings.

Alexei Filippov (Gerrit)

unread,

Oct 20, 2017, 6:13:11 PM10/20/17

to apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Andrey Kosyakov, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Patch set 1:Commit-Queue +2

View Change

To view, visit change 729043. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Oct 20, 2017, 9:52:37 PM10/20/17

to Alexei Filippov, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Andrey Kosyakov, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Try jobs failed on following builders:
  win7_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win7_chromium_rel_ng/builds/23678)

View Change

To view, visit change 729043. To unsubscribe, or for help writing mail filters, visit settings.

Alexei Filippov (Gerrit)

unread,

Oct 21, 2017, 8:25:09 AM10/21/17

to apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Commit Bot, Andrey Kosyakov, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Patch set 1:Commit-Queue +2

View Change

To view, visit change 729043. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Oct 21, 2017, 10:33:27 AM10/21/17

to Alexei Filippov, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Andrey Kosyakov, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Commit Bot merged this change.

View Change

Approvals:
  Andrey Kosyakov: Looks good to me
  Alexei Filippov: Commit

DevTools: Instantly rescale Perfmon chart on start up.

BUG=751892

Change-Id: Ic63f8d043e050981910eb4fc10014d4d26ff0e13
Reviewed-on: https://chromium-review.googlesource.com/729043
Reviewed-by: Andrey Kosyakov <ca...@chromium.org>
Commit-Queue: Alexei Filippov <al...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510681}
---
M third_party/WebKit/Source/devtools/front_end/timeline/PerformanceMonitor.js
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/PerformanceMonitor.js b/third_party/WebKit/Source/devtools/front_end/timeline/PerformanceMonitor.js
index 0de0841..14fef04 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/PerformanceMonitor.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/PerformanceMonitor.js
@@ -234,15 +234,14 @@
         if (metrics.timestamp < startTime)
           break;
       }
-      max = Math.max(1, max);
     }
-    if (!isFinite(max))
-      return 1;
+    if (!this._metricsBuffer.length)
+      return 10;
 
     var base10 = Math.pow(10, Math.floor(Math.log10(max)));
     max = Math.ceil(max / base10 / 2) * base10 * 2;
 
-    var alpha = 0.1;
+    var alpha = 0.2;
     chartInfo.currentMax = max * alpha + (chartInfo.currentMax || max) * (1 - alpha);
     return chartInfo.currentMax;
   }

To view, visit change 729043. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward