[DevTools] better errors for Target.sendMessageToTarget [chromium/src : master]
Aleksey Kozyatinskiy (Gerrit)
Aleksey Kozyatinskiy uploaded patch set #5 to this change.
[DevTools] better errors for Target.sendMessageToTarget
Methods should generate notification with error on invalid
message.
inspector_protocol rolled to bdfbb48cdc1a1ccd7dc9456506feab46c8ffe90c:
- [inspector_protocol] added UberDispatcher::getCommandName
Bug:chromium:775105
Change-Id: I47be11a4b1203781472a83c8ae38566a286f1e4d
R=dgo...@chromium.org
---
M third_party/WebKit/LayoutTests/http/tests/devtools/report-protocol-errors-expected.txt
A third_party/WebKit/LayoutTests/inspector-protocol/target/target-send-message-expected.txt
A third_party/WebKit/LayoutTests/inspector-protocol/target/target-send-message.js
M third_party/WebKit/Source/core/inspector/InspectorSession.cpp
M third_party/WebKit/Source/core/inspector/InspectorSession.h
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
M third_party/inspector_protocol/README.chromium
M third_party/inspector_protocol/lib/DispatcherBase_cpp.template
M third_party/inspector_protocol/lib/DispatcherBase_h.template
9 files changed, 109 insertions(+), 29 deletions(-)
To view, visit change 722662. To unsubscribe, or for help writing mail filters, visit settings.
Aleksey Kozyatinskiy (Gerrit)
all done, thanks1
Patch set 5:Commit-Queue +2
1 comment:
File third_party/inspector_protocol/lib/DispatcherBase_cpp.template:
Patch Set #3, Line 294:
bool UberDispatcher::getCommandName(const String& message, String* method, std::unique_ptr<protocol::DictionaryValue>* parsedMessage)I think returning boolean and having two output parameters would be better.
Done
To view, visit change 722662. To unsubscribe, or for help writing mail filters, visit settings.
Commit Bot (Gerrit)
CQ is trying da patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"Edit commit message" https://chromium-review.googlesource.com/c/722662/5
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/722662/5
Bot data: {"action": "start", "triggered_at": "2017-10-19T18:08:08.0Z", "cq_cfg_revision": "fc2b2f04ed20d88113c10951036ca403891c435f", "revision": "c0c5e0eadac162f14902de493dec3c5ebb97e920"}
Commit Bot (Gerrit)
Try jobs failed on following builders:
mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/569719)
Aleksey Kozyatinskiy (Gerrit)
Patch set 6:Commit-Queue +2
Commit Bot (Gerrit)
CQ is trying da patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"fixed test" https://chromium-review.googlesource.com/c/722662/6
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/722662/6
Bot data: {"action": "start", "triggered_at": "2017-10-19T22:52:03.0Z", "cq_cfg_revision": "fc2b2f04ed20d88113c10951036ca403891c435f", "revision": "126192e4db0d4eb5de13d8ea5f229e166b364592"}
Commit Bot (Gerrit)
Try jobs failed on following builders:
linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/410712)
Aleksey Kozyatinskiy (Gerrit)
Patch set 12:Commit-Queue +2
Commit Bot (Gerrit)
CQ is trying da patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"fixed test" https://chromium-review.googlesource.com/c/722662/12
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/722662/12
Bot data: {"action": "start", "triggered_at": "2017-10-21T00:06:27.0Z", "cq_cfg_revision": "4193247284c88e2cc546ef8365733fcd9ba8d399", "revision": "ab3ddb06037ca1352b84ed6b9019069e05fa8862"}
Commit Bot (Gerrit)
Try jobs failed on following builders:
win7_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win7_chromium_rel_ng/builds/23775)
Aleksey Kozyatinskiy (Gerrit)
Patch set 12:Commit-Queue +2
Commit Bot (Gerrit)
CQ is trying da patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"fixed test" https://chromium-review.googlesource.com/c/722662/12
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/722662/12
Bot data: {"action": "start", "triggered_at": "2017-10-21T20:35:02.0Z", "cq_cfg_revision": "573b6c39d3de239a70e8fa672647b63bf0bd1f89", "revision": "ab3ddb06037ca1352b84ed6b9019069e05fa8862"}
Commit Bot (Gerrit)
Commit Bot merged this change.
[DevTools] better errors for Target.sendMessageToTarget
Methods should generate notification with error on invalid
message.
inspector_protocol rolled to bdfbb48cdc1a1ccd7dc9456506feab46c8ffe90c:
- [inspector_protocol] added UberDispatcher::getCommandName
R=dgo...@chromium.org
Bug: chromium:775105
Change-Id: I47be11a4b1203781472a83c8ae38566a286f1e4d
Reviewed-on: https://chromium-review.googlesource.com/722662
Commit-Queue: Aleksey Kozyatinskiy <kozyat...@chromium.org>
Reviewed-by: Dmitry Gozman <dgo...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510698}
---
M third_party/WebKit/LayoutTests/http/tests/devtools/report-protocol-errors-expected.txt
A third_party/WebKit/LayoutTests/inspector-protocol/target/target-send-message-expected.txt
A third_party/WebKit/LayoutTests/inspector-protocol/target/target-send-message.js
M third_party/WebKit/Source/core/inspector/InspectorSession.cpp
M third_party/WebKit/Source/core/inspector/InspectorSession.h
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
M third_party/inspector_protocol/README.chromium
M third_party/inspector_protocol/lib/DispatcherBase_cpp.template
M third_party/inspector_protocol/lib/DispatcherBase_h.template
9 files changed, 117 insertions(+), 29 deletions(-)