Replace WTF::RefPtr with scoped_refptr in core/dom [chromium/src : master]

0 views
Skip to first unread message

Taiju Tsuiki (Gerrit)

unread,
Oct 19, 2017, 8:45:49 AM10/19/17
to blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, dtapuska+...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, Hayato Ito, Commit Bot, chromium...@chromium.org, Rob Buis

PTAL

View Change

    To view, visit change 727604. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: master
    Gerrit-MessageType: comment
    Gerrit-Change-Id: I4dba348a2e0b291df17bf930c44b1aa2d0ea918c
    Gerrit-Change-Number: 727604
    Gerrit-PatchSet: 1
    Gerrit-Owner: Taiju Tsuiki <tz...@chromium.org>
    Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
    Gerrit-Reviewer: Taiju Tsuiki <tz...@chromium.org>
    Gerrit-CC: Commit Bot <commi...@chromium.org>
    Gerrit-CC: Rob Buis <rob....@samsung.com>
    Gerrit-Comment-Date: Thu, 19 Oct 2017 12:45:40 +0000
    Gerrit-HasComments: No
    Gerrit-HasLabels: No

    Kouhei Ueno (Gerrit)

    unread,
    Oct 19, 2017, 8:53:02 AM10/19/17
    to Taiju Tsuiki, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, dtapuska+...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, Hayato Ito, Commit Bot, chromium...@chromium.org, Rob Buis

    Patch set 1:Code-Review +1

    View Change

      To view, visit change 727604. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: master
      Gerrit-MessageType: comment
      Gerrit-Change-Id: I4dba348a2e0b291df17bf930c44b1aa2d0ea918c
      Gerrit-Change-Number: 727604
      Gerrit-PatchSet: 1
      Gerrit-Owner: Taiju Tsuiki <tz...@chromium.org>
      Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
      Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
      Gerrit-Reviewer: Taiju Tsuiki <tz...@chromium.org>
      Gerrit-CC: Commit Bot <commi...@chromium.org>
      Gerrit-CC: Rob Buis <rob....@samsung.com>
      Gerrit-Comment-Date: Thu, 19 Oct 2017 12:52:57 +0000
      Gerrit-HasComments: No
      Gerrit-HasLabels: Yes

      Hayato Ito (Gerrit)

      unread,
      Oct 19, 2017, 11:35:43 PM10/19/17
      to Taiju Tsuiki, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, dtapuska+...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, Kouhei Ueno, Commit Bot, chromium...@chromium.org, Rob Buis

      Patch set 1:Code-Review +1

      View Change

        To view, visit change 727604. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: master
        Gerrit-MessageType: comment
        Gerrit-Change-Id: I4dba348a2e0b291df17bf930c44b1aa2d0ea918c
        Gerrit-Change-Number: 727604
        Gerrit-PatchSet: 1
        Gerrit-Owner: Taiju Tsuiki <tz...@chromium.org>
        Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
        Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
        Gerrit-Reviewer: Taiju Tsuiki <tz...@chromium.org>
        Gerrit-CC: Commit Bot <commi...@chromium.org>
        Gerrit-CC: Rob Buis <rob....@samsung.com>
        Gerrit-Comment-Date: Fri, 20 Oct 2017 03:35:35 +0000
        Gerrit-HasComments: No
        Gerrit-HasLabels: Yes

        Taiju Tsuiki (Gerrit)

        unread,
        Oct 20, 2017, 2:47:24 AM10/20/17
        to blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, dtapuska+...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, Hayato Ito, Kouhei Ueno, Commit Bot, chromium...@chromium.org, Rob Buis

        Patch set 1:Commit-Queue +2

        View Change

          To view, visit change 727604. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Project: chromium/src
          Gerrit-Branch: master
          Gerrit-MessageType: comment
          Gerrit-Change-Id: I4dba348a2e0b291df17bf930c44b1aa2d0ea918c
          Gerrit-Change-Number: 727604
          Gerrit-PatchSet: 1
          Gerrit-Owner: Taiju Tsuiki <tz...@chromium.org>
          Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
          Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
          Gerrit-Reviewer: Taiju Tsuiki <tz...@chromium.org>
          Gerrit-CC: Commit Bot <commi...@chromium.org>
          Gerrit-CC: Rob Buis <rob....@samsung.com>
          Gerrit-Comment-Date: Fri, 20 Oct 2017 06:47:17 +0000
          Gerrit-HasComments: No
          Gerrit-HasLabels: Yes

          Commit Bot (Gerrit)

          unread,
          Oct 20, 2017, 3:35:07 AM10/20/17
          to Taiju Tsuiki, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, dtapuska+...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, Hayato Ito, Kouhei Ueno, chromium...@chromium.org, Rob Buis

          Cannot rebase 73baeeb2df80af1470f0b538794c3f1a55f5f934: The change could not be rebased due to a conflict during merge.

          View Change

            To view, visit change 727604. To unsubscribe, or for help writing mail filters, visit settings.

            Gerrit-Project: chromium/src
            Gerrit-Branch: master
            Gerrit-MessageType: comment
            Gerrit-Change-Id: I4dba348a2e0b291df17bf930c44b1aa2d0ea918c
            Gerrit-Change-Number: 727604
            Gerrit-PatchSet: 1
            Gerrit-Owner: Taiju Tsuiki <tz...@chromium.org>
            Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
            Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
            Gerrit-Reviewer: Taiju Tsuiki <tz...@chromium.org>
            Gerrit-CC: Commit Bot <commi...@chromium.org>
            Gerrit-CC: Rob Buis <rob....@samsung.com>
            Gerrit-Comment-Date: Fri, 20 Oct 2017 07:35:04 +0000
            Gerrit-HasComments: No
            Gerrit-HasLabels: No

            Taiju Tsuiki (Gerrit)

            unread,
            Oct 20, 2017, 7:36:27 AM10/20/17
            to blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, dtapuska+...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, Hayato Ito, Kouhei Ueno, Commit Bot, chromium...@chromium.org, Rob Buis

            Patch set 2:Commit-Queue +2

            View Change

              To view, visit change 727604. To unsubscribe, or for help writing mail filters, visit settings.

              Gerrit-Project: chromium/src
              Gerrit-Branch: master
              Gerrit-MessageType: comment
              Gerrit-Change-Id: I4dba348a2e0b291df17bf930c44b1aa2d0ea918c
              Gerrit-Change-Number: 727604
              Gerrit-PatchSet: 2
              Gerrit-Owner: Taiju Tsuiki <tz...@chromium.org>
              Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
              Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
              Gerrit-Reviewer: Taiju Tsuiki <tz...@chromium.org>
              Gerrit-CC: Commit Bot <commi...@chromium.org>
              Gerrit-CC: Rob Buis <rob....@samsung.com>
              Gerrit-Comment-Date: Fri, 20 Oct 2017 11:36:19 +0000
              Gerrit-HasComments: No
              Gerrit-HasLabels: Yes

              Commit Bot (Gerrit)

              unread,
              Oct 20, 2017, 7:36:36 AM10/20/17
              to Taiju Tsuiki, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, dtapuska+...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, Hayato Ito, Kouhei Ueno, chromium...@chromium.org, Rob Buis

              CQ is trying da patch.

              Note: The patchset sent to CQ was uploaded after this CL was approved.
              "rebase" https://chromium-review.googlesource.com/c/727604/2

              Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/727604/2

              Bot data: {"action": "start", "triggered_at": "2017-10-20T11:36:19.0Z", "cq_cfg_revision": "fc2b2f04ed20d88113c10951036ca403891c435f", "revision": "12efb8b6e3b62baf78040b77c2f1c2d4f032861b"}

              View Change

                To view, visit change 727604. To unsubscribe, or for help writing mail filters, visit settings.

                Gerrit-Project: chromium/src
                Gerrit-Branch: master
                Gerrit-MessageType: comment
                Gerrit-Change-Id: I4dba348a2e0b291df17bf930c44b1aa2d0ea918c
                Gerrit-Change-Number: 727604
                Gerrit-PatchSet: 2
                Gerrit-Owner: Taiju Tsuiki <tz...@chromium.org>
                Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
                Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
                Gerrit-Reviewer: Taiju Tsuiki <tz...@chromium.org>
                Gerrit-CC: Commit Bot <commi...@chromium.org>
                Gerrit-CC: Rob Buis <rob....@samsung.com>
                Gerrit-Comment-Date: Fri, 20 Oct 2017 11:36:32 +0000
                Gerrit-HasComments: No
                Gerrit-HasLabels: No

                Commit Bot (Gerrit)

                unread,
                Oct 20, 2017, 9:34:56 AM10/20/17
                to Taiju Tsuiki, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, dtapuska+...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, Hayato Ito, Kouhei Ueno, chromium...@chromium.org, Rob Buis

                Commit Bot merged this change.

                View Change

                Approvals: Hayato Ito: Looks good to me Kouhei Ueno: Looks good to me Taiju Tsuiki: Commit
                Replace WTF::RefPtr with scoped_refptr in core/dom

                scoped_refptr is allowed in Blink now, and WTF::RefPtr is an alias of
                scoped_refptr for migration. This CL inlines the alias to the RefPtr
                users in core/dom to remove RefPtr.

                Bug: 763844
                Change-Id: I4dba348a2e0b291df17bf930c44b1aa2d0ea918c
                Reviewed-on: https://chromium-review.googlesource.com/727604
                Commit-Queue: Taiju Tsuiki <tz...@chromium.org>
                Reviewed-by: Kouhei Ueno <kou...@chromium.org>
                Reviewed-by: Hayato Ito <hay...@chromium.org>
                Cr-Commit-Position: refs/heads/master@{#510419}
                ---
                M third_party/WebKit/Source/core/dom/BlinkCloneableMessage.h
                M third_party/WebKit/Source/core/dom/DOMImplementation.cpp
                M third_party/WebKit/Source/core/dom/Document.cpp
                M third_party/WebKit/Source/core/dom/Document.h
                M third_party/WebKit/Source/core/dom/DocumentModulatorImpl.cpp
                M third_party/WebKit/Source/core/dom/DocumentModulatorImpl.h
                M third_party/WebKit/Source/core/dom/DocumentTest.cpp
                M third_party/WebKit/Source/core/dom/DynamicModuleResolverTest.cpp
                M third_party/WebKit/Source/core/dom/Element.cpp
                M third_party/WebKit/Source/core/dom/Element.h
                M third_party/WebKit/Source/core/dom/ElementRareData.cpp
                M third_party/WebKit/Source/core/dom/ElementRareData.h
                M third_party/WebKit/Source/core/dom/FirstLetterPseudoElement.cpp
                M third_party/WebKit/Source/core/dom/LayoutTreeBuilder.h
                M third_party/WebKit/Source/core/dom/MessagePort.cpp
                M third_party/WebKit/Source/core/dom/MessagePort.h
                M third_party/WebKit/Source/core/dom/ModulatorImplBase.cpp
                M third_party/WebKit/Source/core/dom/ModulatorImplBase.h
                M third_party/WebKit/Source/core/dom/Node.cpp
                M third_party/WebKit/Source/core/dom/Node.h
                M third_party/WebKit/Source/core/dom/PseudoElement.cpp
                M third_party/WebKit/Source/core/dom/PseudoElement.h
                M third_party/WebKit/Source/core/dom/QualifiedName.h
                M third_party/WebKit/Source/core/dom/RemoteSecurityContext.cpp
                M third_party/WebKit/Source/core/dom/RemoteSecurityContext.h
                M third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp
                M third_party/WebKit/Source/core/dom/ScriptRunner.h
                M third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp
                M third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.h
                M third_party/WebKit/Source/core/dom/SecurityContext.cpp
                M third_party/WebKit/Source/core/dom/SecurityContext.h
                M third_party/WebKit/Source/core/dom/SpaceSplitString.cpp
                M third_party/WebKit/Source/core/dom/SpaceSplitString.h
                M third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp
                M third_party/WebKit/Source/core/dom/TaskRunnerHelper.h
                M third_party/WebKit/Source/core/dom/UserGestureIndicator.cpp
                M third_party/WebKit/Source/core/dom/UserGestureIndicator.h
                M third_party/WebKit/Source/core/dom/UserGestureIndicatorTest.cpp
                M third_party/WebKit/Source/core/dom/WorkletModulatorImpl.cpp
                M third_party/WebKit/Source/core/dom/WorkletModulatorImpl.h
                M third_party/WebKit/Source/core/dom/events/CustomEvent.cpp
                M third_party/WebKit/Source/core/dom/events/CustomEvent.h
                42 files changed, 143 insertions(+), 123 deletions(-)


                To view, visit change 727604. To unsubscribe, or for help writing mail filters, visit settings.

                Gerrit-Project: chromium/src
                Gerrit-Branch: master
                Gerrit-MessageType: merged
                Gerrit-Change-Id: I4dba348a2e0b291df17bf930c44b1aa2d0ea918c
                Gerrit-Change-Number: 727604
                Gerrit-PatchSet: 3
                Gerrit-Owner: Taiju Tsuiki <tz...@chromium.org>
                Gerrit-Reviewer: Commit Bot <commi...@chromium.org>
                Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
                Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
                Gerrit-Reviewer: Taiju Tsuiki <tz...@chromium.org>
                Reply all
                Reply to author
                Forward
                0 new messages