Remove support for inline text tracks [chromium/src : master]

Blink WPT Bot (Gerrit)

unread,

May 23, 2018, 3:09:16 PM5/23/18

to Ted Meyer, alexmo...@chromium.org, alokp...@chromium.org, amp+...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, imchen...@chromium.org, isherif...@chromium.org, jasonrobe...@google.com, jochen...@chromium.org, lcwu+...@chromium.org, miu+...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, poscia...@chromium.org, xjz+...@chromium.org, Commit Bot, Dale Curtis, Ted Meyer, Peter Beverloo, Mounir Lamouri, chromium...@chromium.org, John Abd-El-Malek

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/w3c/web-platform-tests/pull/11132.

If this CL lands and Travis CI upstream is green, we will auto-merge the PR.

Note: Please check the Travis CI status (at the bottom of the PR) before landing this CL and only land this CL if the status is green. Otherwise a human needs to step in and resolve it manually. (This may be automated in the future, see https://crbug.com/711447)

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md#Automatic-export-process

View Change

To view, visit change 1058930. To unsubscribe, or for help writing mail filters, visit settings.

Dale Curtis (Gerrit)

unread,

May 23, 2018, 3:46:09 PM5/23/18

to Ted Meyer, alexmo...@chromium.org, alokp...@chromium.org, amp+...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, imchen...@chromium.org, isherif...@chromium.org, jasonrobe...@google.com, jochen...@chromium.org, lcwu+...@chromium.org, miu+...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, poscia...@chromium.org, xjz+...@chromium.org, Blink WPT Bot, Commit Bot, Ted Meyer, Peter Beverloo, Mounir Lamouri, chromium...@chromium.org, John Abd-El-Malek

View Change

1 comment:

File third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/media-elements/track/track-element/track-remove-track.html:
- Patch Set #8, Line 1:
  Hmm why did you delete this? This is an external test.

To view, visit change 1058930. To unsubscribe, or for help writing mail filters, visit settings.

Ted Meyer (Gerrit)

unread,

May 23, 2018, 5:18:18 PM5/23/18

to alexmo...@chromium.org, alokp...@chromium.org, amp+...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, imchen...@chromium.org, isherif...@chromium.org, jasonrobe...@google.com, jochen...@chromium.org, lcwu+...@chromium.org, miu+...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, poscia...@chromium.org, xjz+...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, Dale Curtis, Blink WPT Bot, Commit Bot, Ted Meyer, Peter Beverloo, Mounir Lamouri, chromium...@chromium.org, John Abd-El-Malek

View Change

1 comment:

File third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/media-elements/track/track-element/track-remove-track.html:

- Patch Set #8, Line 1:
  Hmm why did you delete this? This is an external test.

- splitting it in https://chromium-review.googlesource.com/c/chromium/src/+/1070570, will disable the inband part here when that gets merged.

To view, visit change 1058930. To unsubscribe, or for help writing mail filters, visit settings.

Dale Curtis (Gerrit)

unread,

May 24, 2018, 4:58:23 PM5/24/18

to Ted Meyer, alexmo...@chromium.org, alokp...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, imchen...@chromium.org, isherif...@chromium.org, jasonrobe...@google.com, jochen...@chromium.org, lcwu+...@chromium.org, miu+...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, poscia...@chromium.org, xjz+...@chromium.org, amp+...@chromium.org, blink-revie...@chromium.org, Blink WPT Bot, Commit Bot, Ted Meyer, Peter Beverloo, Mounir Lamouri, chromium...@chromium.org, John Abd-El-Malek

lgtm. Thanks!

View Change

To view, visit change 1058930. To unsubscribe, or for help writing mail filters, visit settings.

Ted Meyer (Gerrit)

unread,

May 24, 2018, 5:00:30 PM5/24/18

to alexmo...@chromium.org, alokp...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, imchen...@chromium.org, isherif...@chromium.org, jasonrobe...@google.com, jochen...@chromium.org, lcwu+...@chromium.org, miu+...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, poscia...@chromium.org, xjz+...@chromium.org, amp+...@chromium.org, blink-revie...@chromium.org, Dale Curtis, Blink WPT Bot, Commit Bot, Ted Meyer, Peter Beverloo, Mounir Lamouri, chromium...@chromium.org, John Abd-El-Malek

Patch set 11:Commit-Queue +2

View Change

To view, visit change 1058930. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

May 24, 2018, 5:00:37 PM5/24/18

to Ted Meyer, alexmo...@chromium.org, alokp...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, imchen...@chromium.org, isherif...@chromium.org, jasonrobe...@google.com, jochen...@chromium.org, lcwu+...@chromium.org, miu+...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, poscia...@chromium.org, xjz+...@chromium.org, amp+...@chromium.org, blink-revie...@chromium.org, Dale Curtis, Blink WPT Bot, Ted Meyer, Peter Beverloo, Mounir Lamouri, chromium...@chromium.org, John Abd-El-Malek

CQ is trying the patch.

Note: The patchset sent to CQ was uploaded after this CL was approved.
"Failure -> Skip." https://chromium-review.googlesource.com/c/1058930/11

Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/1058930/11

Bot data: {"action": "start", "triggered_at": "2018-05-24T21:00:26.0Z", "cq_cfg_revision": "f5647662bbf78a128e2fe6956afaa13fb042b968", "revision": "f0af03ee997480cde547792208569498cd3d9fa9"}

View Change

To view, visit change 1058930. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

May 24, 2018, 5:07:00 PM5/24/18

to Ted Meyer, alexmo...@chromium.org, alokp...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, imchen...@chromium.org, isherif...@chromium.org, jasonrobe...@google.com, jochen...@chromium.org, lcwu+...@chromium.org, miu+...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, poscia...@chromium.org, xjz+...@chromium.org, amp+...@chromium.org, blink-revie...@chromium.org, Dale Curtis, Blink WPT Bot, Ted Meyer, Peter Beverloo, Mounir Lamouri, chromium...@chromium.org, John Abd-El-Malek

Try jobs failed on following builders:
  chromium_presubmit on luci.chromium.try (JOB_FAILED, https://ci.chromium.org/p/chromium/builders/luci.chromium.try/chromium_presubmit/123234)

View Change

To view, visit change 1058930. To unsubscribe, or for help writing mail filters, visit settings.

Ted Meyer (Gerrit)

unread,

May 25, 2018, 2:47:32 PM5/25/18

to Peter Beverloo, alexmo...@chromium.org, alokp...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, imchen...@chromium.org, isherif...@chromium.org, jasonrobe...@google.com, jochen...@chromium.org, lcwu+...@chromium.org, miu+...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, poscia...@chromium.org, xjz+...@chromium.org, amp+...@chromium.org, blink-revie...@chromium.org, Dale Curtis, Mounir Lamouri

Ted Meyer would like Peter Beverloo to review this change.

View Change

Remove support for inline text tracks

inline text tracks are currently hidden behind a feature flag and is
almost completely unused, so this CL removes the flag as well as all
behavior that would be enabled by its use.

Bug: 826419
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ide06bcde063ec57898e3129c28550929fa4104ea
---
M chromecast/media/cma/test/frame_segmenter_for_test.cc
M content/browser/renderer_host/render_process_host_impl.cc
M content/shell/app/shell_main_delegate.cc
M media/base/demuxer.h
M media/base/media_switches.cc
M media/base/media_switches.h
M media/base/media_url_demuxer.cc
M media/base/media_url_demuxer.h
M media/base/media_url_demuxer_unittest.cc
M media/base/mock_demuxer_host.h
M media/base/mock_filters.h
M media/base/pipeline_impl.cc
M media/base/pipeline_impl.h
M media/base/pipeline_impl_unittest.cc
M media/cast/sender/h264_vt_encoder_unittest.cc
M media/filters/chunk_demuxer.cc
M media/filters/chunk_demuxer.h
M media/filters/chunk_demuxer_unittest.cc
M media/filters/demuxer_perftest.cc
M media/filters/ffmpeg_demuxer.cc
M media/filters/ffmpeg_demuxer.h
M media/filters/ffmpeg_demuxer_unittest.cc
M media/test/pipeline_integration_test.cc
M media/test/run_all_unittests.cc
M third_party/WebKit/LayoutTests/TestExpectations
25 files changed, 101 insertions(+), 892 deletions(-)

To view, visit change 1058930. To unsubscribe, or for help writing mail filters, visit settings.

Ted Meyer (Gerrit)

unread,

May 25, 2018, 2:54:50 PM5/25/18

to alexmo...@chromium.org, alokp...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, imchen...@chromium.org, isherif...@chromium.org, jasonrobe...@google.com, jochen...@chromium.org, lcwu+...@chromium.org, miu+...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, poscia...@chromium.org, xjz+...@chromium.org, amp+...@chromium.org, blink-revie...@chromium.org, Peter Beverloo, Dale Curtis, Blink WPT Bot, Commit Bot, Ted Meyer, Mounir Lamouri, chromium...@chromium.org, John Abd-El-Malek

+pe...@chromium.org for
    chromecast/media/cma/test/frame_segmenter_for_test.cc
    content/browser/renderer_host/render_process_host_impl.cc
    content/shell/app/shell_main_delegate.cc

Thanks!

View Change

To view, visit change 1058930. To unsubscribe, or for help writing mail filters, visit settings.

Ted Meyer (Gerrit)

unread,

May 25, 2018, 4:49:31 PM5/25/18

to alexmo...@chromium.org, alokp...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, imchen...@chromium.org, isherif...@chromium.org, jasonrobe...@google.com, jochen...@chromium.org, lcwu+...@chromium.org, miu+...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, poscia...@chromium.org, xjz+...@chromium.org, amp+...@chromium.org, blink-revie...@chromium.org, Kenneth MacKay, John Abd-El-Malek, Peter Beverloo, Dale Curtis, Blink WPT Bot, Commit Bot, Ted Meyer, Mounir Lamouri, chromium...@chromium.org

I guess I needed more owners for the following files:
    chromecast/media/cma/test/frame_segmenter_for_test.cc
    content/browser/renderer_host/render_process_host_impl.cc
    content/shell/app/shell_main_delegate.cc

Thanks!

View Change

To view, visit change 1058930. To unsubscribe, or for help writing mail filters, visit settings.

Kenneth MacKay (Gerrit)

unread,

May 25, 2018, 5:06:23 PM5/25/18

to Ted Meyer, alexmo...@chromium.org, alokp...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, imchen...@chromium.org, isherif...@chromium.org, jasonrobe...@google.com, jochen...@chromium.org, lcwu+...@chromium.org, miu+...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, poscia...@chromium.org, xjz+...@chromium.org, amp+...@chromium.org, blink-revie...@chromium.org, John Abd-El-Malek, Peter Beverloo, Dale Curtis, Blink WPT Bot, Commit Bot, Ted Meyer, Mounir Lamouri, chromium...@chromium.org

Patch set 11:Code-Review +1

View Change

To view, visit change 1058930. To unsubscribe, or for help writing mail filters, visit settings.

John Abd-El-Malek (Gerrit)

unread,

May 25, 2018, 6:21:10 PM5/25/18

to Ted Meyer, alexmo...@chromium.org, alokp...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, imchen...@chromium.org, isherif...@chromium.org, jasonrobe...@google.com, jochen...@chromium.org, lcwu+...@chromium.org, miu+...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, poscia...@chromium.org, xjz+...@chromium.org, amp+...@chromium.org, blink-revie...@chromium.org, Kenneth MacKay, Peter Beverloo, Dale Curtis, Blink WPT Bot, Commit Bot, Ted Meyer, Mounir Lamouri, chromium...@chromium.org

Patch set 11:Code-Review +1

View Change

To view, visit change 1058930. To unsubscribe, or for help writing mail filters, visit settings.

Ted Meyer (Gerrit)

unread,

May 25, 2018, 7:11:21 PM5/25/18

to alexmo...@chromium.org, alokp...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, imchen...@chromium.org, isherif...@chromium.org, jasonrobe...@google.com, jochen...@chromium.org, lcwu+...@chromium.org, miu+...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, poscia...@chromium.org, xjz+...@chromium.org, amp+...@chromium.org, blink-revie...@chromium.org, John Abd-El-Malek, Kenneth MacKay, Peter Beverloo, Dale Curtis, Blink WPT Bot, Commit Bot, Ted Meyer, Mounir Lamouri, chromium...@chromium.org

Patch set 11:Commit-Queue +2

View Change

To view, visit change 1058930. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

May 25, 2018, 8:21:37 PM5/25/18

to Ted Meyer, alexmo...@chromium.org, alokp...@chromium.org, blink-...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, imchen...@chromium.org, isherif...@chromium.org, jasonrobe...@google.com, jochen...@chromium.org, lcwu+...@chromium.org, miu+...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, poscia...@chromium.org, xjz+...@chromium.org, amp+...@chromium.org, blink-revie...@chromium.org, John Abd-El-Malek, Kenneth MacKay, Peter Beverloo, Dale Curtis, Blink WPT Bot, Ted Meyer, Mounir Lamouri, chromium...@chromium.org

Commit Bot merged this change.

View Change

Approvals:
  Dale Curtis: Looks good to me
  John Abd-El-Malek: Looks good to me
  Kenneth MacKay: Looks good to me
  Ted Meyer: Commit

Remove support for inline text tracks

inline text tracks are currently hidden behind a feature flag and is
almost completely unused, so this CL removes the flag as well as all
behavior that would be enabled by its use.

Bug: 826419
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ide06bcde063ec57898e3129c28550929fa4104ea

Reviewed-on: https://chromium-review.googlesource.com/1058930
Reviewed-by: Kenneth MacKay <kma...@chromium.org>
Reviewed-by: John Abd-El-Malek <j...@chromium.org>
Reviewed-by: Dale Curtis <dalec...@chromium.org>
Commit-Queue: Ted Meyer <tmath...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562080}

Reply all

Reply to author

Forward