[LayoutNG] Implement wbr tag [chromium/src : master]

Koji Ishii (Gerrit)

unread,

Aug 17, 2017, 10:01:35 PM8/17/17

to atotic+...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, eae+bli...@chromium.org, glebl+...@chromium.org, jchaffraix...@chromium.org, lchoi+...@chromium.org, leviw+re...@chromium.org, ojan+...@chromium.org, pdr+renderi...@chromium.org, szager+la...@chromium.org, zol...@webkit.org, Emil A Eklund, Xiaocheng Hu, Commit Bot, Christian Biesinger, chromium...@chromium.org, Xiaocheng Hu

PTAL.

View Change

To view, visit change 619410. To unsubscribe, or for help writing mail filters, visit settings.

Xiaocheng Hu (Gerrit)

unread,

Aug 17, 2017, 10:28:31 PM8/17/17

to Koji Ishii, atotic+...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, eae+bli...@chromium.org, glebl+...@chromium.org, jchaffraix...@chromium.org, lchoi+...@chromium.org, leviw+re...@chromium.org, ojan+...@chromium.org, pdr+renderi...@chromium.org, szager+la...@chromium.org, zol...@webkit.org, Emil A Eklund, Xiaocheng Hu, Commit Bot, Christian Biesinger, chromium...@chromium.org

LGTM with the change in NGInlineNode and NGInlineItemsBuilder related to offset mapping.

Not much idea about line breaking...

Patch set 3:Code-Review +1

View Change

To view, visit change 619410. To unsubscribe, or for help writing mail filters, visit settings.

Koji Ishii (Gerrit)

unread,

Aug 17, 2017, 11:56:37 PM8/17/17

to atotic+...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, eae+bli...@chromium.org, glebl+...@chromium.org, jchaffraix...@chromium.org, lchoi+...@chromium.org, leviw+re...@chromium.org, ojan+...@chromium.org, pdr+renderi...@chromium.org, szager+la...@chromium.org, zol...@webkit.org, Xiaocheng Hu, Emil A Eklund, Xiaocheng Hu, Commit Bot, Christian Biesinger, chromium...@chromium.org

Patch Set 3: Code-Review+1

LGTM with the change in NGInlineNode and NGInlineItemsBuilder related to offset mapping.
Not much idea about line breaking...

Can you suggest how to fix offset mapping?

View Change

To view, visit change 619410. To unsubscribe, or for help writing mail filters, visit settings.

Xiaocheng Hu (Gerrit)

unread,

Aug 18, 2017, 1:20:56 AM8/18/17

to Koji Ishii, atotic+...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, eae+bli...@chromium.org, glebl+...@chromium.org, jchaffraix...@chromium.org, lchoi+...@chromium.org, leviw+re...@chromium.org, ojan+...@chromium.org, pdr+renderi...@chromium.org, szager+la...@chromium.org, zol...@webkit.org, Emil A Eklund, Xiaocheng Hu, Commit Bot, Christian Biesinger, chromium...@chromium.org

Patch Set 3:

Patch Set 3: Code-Review+1
LGTM with the change in NGInlineNode and NGInlineItemsBuilder related to offset mapping.
Not much idea about line breaking...
Can you suggest how to fix offset mapping?

Do mean mean this patch breaks offset mapping? I don't see that.

View Change

To view, visit change 619410. To unsubscribe, or for help writing mail filters, visit settings.

Koji Ishii (Gerrit)

unread,

Aug 18, 2017, 2:26:49 AM8/18/17

to atotic+...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, eae+bli...@chromium.org, glebl+...@chromium.org, jchaffraix...@chromium.org, lchoi+...@chromium.org, leviw+re...@chromium.org, ojan+...@chromium.org, pdr+renderi...@chromium.org, szager+la...@chromium.org, zol...@webkit.org, Xiaocheng Hu, Emil A Eklund, Xiaocheng Hu, Commit Bot, Christian Biesinger, chromium...@chromium.org

LGTM with the change in NGInlineNode and NGInlineItemsBuilder related to offset mapping.
Not much idea about line breaking...
Can you suggest how to fix offset mapping?
Do mean mean this patch breaks offset mapping? I don't see that.

Ah, I think I understand now. Since you wrote "LGTM with the change...", I understood "LGTM with nit: change..."; i.e., you're good if I make a change. You probably meant "LGTM for the change...", no?

View Change

To view, visit change 619410. To unsubscribe, or for help writing mail filters, visit settings.

Xiaocheng Hu (Gerrit)

unread,

Aug 18, 2017, 3:18:25 AM8/18/17

to Koji Ishii, atotic+...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, eae+bli...@chromium.org, glebl+...@chromium.org, jchaffraix...@chromium.org, lchoi+...@chromium.org, leviw+re...@chromium.org, ojan+...@chromium.org, pdr+renderi...@chromium.org, szager+la...@chromium.org, zol...@webkit.org, Emil A Eklund, Xiaocheng Hu, Commit Bot, Christian Biesinger, chromium...@chromium.org

Patch Set 3:

LGTM with the change in NGInlineNode and NGInlineItemsBuilder related to offset mapping.
Not much idea about line breaking...
Can you suggest how to fix offset mapping?
Do mean mean this patch breaks offset mapping? I don't see that.
Ah, I think I understand now. Since you wrote "LGTM with the change...", I understood "LGTM with nit: change..."; i.e., you're good if I make a change. You probably meant "LGTM for the change...", no?

Yup. No problem with the change.

View Change

To view, visit change 619410. To unsubscribe, or for help writing mail filters, visit settings.

Koji Ishii (Gerrit)

unread,

Aug 23, 2017, 5:26:34 AM8/23/17

to atotic+...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, eae+bli...@chromium.org, glebl+...@chromium.org, jchaffraix...@chromium.org, lchoi+...@chromium.org, leviw+re...@chromium.org, ojan+...@chromium.org, pdr+renderi...@chromium.org, szager+la...@chromium.org, zol...@webkit.org, Xiaocheng Hu, Emil A Eklund, Xiaocheng Hu, Commit Bot, Christian Biesinger, chromium...@chromium.org

Patch set 3:Commit-Queue +2

View Change

To view, visit change 619410. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Aug 23, 2017, 8:39:42 AM8/23/17

to Koji Ishii, atotic+...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, eae+bli...@chromium.org, glebl+...@chromium.org, jchaffraix...@chromium.org, lchoi+...@chromium.org, leviw+re...@chromium.org, ojan+...@chromium.org, pdr+renderi...@chromium.org, szager+la...@chromium.org, zol...@webkit.org, Xiaocheng Hu, Emil A Eklund, Xiaocheng Hu, Christian Biesinger, chromium...@chromium.org

Commit Bot merged this change.

View Change

Approvals:
  Xiaocheng Hu: Looks good to me
  Koji Ishii: Commit

[LayoutNG] Implement wbr tag

Bug: 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I9f10d573795341ec7f994d9dedf5321093a59193
Reviewed-on: https://chromium-review.googlesource.com/619410
Reviewed-by: Xiaocheng Hu <xiaoc...@chromium.org>
Commit-Queue: Koji Ishii <ko...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496663}
---
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
M third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.cc
M third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc
M third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc
4 files changed, 31 insertions(+), 20 deletions(-)

To view, visit change 619410. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward