Make nextLinePosition() not to use Position::deprecatedEditingOffset() (issue 1259803008 by yosin@chromium.org)

yo...@chromium.org

unread,

Aug 3, 2015, 2:46:45 AM8/3/15

to tk...@chromium.org, yoi...@chromium.org, hajim...@chromium.org, blink-...@chromium.org

Reviewers: tkent, yoichio, hajimehoshi,

Message:
PTAL

Description:
Make nextLinePosition() not to use Position::deprecatedEditingOffset()

This patch replaces |Position::deprecatedEditingOffset()| call in
|nextLinePosition()| by |Position::computeEditingOffset()|, since it is used
for computing offset of |VisiblePosition| which can not be middle of editing
ignore content, for improving code health.

This patch is a preparation of getting rid of legacy editing position.

BUG=513114
TEST=n/a; no behavior changes

Please review this at https://codereview.chromium.org/1259803008/

Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Affected files (+1, -1 lines):
M Source/core/editing/VisibleUnits.cpp

Index: Source/core/editing/VisibleUnits.cpp
diff --git a/Source/core/editing/VisibleUnits.cpp
b/Source/core/editing/VisibleUnits.cpp
index
4c03e8fab0de25c63ecc2e239e140271133931ed..3df0929eb37a6e181c2e30bd6736d51c9cdc431a
100644
--- a/Source/core/editing/VisibleUnits.cpp
+++ b/Source/core/editing/VisibleUnits.cpp
@@ -1036,7 +1036,7 @@ VisiblePosition nextLinePosition(const
VisiblePosition &visiblePosition, LayoutU

if (!root) {
// FIXME: We need do the same in previousLinePosition.
- Node* child = NodeTraversal::childAt(*node,
p.deprecatedEditingOffset());
+ Node* child = NodeTraversal::childAt(*node,
p.computeEditingOffset());
node = child ? child : &NodeTraversal::lastWithinOrSelf(*node);
Position position = nextRootInlineBoxCandidatePosition(node,
visiblePosition, editableType);
if (position.isNotNull()) {