Re: Support type selector for camel-cased SVG elements in HTML. (issue 1099963003 by rune@opera.com)

[ru...@opera.com]

ping

https://codereview.chromium.org/1099963003/

[esp...@chromium.org]

On 2015/04/29 at 10:43:07, rune wrote:
> ping

I talked to tab about this, why not just treat SVG case insensitively
always?

https://1c9a255-dot-chromiumcodereview-hr.appspot.com/1099963003/

[ru...@opera.com]

On 2015/04/30 01:04:42, esprehn wrote:
> On 2015/04/29 at 10:43:07, rune wrote:
> > ping

> I talked to tab about this, why not just treat SVG case insensitively
> always?

I don't know the rationale for the way it's spec'ed. Hixie would know, I
guess.
I found some very long posts on the whatwg list, but not able to find a
definitive answer. What's really weird is the inconsistency between
case-insensitivity of tag names in the source and the case-sensitivity of
the
selector against the camelCased form the tags names are transformed into.


https://1c9a255-dot-chromiumcodereview-hr.appspot.com/1099963003/

[esp...@chromium.org]

On 2015/04/30 at 11:20:39, rune wrote:
> On 2015/04/30 01:04:42, esprehn wrote:
> > On 2015/04/29 at 10:43:07, rune wrote:
> > > ping
> >
> > I talked to tab about this, why not just treat SVG case insensitively
always?

> I don't know the rationale for the way it's spec'ed. Hixie would know, I
guess. I found some very long posts on the whatwg list, but not able to
find a
definitive answer. What's really weird is the inconsistency between
case-insensitivity of tag names in the source and the case-sensitivity of
the
selector against the camelCased form the tags names are transformed into.

I talked to Tab about this more today, I think the agreement is to just make
selectors always match everything case insensitively. So we'd change
matchesTagName to have a check for isHTMLElement() and do what it does now,
and
another case where it does a case insensitive compare of the localName (and
namespace?)

https://codereview.chromium.org/1099963003/

[ru...@opera.com]

I've uploaded new patch sets and modified the description with notes in both
description and tests about the spec violation.

I've run blink_perf.css which looks ok locally.


https://codereview.chromium.org/1099963003/

[ru...@opera.com]

https://codereview.chromium.org/1099963003/diff/140001/Source/core/css/SelectorChecker.h
File Source/core/css/SelectorChecker.h (right):

https://codereview.chromium.org/1099963003/diff/140001/Source/core/css/SelectorChecker.h#newcode32
Source/core/css/SelectorChecker.h:32: #include "core/dom/Document.h"
Another rebase-leftover.

https://codereview.chromium.org/1099963003/

[ru...@opera.com]

https://codereview.chromium.org/1099963003/diff/140001/Source/core/css/SelectorChecker.h
File Source/core/css/SelectorChecker.h (right):

https://codereview.chromium.org/1099963003/diff/140001/Source/core/css/SelectorChecker.h#newcode32
Source/core/css/SelectorChecker.h:32: #include "core/dom/Document.h"

On 2015/05/05 13:36:48, rune wrote:
> Another rebase-leftover.

Done.

https://codereview.chromium.org/1099963003/