Remove //third_party/WebKit/PerformanceTests/.gitattributes [chromium/src : master]
2 views
Skip to first unread message
Kent Tamura (Gerrit)
Apr 24, 2018, 5:55:33 AM4/24/18
to Quinten Yearsley, blink-...@chromium.org, Kent Tamura
Kent Tamura would like Quinten Yearsley to review this change.
Remove //third_party/WebKit/PerformanceTests/.gitattributes
- PageLoad/ didn't exist.
- jquery-1.3.2.js: This file had CRLF line endings until [1], and
"-crlf" preserved CRLFs. However now it has LF line endings and we
recommend to set "core.autocrlf false" [2], so the "-crlf" setting
has no effect.
[1] crrev.com/056fd80b6fa7f2fb869cf3eabe1117cd5e0d6fe0
[2] http://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/depot_tools_tutorial.html
Bug: 829695
Change-Id: I0618beaef25e13304ced653a0adc5c8e35f4c42b
---
D third_party/WebKit/PerformanceTests/.gitattributes
1 file changed, 0 insertions(+), 7 deletions(-)
diff --git a/third_party/WebKit/PerformanceTests/.gitattributes b/third_party/WebKit/PerformanceTests/.gitattributes
deleted file mode 100644
index 74e8137..0000000
--- a/third_party/WebKit/PerformanceTests/.gitattributes
+++ /dev/null
@@ -1,7 +0,0 @@
-PageLoad/svg/files/Harvey_Rayner.svg -crlf
-PageLoad/svg/files/cacuts_02.svg -crlf
-PageLoad/svg/files/crawfish2_ganson.svg -crlf
-PageLoad/svg/files/france.svg -crlf
-PageLoad/svg/files/mtsthelens.svg -crlf
-PageLoad/svg/files/worldcup.svg -crlf
-SunSpider/tests/parse-only/jquery-1.3.2.js -crlf
To view, visit change 1025411. To unsubscribe, or for help writing mail filters, visit settings.
Kent Tamura (Gerrit)
Apr 24, 2018, 5:55:34 AM4/24/18
to Kent Tamura, blink-...@chromium.org, Quinten Yearsley, Commit Bot, chromium...@chromium.org
Quinten, would you review this please?
Quinten Yearsley (Gerrit)
Apr 24, 2018, 10:38:44 AM4/24/18
to Kent Tamura, blink-...@chromium.org, Commit Bot, chromium...@chromium.org
Thanks, LGTM
Patch set 3:Code-Review +1
Kent Tamura (Gerrit)
Apr 24, 2018, 7:06:37 PM4/24/18
to Kent Tamura, blink-...@chromium.org, Quinten Yearsley, Commit Bot, chromium...@chromium.org
Patch set 3:Commit-Queue +2
Commit Bot (Gerrit)
Apr 24, 2018, 7:10:19 PM4/24/18
to Kent Tamura, blink-...@chromium.org, Quinten Yearsley, chromium...@chromium.org
Commit Bot merged this change.
Approvals:
Quinten Yearsley: Looks good to me
Kent Tamura: Commit
Remove //third_party/WebKit/PerformanceTests/.gitattributes
- PageLoad/ didn't exist.
- jquery-1.3.2.js: This file had CRLF line endings until [1], and
"-crlf" preserved CRLFs. However now it has LF line endings and we
recommend to set "core.autocrlf false" [2], so the "-crlf" setting
has no effect.
[1] crrev.com/056fd80b6fa7f2fb869cf3eabe1117cd5e0d6fe0
[2] http://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/depot_tools_tutorial.html
Bug: 829695
Change-Id: I0618beaef25e13304ced653a0adc5c8e35f4c42b
Reviewed-on: https://chromium-review.googlesource.com/1025411
Reviewed-by: Quinten Yearsley <qyea...@chromium.org>
Commit-Queue: Kent Tamura <tk...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553343}
---
D third_party/WebKit/PerformanceTests/.gitattributes
1 file changed, 0 insertions(+), 7 deletions(-)
diff --git a/third_party/WebKit/PerformanceTests/.gitattributes b/third_party/WebKit/PerformanceTests/.gitattributes
deleted file mode 100644
index 74e8137..0000000
--- a/third_party/WebKit/PerformanceTests/.gitattributes
+++ /dev/null
@@ -1,7 +0,0 @@
-PageLoad/svg/files/Harvey_Rayner.svg -crlf
-PageLoad/svg/files/cacuts_02.svg -crlf
-PageLoad/svg/files/crawfish2_ganson.svg -crlf
-PageLoad/svg/files/france.svg -crlf
-PageLoad/svg/files/mtsthelens.svg -crlf
-PageLoad/svg/files/worldcup.svg -crlf
-SunSpider/tests/parse-only/jquery-1.3.2.js -crlf
To view, visit change 1025411. To unsubscribe, or for help writing mail filters, visit settings.
Reply all
Reply to author
Forward
0 new messages