[DevTools] Removed DOMAgent.getEventListenerForNode (issue 1149713006 by kozyatinskiy@chromium.org)

0 views
Skip to first unread message

kozyat...@chromium.org

unread,
May 21, 2015, 9:32:56 AM5/21/15
to pfel...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, yurys...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, sergey...@chromium.org, kozyatins...@chromium.org
Reviewers: pfeldman_slow,

Message:
ptal

Description:
[DevTools] Removed DOMAgent.getEventListenerForNode

This methods was replaced with DOMDebugger.getEventListeners.

BUG=469159
R=pfel...@chromium.org

Please review this at https://codereview.chromium.org/1149713006/

Base URL:
https://chromium.googlesource.com/chromium/blink.git@extract-event-listeners-tree-outline

Affected files (+0, -152 lines):
M Source/core/inspector/InspectorDOMAgent.h
M Source/core/inspector/InspectorDOMAgent.cpp
M Source/devtools/front_end/sdk/DOMModel.js
M Source/devtools/protocol.json


yu...@chromium.org

unread,
May 21, 2015, 11:20:46 AM5/21/15
to kozyat...@chromium.org, pfel...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, yurys...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, sergey...@chromium.org, kozyatins...@chromium.org

https://codereview.chromium.org/1149713006/diff/1/Source/devtools/protocol.json
File Source/devtools/protocol.json (left):

https://codereview.chromium.org/1149713006/diff/1/Source/devtools/protocol.json#oldcode2350
Source/devtools/protocol.json:2350: { "name": "listeners", "type":
"array", "items": { "$ref": "EventListener" }, "description": "Array of
relevant listeners." }
EventListener type definition should be removed from DOM domain as it
unused now.

https://codereview.chromium.org/1149713006/

kozyat...@chromium.org

unread,
May 22, 2015, 6:57:22 AM5/22/15
to pfel...@chromium.org, yu...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, yurys...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, sergey...@chromium.org, kozyatins...@chromium.org

https://codereview.chromium.org/1149713006/diff/1/Source/devtools/protocol.json
File Source/devtools/protocol.json (left):

https://codereview.chromium.org/1149713006/diff/1/Source/devtools/protocol.json#oldcode2350
Source/devtools/protocol.json:2350: { "name": "listeners", "type":
"array", "items": { "$ref": "EventListener" }, "description": "Array of
relevant listeners." }
On 2015/05/21 15:20:45, yurys wrote:
> EventListener type definition should be removed from DOM domain as it
unused
> now.

Done.

https://codereview.chromium.org/1149713006/

kozyat...@chromium.org

unread,
May 25, 2015, 2:22:44 PM5/25/15
to pfel...@chromium.org, yu...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, yurys...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, sergey...@chromium.org, kozyatins...@chromium.org
friendly ping.

https://codereview.chromium.org/1149713006/

yu...@chromium.org

unread,
May 26, 2015, 12:23:32 AM5/26/15
to kozyat...@chromium.org, pfel...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, yurys...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, sergey...@chromium.org, kozyatins...@chromium.org
lgtm



https://codereview.chromium.org/1149713006/

'I haz the power - commit-bot' via codereview.chromium.org

unread,
May 26, 2015, 1:02:47 AM5/26/15
to kozyat...@chromium.org, pfel...@chromium.org, yu...@chromium.org, commi...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, yurys...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, sergey...@chromium.org, kozyatins...@chromium.org
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1149713006/20001


https://codereview.chromium.org/1149713006/

'I haz the power - commit-bot' via codereview.chromium.org

unread,
May 26, 2015, 2:12:30 AM5/26/15
to kozyat...@chromium.org, pfel...@chromium.org, yu...@chromium.org, commi...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, yurys...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, sergey...@chromium.org, kozyatins...@chromium.org
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195890

https://codereview.chromium.org/1149713006/
Reply all
Reply to author
Forward
0 new messages