Move DevToolsCPUThrottler to platform/scheduler [chromium/src : master]
Dmitry Gozman (Gerrit)
Could you please take a look?
Patch set 1:Commit-Queue +1
To view, visit change 828145. To unsubscribe, or for help writing mail filters, visit settings.
Alexei Filippov (Gerrit)
Patch set 1:Code-Review +1
Alexander Timin (Gerrit)
Looks good overall, but we really could use some comments here.
1 comment:
File third_party/WebKit/Source/platform/scheduler/util/thread_cpu_throttler.h:
Patch Set #1, Line 21:
// Singleton that manages creation of the throttler thread.Could you please add a detailed comment explaining what this class does. Please include the following:
- Mechanism description (spawning a helper thread and issuing interrupts IIUC)
- Purpose (devtools)
- Description of SetThrottlingRate parameter (is it percentage? how do you start and stop throttling?)
To view, visit change 828145. To unsubscribe, or for help writing mail filters, visit settings.
Dmitry Gozman (Gerrit)
I added some comments. Are you fine with me landing this?
Patch set 2:Commit-Queue +1
1 comment:
File third_party/WebKit/Source/platform/scheduler/util/thread_cpu_throttler.h:
Patch Set #1, Line 21:
// This class is used to slow down the main thread forCould you please add a detailed comment explaining what this class does. […]
Done
To view, visit change 828145. To unsubscribe, or for help writing mail filters, visit settings.
Alexander Timin (Gerrit)
lgtm, thanks!
You'll also need an approval for third_party/WebKit/public, I believe.
Patch set 2:Code-Review +1
1 comment:
File third_party/WebKit/Source/platform/scheduler/util/thread_cpu_throttler.h:
Patch Set #2, Line 31:
thorttlingnit: throttling
To view, visit change 828145. To unsubscribe, or for help writing mail filters, visit settings.
Pavel Feldman (Gerrit)
Dmitry Gozman (Gerrit)
Thank you for review!
1 comment:
Patch Set #2, Line 31:
thorttlingnit: throttling
Done
To view, visit change 828145. To unsubscribe, or for help writing mail filters, visit settings.
Dmitry Gozman (Gerrit)
Patch set 3:Commit-Queue +2
Commit Bot (Gerrit)
CQ is trying the patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"typo" https://chromium-review.googlesource.com/c/828145/3
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/828145/3
Bot data: {"action": "start", "triggered_at": "2017-12-15T22:00:00.0Z", "cq_cfg_revision": "b547f51ef97353cccb06eebcda71133909f61295", "revision": "4030a075bcf671936d43a7ff2a2cd598392c3a55"}
Commit Bot (Gerrit)
Try jobs failed on following builders:
chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/619269)
ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/361818)
mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/569414)
win7_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win7_chromium_rel_ng/builds/66904)
Dmitry Gozman (Gerrit)
Patch set 4:Commit-Queue +2
Commit Bot (Gerrit)
CQ is trying the patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"rebased" https://chromium-review.googlesource.com/c/828145/4
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/828145/4
Bot data: {"action": "start", "triggered_at": "2017-12-16T00:06:31.0Z", "cq_cfg_revision": "b547f51ef97353cccb06eebcda71133909f61295", "revision": "8163818b3ff160202b666aa8bb4e00395df059c0"}
Commit Bot (Gerrit)
Commit Bot merged this change.
Move DevToolsCPUThrottler to platform/scheduler
This unblocks moving DevToolsAgent to blink.
Bug: 776009
Change-Id: Ie366481cc3913d864f773aa07007dd90aec0dc8d
Reviewed-on: https://chromium-review.googlesource.com/828145
Commit-Queue: Dmitry Gozman <dgo...@chromium.org>
Reviewed-by: Alexander Timin <alt...@chromium.org>
Reviewed-by: Pavel Feldman <pfel...@chromium.org>
Reviewed-by: Alexei Filippov <al...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524554}
---
M content/renderer/BUILD.gn
M content/renderer/devtools/devtools_agent.cc
M content/renderer/devtools/devtools_agent.h
D content/renderer/devtools/devtools_cpu_throttler.h
M third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
M third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.h
M third_party/WebKit/Source/core/inspector/InspectorEmulationAgent.cpp
M third_party/WebKit/Source/core/inspector/InspectorEmulationAgent.h
M third_party/WebKit/Source/platform/scheduler/BUILD.gn
M third_party/WebKit/Source/platform/scheduler/DEPS
R third_party/WebKit/Source/platform/scheduler/util/thread_cpu_throttler.cc
A third_party/WebKit/Source/platform/scheduler/util/thread_cpu_throttler.h
M third_party/WebKit/public/web/WebDevToolsAgentClient.h
13 files changed, 92 insertions(+), 113 deletions(-)