RemoteFontFaceSource: remove intervention related metrics [chromium/src : master]
Takashi Toyoshima (Gerrit)
Here is another cleanup to remove intervention related metrics, that you suggested in the last cleanup CL.
Can you take a look?
To view, visit change 722820. To unsubscribe, or for help writing mail filters, visit settings.
Kunihiko Sakamoto (Gerrit)
Thanks!
Would you mark these histograms as obsolete in histograms.xml?
Takashi Toyoshima (Gerrit)
Takashi Toyoshima would like Ilya Sherman to review this change.
RemoteFontFaceSource: remove intervention related metrics
Since the feature is already launched and we do not need to monitor
performance impact any more, let's remove intervention related metrics.
Bug: 578029
Change-Id: I11f682d3bfcfe5f2bd5ec8d27c355635568489d5
---
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.h
M tools/metrics/histograms/histograms.xml
3 files changed, 19 insertions(+), 83 deletions(-)
Takashi Toyoshima (Gerrit)
+Ilya for histograms
Kunihiko Sakamoto (Gerrit)
Patch set 2:Code-Review +1
Ilya Sherman (Gerrit)
LGTM % a nit, thanks!
Patch set 2:Code-Review +1
1 comment:
File tools/metrics/histograms/histograms.xml:
Patch Set #2, Line 105821:
finishes for rolloutsnit: "has finished rolling out" (and ditto above)
To view, visit change 722820. To unsubscribe, or for help writing mail filters, visit settings.
Takashi Toyoshima (Gerrit)
Patch set 3:Commit-Queue +2
Commit Bot (Gerrit)
CQ is trying da patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"better wording" https://chromium-review.googlesource.com/c/722820/3
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/722820/3
Bot data: {"action": "start", "triggered_at": "2017-10-19T06:08:37.0Z", "cq_cfg_revision": "2d3a62b279d3f647091bba3d1ee978f0ca0d8e45", "revision": "761ad188def3234219a4b90c281f1bb146ed40a9"}
Takashi Toyoshima (Gerrit)
+kinuko for WebKit core owner review
Commit Bot (Gerrit)
Try jobs failed on following builders:
chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/568482)
Kinuko Yasuda (Gerrit)
Would we still want to have some minimum histogram to see how frequently this intervention is triggered, so that we can keep knowing how effective (or not) this intervention is, or remove this at some point?
Kunihiko Sakamoto (Gerrit)
Patch Set 3:
Would we still want to have some minimum histogram to see how frequently this intervention is triggered, so that we can keep knowing how effective (or not) this intervention is, or remove this at some point?
We still have WebFont.DownloadTime.* and WebFont.HadBlankText that can be sliced by network connection type in the UMA dashboard. I think we can keep tracking the effectiveness of this intervention with those generic histograms.
Kinuko Yasuda (Gerrit)
Patch Set 3:
Patch Set 3:
Would we still want to have some minimum histogram to see how frequently this intervention is triggered, so that we can keep knowing how effective (or not) this intervention is, or remove this at some point?
We still have WebFont.DownloadTime.* and WebFont.HadBlankText that can be sliced by network connection type in the UMA dashboard. I think we can keep tracking the effectiveness of this intervention with those generic histograms.
Got it. Thanks for the clarification!
Patch set 3:Code-Review +1
Takashi Toyoshima (Gerrit)
Commit Bot (Gerrit)
Commit Bot merged this change.
RemoteFontFaceSource: remove intervention related metrics
Since the feature is already launched and we do not need to monitor
performance impact any more, let's remove intervention related metrics.
Bug: 578029
Change-Id: I11f682d3bfcfe5f2bd5ec8d27c355635568489d5
Reviewed-on: https://chromium-review.googlesource.com/722820
Reviewed-by: Kinuko Yasuda <kin...@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksak...@chromium.org>
Reviewed-by: Ilya Sherman <ishe...@chromium.org>
Commit-Queue: Takashi Toyoshima <toyo...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510058}
---
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.h
M tools/metrics/histograms/histograms.xml
3 files changed, 19 insertions(+), 83 deletions(-)