Get rid of a redundant parameter text_node_ from TextIteratorTextNodeHandler::EmitText() [chromium/src : master]

Yoshifumi Inoue (Gerrit)

unread,

Apr 24, 2018, 2:47:49 AM4/24/18

to Xiaocheng Hu, blink-...@chromium.org

Yoshifumi Inoue would like Xiaocheng Hu and Yoichi Osato to review this change.

Get rid of a redundant parameter text_node_ from TextIteratorTextNodeHandler::EmitText()

This patch gets rid of a redundant parameter |text_node_| from
|TextIteratorTextNodeHandler::EmitText()| since all call sites pass |text_node_|
for improving code health.

Change-Id: I4bd160a5095229322cc6c6fce1f7795b66ec7ac5
---
M third_party/blink/renderer/core/editing/iterators/text_iterator_text_node_handler.cc
M third_party/blink/renderer/core/editing/iterators/text_iterator_text_node_handler.h
2 files changed, 7 insertions(+), 10 deletions(-)

To view, visit change 1025536. To unsubscribe, or for help writing mail filters, visit settings.

Yoshifumi Inoue (Gerrit)

unread,

Apr 24, 2018, 2:47:49 AM4/24/18

to blink-...@chromium.org, Xiaocheng Hu, Commit Bot, chromium...@chromium.org

PTAL

View Change

To view, visit change 1025536. To unsubscribe, or for help writing mail filters, visit settings.

Yoichi Osato (Gerrit)

unread,

Apr 24, 2018, 2:54:37 AM4/24/18

to blink-...@chromium.org, Xiaocheng Hu, Commit Bot, chromium...@chromium.org

Patch set 2:Code-Review +1

View Change

To view, visit change 1025536. To unsubscribe, or for help writing mail filters, visit settings.

Yoshifumi Inoue (Gerrit)

unread,

Apr 24, 2018, 3:34:32 AM4/24/18

to blink-...@chromium.org, Xiaocheng Hu, Commit Bot, chromium...@chromium.org

Patch set 2:Commit-Queue +2

View Change

To view, visit change 1025536. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Apr 24, 2018, 5:03:12 AM4/24/18

to blink-...@chromium.org, Xiaocheng Hu, chromium...@chromium.org

Commit Bot merged this change.

View Change

Approvals:
  Yoichi Osato: Looks good to me
  Yoshifumi Inoue: Commit

Get rid of a redundant parameter text_node_ from TextIteratorTextNodeHandler::EmitText()

This patch gets rid of a redundant parameter |text_node_| from
|TextIteratorTextNodeHandler::EmitText()| since all call sites pass |text_node_|
for improving code health.

Change-Id: I4bd160a5095229322cc6c6fce1f7795b66ec7ac5

Reviewed-on: https://chromium-review.googlesource.com/1025536
Reviewed-by: Yoichi Osato <yoi...@chromium.org>
Commit-Queue: Yoshifumi Inoue <yo...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553039}


---
M third_party/blink/renderer/core/editing/iterators/text_iterator_text_node_handler.cc
M third_party/blink/renderer/core/editing/iterators/text_iterator_text_node_handler.h
2 files changed, 7 insertions(+), 10 deletions(-)

To view, visit change 1025536. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward