Measure how common nested fullscreen scenarios are [chromium/src : master]
Philip Jägenstedt (Gerrit)
Matt Falkenhagen (Gerrit)
2 comments:
File third_party/WebKit/Source/core/fullscreen/Fullscreen.cpp:
Patch Set #2, Line 828:
: WebFeature::kFullscreenMultipleElements);Just to be sure, this doesn't intend to measure top-layer usage by modal <dialog> correct? As that issue points out, some of the complexity about top-layer is for multiple fullscreen elements and/or multiple modal dialogs . I don't believe modal dialogs come to this function (but i haven't been following code changes).
I just want to ensure we understand what the use counter is measuring when making decisions about whether to remove nested support.
File tools/metrics/histograms/enums.xml:
Patch Set #2, Line 17581:
<int value="2231" label="RespondToSameOriginRequestWithCrossOriginResponse"/>Ah, I guess pretty-print removed this? It's fine for this CL, but probably the corresponding type in web_feature.mojom should be commented out instead of just marked (obsolete) in a comment. But it looks like no one else does that...
To view, visit change 891045. To unsubscribe, or for help writing mail filters, visit settings.
Philip Jägenstedt (Gerrit)
Yeah, I think that measuring just this isn't going to get us anywhere. Leaving this open for now, and will update if we reach some conclusion on the issue as to what could be simplified.
Matt Falkenhagen (Gerrit)
removing myself from reviewer to clear my queue. feel free to readd if desired.
Philip Jägenstedt (Gerrit)
Philip Jägenstedt abandoned this change.
To view, visit change 891045. To unsubscribe, or for help writing mail filters, visit settings.