Create CachedMetadataHandler when a response is received [chromium/src : master]

Hiroshige Hayashizaki (Gerrit)

unread,

Dec 12, 2017, 7:49:48 PM12/12/17

to blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Kouhei Ueno, Mythri Alle, Nate Chapin, Leszek Swirski, Ross McIlroy, Tsuyoshi Horo, Commit Bot, chromium...@chromium.org

PTAL,

japhet@ as a platform/loader OWNER,

horo@ who might be familiar with CachedMetadata; this CL assumes that CachedMetadata is received from disk cache, if any, always after ResponseReceived() and before NotifyFinished(), possibly before or after the first DataReceived(). Is this assumption correct?

kouhei@ for scripting,
rmcilroy@ mythria@ leszeks@ FYI, this CL will change the lifetime of CachedMetadataHandler and thus affect V8 code caching statistics.

View Change

To view, visit change 786410. To unsubscribe, or for help writing mail filters, visit settings.

Hiroshige Hayashizaki (Gerrit)

unread,

Dec 12, 2017, 7:50:27 PM12/12/17

to blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Yutaka Hirano, Kouhei Ueno, Mythri Alle, Nate Chapin, Leszek Swirski, Ross McIlroy, Tsuyoshi Horo, Commit Bot, chromium...@chromium.org

+yhirano@ also as a loading OWNER.

View Change

To view, visit change 786410. To unsubscribe, or for help writing mail filters, visit settings.

Hiroshige Hayashizaki (Gerrit)

unread,

Dec 12, 2017, 7:50:27 PM12/12/17

to Yutaka Hirano, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Kouhei Ueno, Mythri Alle, Nate Chapin, Leszek Swirski, Ross McIlroy, Tsuyoshi Horo

Hiroshige Hayashizaki would like Yutaka Hirano to review this change.

View Change

Create CachedMetadataHandler when a response is received

This CL creates CachedMetadataHandler when a response is received,
instead of creating when a Resource is constructed.

This is to
- Prepare for removing the reference from CachedMetadataHandler to
  Resource in [1]. The data needed for CachedMetadataHandler is
  available when a response is received, but not available when
  the Resource is created. Also, this CL makes the lifetime of
  CachedMetadataHandler match with the period where the corresponding
  ResourceResponse is set in Resource::response_.
- Enable CachedMetadataHandler even after revalidation.
  Previously, CachedMetadataHandler was cleared on failed revalidation
  and was never re-created after that.
  This CL creates a new CachedMetadataHandler everytime a
  ResourceResponse is received, and thus re-creates a
  CachedMetadataHandler on failed revalidation.

Bug: 784875
Change-Id: Ia32f5772cbd5970734f67098f235c2a1428b46ea
---
M third_party/WebKit/Source/platform/loader/fetch/Resource.cpp
M third_party/WebKit/Source/platform/loader/fetch/ResourceTest.cpp
2 files changed, 8 insertions(+), 10 deletions(-)

To view, visit change 786410. To unsubscribe, or for help writing mail filters, visit settings.

Kouhei Ueno (Gerrit)

unread,

Dec 13, 2017, 12:21:16 AM12/13/17

to Hiroshige Hayashizaki, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Yutaka Hirano, Mythri Alle, Nate Chapin, Leszek Swirski, Ross McIlroy, Tsuyoshi Horo, Commit Bot, chromium...@chromium.org

Patch set 8:Code-Review +1

View Change

To view, visit change 786410. To unsubscribe, or for help writing mail filters, visit settings.

Nate Chapin (Gerrit)

unread,

Dec 13, 2017, 1:41:13 PM12/13/17

to Hiroshige Hayashizaki, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Kouhei Ueno, Yutaka Hirano, Mythri Alle, Leszek Swirski, Ross McIlroy, Tsuyoshi Horo, Commit Bot, chromium...@chromium.org

Patch set 8:Code-Review +1

View Change

To view, visit change 786410. To unsubscribe, or for help writing mail filters, visit settings.

Yutaka Hirano (Gerrit)

unread,

Dec 13, 2017, 6:36:23 PM12/13/17

to Hiroshige Hayashizaki, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Yutaka Hirano, Nate Chapin, Kouhei Ueno, Mythri Alle, Leszek Swirski, Ross McIlroy, Tsuyoshi Horo, Commit Bot, chromium...@chromium.org

Patch set 9:Code-Review +1

View Change

To view, visit change 786410. To unsubscribe, or for help writing mail filters, visit settings.

Tsuyoshi Horo (Gerrit)

unread,

Dec 14, 2017, 8:20:00 PM12/14/17

to Hiroshige Hayashizaki, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Yutaka Hirano, Nate Chapin, Kouhei Ueno, Mythri Alle, Leszek Swirski, Ross McIlroy, Commit Bot, chromium...@chromium.org

Patch set 10:Code-Review +1

View Change

To view, visit change 786410. To unsubscribe, or for help writing mail filters, visit settings.

Hiroshige Hayashizaki (Gerrit)

unread,

Dec 15, 2017, 6:34:36 PM12/15/17

to blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Tsuyoshi Horo, Yutaka Hirano, Nate Chapin, Kouhei Ueno, Mythri Alle, Leszek Swirski, Ross McIlroy, Commit Bot, chromium...@chromium.org

Patch set 10:Commit-Queue +2

View Change

To view, visit change 786410. To unsubscribe, or for help writing mail filters, visit settings.

Hiroshige Hayashizaki (Gerrit)

unread,

Dec 15, 2017, 6:35:27 PM12/15/17

to Yutaka Hirano, Tsuyoshi Horo, Mythri Alle, Ross McIlroy, Nate Chapin, Kouhei Ueno, Leszek Swirski, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, chromium...@chromium.org, Commit Bot

Hiroshige Hayashizaki uploaded patch set #11 to this change.

View Change

Create CachedMetadataHandler when a response is received

This CL creates CachedMetadataHandler when a response is received,
instead of creating when a Resource is constructed.

This is to
- Prepare for removing the reference from CachedMetadataHandler to
  Resource in [1]. The data needed for CachedMetadataHandler is
  available when a response is received, but not available when
  the Resource is created. Also, this CL makes the lifetime of
  CachedMetadataHandler match with the period where the corresponding
  ResourceResponse is set in Resource::response_.
- Enable CachedMetadataHandler even after revalidation.
  Previously, CachedMetadataHandler was cleared on failed revalidation
  and was never re-created after that.
  This CL creates a new CachedMetadataHandler everytime a
  ResourceResponse is received, and thus re-creates a
  CachedMetadataHandler on failed revalidation.

[1] https://chromium-review.googlesource.com/791494



Bug: 784875
Change-Id: Ia32f5772cbd5970734f67098f235c2a1428b46ea
---
M third_party/WebKit/Source/platform/loader/fetch/Resource.cpp
M third_party/WebKit/Source/platform/loader/fetch/ResourceTest.cpp
2 files changed, 8 insertions(+), 10 deletions(-)

To view, visit change 786410. To unsubscribe, or for help writing mail filters, visit settings.

Hiroshige Hayashizaki (Gerrit)

unread,

Dec 15, 2017, 6:36:06 PM12/15/17

to blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Tsuyoshi Horo, Yutaka Hirano, Nate Chapin, Kouhei Ueno, Mythri Alle, Leszek Swirski, Ross McIlroy, Commit Bot, chromium...@chromium.org

Patch set 11:Commit-Queue +2

View Change

To view, visit change 786410. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Dec 15, 2017, 6:36:20 PM12/15/17

to Hiroshige Hayashizaki, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Tsuyoshi Horo, Yutaka Hirano, Nate Chapin, Kouhei Ueno, Mythri Alle, Leszek Swirski, Ross McIlroy, chromium...@chromium.org

CQ is trying the patch.

Note: The patchset sent to CQ was uploaded after this CL was approved.
"Edit commit message" https://chromium-review.googlesource.com/c/786410/11

Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/786410/11

Bot data: {"action": "start", "triggered_at": "2017-12-15T23:36:05.0Z", "cq_cfg_revision": "b547f51ef97353cccb06eebcda71133909f61295", "revision": "ed2d90d9406bfc721ec74a8afbcaabca61aa8371"}

View Change

To view, visit change 786410. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Dec 15, 2017, 7:57:49 PM12/15/17

to Hiroshige Hayashizaki, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, Tsuyoshi Horo, Yutaka Hirano, Nate Chapin, Kouhei Ueno, Mythri Alle, Leszek Swirski, Ross McIlroy, chromium...@chromium.org

Commit Bot merged this change.

View Change

Approvals:
  Tsuyoshi Horo: Looks good to me
  Yutaka Hirano: Looks good to me
  Nate Chapin: Looks good to me
  Kouhei Ueno: Looks good to me
  Hiroshige Hayashizaki: Commit

Create CachedMetadataHandler when a response is received

This CL creates CachedMetadataHandler when a response is received,
instead of creating when a Resource is constructed.

This is to
- Prepare for removing the reference from CachedMetadataHandler to
  Resource in [1]. The data needed for CachedMetadataHandler is
  available when a response is received, but not available when
  the Resource is created. Also, this CL makes the lifetime of
  CachedMetadataHandler match with the period where the corresponding
  ResourceResponse is set in Resource::response_.
- Enable CachedMetadataHandler even after revalidation.
  Previously, CachedMetadataHandler was cleared on failed revalidation
  and was never re-created after that.
  This CL creates a new CachedMetadataHandler everytime a
  ResourceResponse is received, and thus re-creates a
  CachedMetadataHandler on failed revalidation.

[1] https://chromium-review.googlesource.com/791494

Bug: 784875
Change-Id: Ia32f5772cbd5970734f67098f235c2a1428b46ea

Reviewed-on: https://chromium-review.googlesource.com/786410
Commit-Queue: Hiroshige Hayashizaki <hiro...@chromium.org>
Reviewed-by: Tsuyoshi Horo <ho...@chromium.org>
Reviewed-by: Yutaka Hirano <yhi...@chromium.org>
Reviewed-by: Kouhei Ueno <kou...@chromium.org>
Reviewed-by: Nate Chapin <jap...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524540}


---
M third_party/WebKit/Source/platform/loader/fetch/Resource.cpp
M third_party/WebKit/Source/platform/loader/fetch/ResourceTest.cpp
2 files changed, 8 insertions(+), 10 deletions(-)

To view, visit change 786410. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward