[PE] Apply overflow clip to scrolling contents layers' interest rect bounds when mapping to root. [chromium/src : master]

Chris Harrelson (Gerrit)

unread,

Mar 17, 2018, 11:15:25 PM3/17/18

to blink-rev...@chromium.org, blink-...@chromium.org, vmpstr, Commit Bot, chromium...@chromium.org, Dongseong Hwang

This change is ready for review.

View Change

To view, visit change 967870. To unsubscribe, or for help writing mail filters, visit settings.

vmpstr (Gerrit)

unread,

Mar 19, 2018, 2:31:45 PM3/19/18

to Chris Harrelson, blink-rev...@chromium.org, blink-...@chromium.org, Commit Bot, chromium...@chromium.org, Dongseong Hwang

Patch set 4:Code-Review +1

View Change

To view, visit change 967870. To unsubscribe, or for help writing mail filters, visit settings.

Chris Harrelson (Gerrit)

unread,

Mar 19, 2018, 2:32:51 PM3/19/18

to blink-rev...@chromium.org, blink-...@chromium.org, vmpstr, Commit Bot, chromium...@chromium.org, Dongseong Hwang

Patch set 4:Commit-Queue +2

View Change

To view, visit change 967870. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Mar 19, 2018, 4:14:55 PM3/19/18

to Chris Harrelson, blink-rev...@chromium.org, blink-...@chromium.org, vmpstr, chromium...@chromium.org, Dongseong Hwang

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/674712)

View Change

To view, visit change 967870. To unsubscribe, or for help writing mail filters, visit settings.

Chris Harrelson (Gerrit)

unread,

Mar 20, 2018, 6:59:13 PM3/20/18

to blink-rev...@chromium.org, blink-...@chromium.org, vmpstr, Commit Bot, chromium...@chromium.org, Dongseong Hwang

Patch set 4:Commit-Queue +2

View Change

To view, visit change 967870. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Mar 20, 2018, 8:46:14 PM3/20/18

to Chris Harrelson, blink-rev...@chromium.org, blink-...@chromium.org, vmpstr, chromium...@chromium.org, Dongseong Hwang

Try jobs failed on following builders:

  win10_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win10_chromium_x64_rel_ng/builds/104988)

View Change

To view, visit change 967870. To unsubscribe, or for help writing mail filters, visit settings.

Chris Harrelson (Gerrit)

unread,

Mar 20, 2018, 10:57:28 PM3/20/18

to blink-rev...@chromium.org, blink-...@chromium.org, vmpstr, Commit Bot, chromium...@chromium.org, Dongseong Hwang

Patch set 5:Commit-Queue +2

View Change

To view, visit change 967870. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Mar 20, 2018, 10:57:38 PM3/20/18

to Chris Harrelson, blink-rev...@chromium.org, blink-...@chromium.org, vmpstr, chromium...@chromium.org, Dongseong Hwang

CQ is trying the patch.

Note: The patchset sent to CQ was uploaded after this CL was approved.
"none" https://chromium-review.googlesource.com/c/967870/5

Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/967870/5

Bot data: {"action": "start", "triggered_at": "2018-03-21T02:57:27.0Z", "cq_cfg_revision": "5b6c43e4d6b0297aa92e118e785d640c42297271", "revision": "9206ea68008f1637c80fd96d95465cac2924315a"}

View Change

To view, visit change 967870. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Mar 21, 2018, 12:43:30 AM3/21/18

to Chris Harrelson, blink-rev...@chromium.org, blink-...@chromium.org, vmpstr, chromium...@chromium.org, Dongseong Hwang

Commit Bot merged this change.

View Change

Approvals:
  vmpstr: Looks good to me
  Chris Harrelson: Commit

[PE] Apply overflow clip to scrolling contents layers' interest rect bounds when mapping to root.

Currently, the overflow clip of these layers is not applied. This can lead to an overly large
interest rect, in case when the overflow clip is significantly smaller than the clip of the
root frame.

This CL also makes regular box scrollers have the same behavior as composited LayoutViews.
The latter receive the clip due to special logic in
LayoutView::MapToVisualRectInAncestorSpaceInternal that intersects with the ViewRect.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1a585d0a69e2dbd82ecc515ea0782fea6f651d4b
Reviewed-on: https://chromium-review.googlesource.com/967870
Commit-Queue: Chris Harrelson <chri...@chromium.org>
Reviewed-by: vmpstr <vmp...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544637}
---
M third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp
M third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.h
M third_party/WebKit/Source/core/paint/compositing/CompositedLayerMappingTest.cpp
3 files changed, 43 insertions(+), 23 deletions(-)

To view, visit change 967870. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward