Move test for navigator.deviceMemory to its own dir with OWNERS [chromium/src : master]
Philip Jägenstedt (Gerrit)
PTAL, in particular to see if I got the TEAM and COMPONENT right.
And thanks for upstreaming your tests to wpt :)
To view, visit change 876423. To unsubscribe, or for help writing mail filters, visit settings.
Blink WPT Bot (Gerrit)
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/w3c/web-platform-tests/pull/9107.
If this CL lands and Travis CI upstream is green, we will auto-merge the PR.
Note: Please check the Travis CI status (at the bottom of the PR) before landing this CL and only land this CL if the status is green. Otherwise a human needs to step in and resolve it manually. (This may be automated in the future, see https://crbug.com/711447)
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md#Automatic-export-process
Fadi Meawad (Gerrit)
Patch set 1:Code-Review +1
1 comment:
File third_party/WebKit/LayoutTests/external/wpt/device-memory/OWNERS:
Patch Set #1, Line 1:
progressive-web-metricsI don't think this is the right team, or maybe it is.
panicker@ WDYT?
To view, visit change 876423. To unsubscribe, or for help writing mail filters, visit settings.
Shubhie Panicker (Gerrit)
Shubhie Panicker would like Timothy Dresser to review this change.
Move test for navigator.deviceMemory to its own dir with OWNERS
Directory name matching https://w3c.github.io/device-memory/.
Change-Id: If32f07b659aca91a63fd17ca80de4afb1cd525c2
---
A third_party/WebKit/LayoutTests/external/wpt/device-memory/OWNERS
R third_party/WebKit/LayoutTests/external/wpt/device-memory/device-memory.https.any.js
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/third_party/WebKit/LayoutTests/external/wpt/device-memory/OWNERS b/third_party/WebKit/LayoutTests/external/wpt/device-memory/OWNERS
new file mode 100644
index 0000000..d7c51dc
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/external/wpt/device-memory/OWNERS
@@ -0,0 +1,4 @@
+# TEAM: progressive...@chromium.org
+# COMPONENT: Blink>PerformanceAPIs
+fme...@chromium.org
+pani...@chromium.org
\ No newline at end of file
diff --git a/third_party/WebKit/LayoutTests/external/wpt/navigator/device-memory.https.any.js b/third_party/WebKit/LayoutTests/external/wpt/device-memory/device-memory.https.any.js
similarity index 100%
rename from third_party/WebKit/LayoutTests/external/wpt/navigator/device-memory.https.any.js
rename to third_party/WebKit/LayoutTests/external/wpt/device-memory/device-memory.https.any.js
To view, visit change 876423. To unsubscribe, or for help writing mail filters, visit settings.
Shubhie Panicker (Gerrit)
Patch Set #1, Line 1:
progressive-web-metrics
I don't think this is the right team, or maybe it is. […]
we haven't asked them about owning device memory, but it would be a natural fit.
Tim?
To view, visit change 876423. To unsubscribe, or for help writing mail filters, visit settings.
Timothy Dresser (Gerrit)
1 comment:
Patch Set #1, Line 1:
progressive-web-metrics
we haven't asked them about owning device memory, but it would be a natural fit. […]
Yeah, this is reasonable.
To view, visit change 876423. To unsubscribe, or for help writing mail filters, visit settings.
Philip Jägenstedt (Gerrit)
Patch set 1:Commit-Queue +2
1 comment:
Patch Set #1, Line 1:
progressive-web-metrics
Yeah, this is reasonable.
Thanks, sending to CQ!
To view, visit change 876423. To unsubscribe, or for help writing mail filters, visit settings.
Commit Bot (Gerrit)
Commit Bot merged this change.
Move test for navigator.deviceMemory to its own dir with OWNERS
Directory name matching https://w3c.github.io/device-memory/.
Change-Id: If32f07b659aca91a63fd17ca80de4afb1cd525c2
Reviewed-on: https://chromium-review.googlesource.com/876423
Reviewed-by: Fadi Meawad <fme...@chromium.org>
Reviewed-by: Shubhie Panicker <pani...@chromium.org>
Commit-Queue: Philip Jägenstedt <foo...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530859}
---
A third_party/WebKit/LayoutTests/external/wpt/device-memory/OWNERS
R third_party/WebKit/LayoutTests/external/wpt/device-memory/device-memory.https.any.js
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/third_party/WebKit/LayoutTests/external/wpt/device-memory/OWNERS b/third_party/WebKit/LayoutTests/external/wpt/device-memory/OWNERS
new file mode 100644
index 0000000..d7c51dc
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/external/wpt/device-memory/OWNERS
@@ -0,0 +1,4 @@
+# TEAM: progressive...@chromium.org
+# COMPONENT: Blink>PerformanceAPIs
+fme...@chromium.org
+pani...@chromium.org
\ No newline at end of file
diff --git a/third_party/WebKit/LayoutTests/external/wpt/navigator/device-memory.https.any.js b/third_party/WebKit/LayoutTests/external/wpt/device-memory/device-memory.https.any.js
similarity index 100%
rename from third_party/WebKit/LayoutTests/external/wpt/navigator/device-memory.https.any.js
rename to third_party/WebKit/LayoutTests/external/wpt/device-memory/device-memory.https.any.js
To view, visit change 876423. To unsubscribe, or for help writing mail filters, visit settings.
Blink WPT Bot (Gerrit)
The WPT PR for this CL has been merged upstream! https://github.com/w3c/web-platform-tests/pull/9107