[css-grid] Implementing stretch alignment in orthogonal flows (issue 2176533002 by jfernandez@igalia.com)

[jfern...@igalia.com]

Reviewers: cbiesinger, svillar, Manuel Rego
CL: https://codereview.chromium.org/2176533002/

Message:
Patch ready for review.

Description:
[css-grid] Implementing stretch alignment in orthogonal flows

After implementing orthogonal flow support for track sizing and basic
alignment logic, we can now implement stretching logic in orthogonal
scenarios, which was not allowed so far.

Thanks to the recent changes which made the grid layout code more
independent to the grid container's and its children's flow the
implementation of the stretching logic can be done in a clearer way.

This patch implements the missing logic and performs some refactoring
so it became flow direction independent.

BUG=556171, 445742, 376823

Base URL: https://chromium.googlesource.com/chromium/src.git@master

Affected files (+136, -14 lines):
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-justify-stretch-with-orthogonal-flows.html
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp

[cbies...@chromium.org]

lgtm

https://codereview.chromium.org/2176533002/

[cbies...@chromium.org]

https://codereview.chromium.org/2176533002/diff/1/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
File third_party/WebKit/Source/core/layout/LayoutGrid.cpp (right):

https://codereview.chromium.org/2176533002/diff/1/third_party/WebKit/Source/core/layout/LayoutGrid.cpp#newcode2202
third_party/WebKit/Source/core/layout/LayoutGrid.cpp:2202: bool
stretchingAlognColumnAxis = ComputedStyle::resolveAlignment(styleRef(),
childStyle, ItemPositionStretch) == ItemPositionStretch;
Alogn -> Along

https://codereview.chromium.org/2176533002/

[commit-bot@chromium.org via codereview.chromium.org]

CQ is trying da patch. Follow status at

https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176533002/20001


https://codereview.chromium.org/2176533002/

[commit-bot@chromium.org via codereview.chromium.org]

Committed patchset #2 (id:20001)

https://codereview.chromium.org/2176533002/

[commit-bot@chromium.org via codereview.chromium.org]

Patchset 2 (id:??) landed as
https://crrev.com/e316fd483b282a644bf7d9d05c43399bcf46c6fb
Cr-Commit-Position: refs/heads/master@{#407779}

https://codereview.chromium.org/2176533002/