make_names: Qualify #include for the primary header, and fix header guard. [chromium/src : master]
0 views
Skip to first unread message
Kent Tamura (Gerrit)
Apr 24, 2018, 4:21:06 AM4/24/18
to Hitoshi Yoshida, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, feature-me...@chromium.org, iclella...@chromium.org, Kent Tamura
Kent Tamura would like Hitoshi Yoshida to review this change.
make_names: Qualify #include for the primary header, and fix header guard.
The main change of this CL is that MakeNamesWriter.__init__() sets
a qualified header path and a correct include guard to
_template_context.
In order to do it,
- json5_generator.Writer.__init__() takes output_dir argument, and
stores a directory name relative to "gen/".
- Introduce json5_generator.Writer.make_header_guard().
Bug: 836071
Change-Id: I75a8ce8849071cb5a32e19f4304dc070937a8554
---
M third_party/blink/renderer/build/scripts/core/css/make_css_value_keywords.py
M third_party/blink/renderer/build/scripts/core/css/make_cssom_types.py
M third_party/blink/renderer/build/scripts/core/css/make_media_features.py
M third_party/blink/renderer/build/scripts/core/css/make_style_shorthands.py
M third_party/blink/renderer/build/scripts/core/css/parser/make_atrule_names.py
M third_party/blink/renderer/build/scripts/core/css/properties/make_css_property_base.py
M third_party/blink/renderer/build/scripts/core/css/properties/make_css_property_subclasses.py
M third_party/blink/renderer/build/scripts/core/style/make_computed_style_initial_values.py
M third_party/blink/renderer/build/scripts/json5_generator.py
M third_party/blink/renderer/build/scripts/make_computed_style_base.py
M third_party/blink/renderer/build/scripts/make_css_primitive_value_unit_trie.py
M third_party/blink/renderer/build/scripts/make_css_property_names.py
M third_party/blink/renderer/build/scripts/make_css_value_id_mappings.py
M third_party/blink/renderer/build/scripts/make_element_factory.py
M third_party/blink/renderer/build/scripts/make_element_lookup_trie.py
M third_party/blink/renderer/build/scripts/make_element_type_helpers.py
M third_party/blink/renderer/build/scripts/make_event_factory.py
M third_party/blink/renderer/build/scripts/make_internal_runtime_flags.py
M third_party/blink/renderer/build/scripts/make_internal_settings.py
M third_party/blink/renderer/build/scripts/make_names.py
M third_party/blink/renderer/build/scripts/make_origin_trials.py
M third_party/blink/renderer/build/scripts/make_qualified_names.py
M third_party/blink/renderer/build/scripts/make_runtime_features.py
M third_party/blink/renderer/build/scripts/make_settings.py
M third_party/blink/renderer/build/scripts/make_style_builder.py
M third_party/blink/renderer/build/scripts/templates/make_names.cc.tmpl
M third_party/blink/renderer/build/scripts/templates/make_names.h.tmpl
27 files changed, 67 insertions(+), 57 deletions(-)
To view, visit change 1025351. To unsubscribe, or for help writing mail filters, visit settings.
Kent Tamura (Gerrit)
Apr 24, 2018, 4:21:07 AM4/24/18
to Kent Tamura, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, feature-me...@chromium.org, iclella...@chromium.org, Hitoshi Yoshida, Commit Bot, chromium...@chromium.org
peria@, would you review this please?
No hurry.
Hitoshi Yoshida (Gerrit)
Apr 27, 2018, 2:01:09 AM4/27/18
to Kent Tamura, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, feature-me...@chromium.org, iclella...@chromium.org, Commit Bot, chromium...@chromium.org
lgtm.
Patch set 3:Code-Review +1
2 comments:
To view, visit change 1025351. To unsubscribe, or for help writing mail filters, visit settings.
Kent Tamura (Gerrit)
Apr 27, 2018, 2:14:40 AM4/27/18
to Kent Tamura, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, feature-me...@chromium.org, iclella...@chromium.org, Hitoshi Yoshida, Commit Bot, chromium...@chromium.org
2 comments:
2 spaces
Done
2 spaces
Done
To view, visit change 1025351. To unsubscribe, or for help writing mail filters, visit settings.
Kent Tamura (Gerrit)
Apr 27, 2018, 3:49:09 AM4/27/18
to Kent Tamura, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, feature-me...@chromium.org, iclella...@chromium.org, Hitoshi Yoshida, Commit Bot, chromium...@chromium.org
Patch set 4:Commit-Queue +2
Commit Bot (Gerrit)
Apr 27, 2018, 3:49:21 AM4/27/18
to Kent Tamura, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, feature-me...@chromium.org, iclella...@chromium.org, Hitoshi Yoshida, chromium...@chromium.org
CQ is trying the patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"two spaces before comments" https://chromium-review.googlesource.com/c/1025351/4
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/1025351/4
Bot data: {"action": "start", "triggered_at": "2018-04-27T07:49:06.0Z", "cq_cfg_revision": "ec7cec62c0feefff61026ab368fbea1f7be53e60", "revision": "70a446ba3461c10f24e0ce43b9f598ff691af9eb"}
Commit Bot (Gerrit)
Apr 27, 2018, 3:51:23 AM4/27/18
to Kent Tamura, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, feature-me...@chromium.org, iclella...@chromium.org, Hitoshi Yoshida, chromium...@chromium.org
Commit Bot merged this change.
Approvals:
Hitoshi Yoshida: Looks good to me
Kent Tamura: Commit
make_names: Qualify #include for the primary header, and fix header guard.
The main change of this CL is that MakeNamesWriter.__init__() sets
a qualified header path and a correct include guard to
_template_context.
In order to do it,
- json5_generator.Writer.__init__() takes output_dir argument, and
stores a directory name relative to "gen/".
- Introduce json5_generator.Writer.make_header_guard().
Bug: 836071
Change-Id: I75a8ce8849071cb5a32e19f4304dc070937a8554
Reviewed-on: https://chromium-review.googlesource.com/1025351
Commit-Queue: Kent Tamura <tk...@chromium.org>
Reviewed-by: Hitoshi Yoshida <pe...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554336}
27 files changed, 69 insertions(+), 59 deletions(-)
Reply all
Reply to author
Forward
0 new messages