Remove lingering -webkit-svg-shadow tests (issue 1387823003 by fs@opera.com)

0 views
Skip to first unread message

f...@opera.com

unread,
Oct 5, 2015, 8:39:21 AM10/5/15
to sche...@chromium.org, p...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
Reviewers: Stephen Chenney, pdr,

Description:
Remove lingering -webkit-svg-shadow tests

-webkit-svg-shadow support was removed in r154982 (tracked in issue
262857), but leaving these three tests behind (two of which would
trivially pass because they were ref tests.)

BUG=262857,223332

Please review this at https://codereview.chromium.org/1387823003/

Base URL: https://chromium.googlesource.com/chromium/src.git@master

Affected files (+-2, -39 lines):
D
third_party/WebKit/LayoutTests/platform/mac/svg/filters/shadow-on-filter-expected.png
D
third_party/WebKit/LayoutTests/platform/win/svg/filters/shadow-on-filter-expected.png
D third_party/WebKit/LayoutTests/svg/css/parent-shadow-offscreen.svg
D
third_party/WebKit/LayoutTests/svg/css/parent-shadow-offscreen-expected.svg
D third_party/WebKit/LayoutTests/svg/css/root-shadow-offscreen.svg
D
third_party/WebKit/LayoutTests/svg/css/root-shadow-offscreen-expected.svg
D third_party/WebKit/LayoutTests/svg/filters/shadow-on-filter.svg
D third_party/WebKit/LayoutTests/svg/filters/shadow-on-filter-expected.txt


Index:
third_party/WebKit/LayoutTests/platform/mac/svg/filters/shadow-on-filter-expected.png
diff --git
a/third_party/WebKit/LayoutTests/platform/mac/svg/filters/shadow-on-filter-expected.png
b/third_party/WebKit/LayoutTests/platform/mac/svg/filters/shadow-on-filter-expected.png
deleted file mode 100644
index
9aeec142137396dd9e17985dc601ce52d878364f..0000000000000000000000000000000000000000
Binary files
a/third_party/WebKit/LayoutTests/platform/mac/svg/filters/shadow-on-filter-expected.png
and /dev/null differ
Index:
third_party/WebKit/LayoutTests/platform/win/svg/filters/shadow-on-filter-expected.png
diff --git
a/third_party/WebKit/LayoutTests/platform/win/svg/filters/shadow-on-filter-expected.png
b/third_party/WebKit/LayoutTests/platform/win/svg/filters/shadow-on-filter-expected.png
deleted file mode 100644
index
fc368254d2ed95f67d361171098a7d4ac8e83dcc..0000000000000000000000000000000000000000
Binary files
a/third_party/WebKit/LayoutTests/platform/win/svg/filters/shadow-on-filter-expected.png
and /dev/null differ
Index:
third_party/WebKit/LayoutTests/svg/css/parent-shadow-offscreen-expected.svg
diff --git
a/third_party/WebKit/LayoutTests/svg/css/parent-shadow-offscreen-expected.svg
b/third_party/WebKit/LayoutTests/svg/css/parent-shadow-offscreen-expected.svg
deleted file mode 100644
index
b75d3a0b4d530b57e4b936fee7bfb53ef39a2080..0000000000000000000000000000000000000000
---
a/third_party/WebKit/LayoutTests/svg/css/parent-shadow-offscreen-expected.svg
+++ /dev/null
@@ -1,4 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg">
-<title>Expected results for parent-shadow-offscreen.svg</title>
-<rect id="rect" fill="white" style="-webkit-svg-shadow: #000 100px 100px
5px" x="0" y="0" width="75" height="75"></rect>
-</svg>
Index: third_party/WebKit/LayoutTests/svg/css/parent-shadow-offscreen.svg
diff --git
a/third_party/WebKit/LayoutTests/svg/css/parent-shadow-offscreen.svg
b/third_party/WebKit/LayoutTests/svg/css/parent-shadow-offscreen.svg
deleted file mode 100644
index
b7b7b1a92db3eeeb46104a7d2f2a92d2573dc361..0000000000000000000000000000000000000000
--- a/third_party/WebKit/LayoutTests/svg/css/parent-shadow-offscreen.svg
+++ /dev/null
@@ -1,6 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg">
-<title>Test passes if the shadow is drawn.</title>
-<g style="-webkit-svg-shadow: #000 200px 200px 5px">
-<rect id="rect" x="-100" y="-100" width="75" height="75"></rect>
-</g>
-</svg>
Index:
third_party/WebKit/LayoutTests/svg/css/root-shadow-offscreen-expected.svg
diff --git
a/third_party/WebKit/LayoutTests/svg/css/root-shadow-offscreen-expected.svg
b/third_party/WebKit/LayoutTests/svg/css/root-shadow-offscreen-expected.svg
deleted file mode 100644
index
b364f15d71fd98c8da26adab1f724aa42bd1017a..0000000000000000000000000000000000000000
---
a/third_party/WebKit/LayoutTests/svg/css/root-shadow-offscreen-expected.svg
+++ /dev/null
@@ -1,4 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg">
-<title>Expected results for root-shadow-offscreen.svg</title>
-<rect id="rect" fill="white" style="-webkit-svg-shadow: #000 100px 100px
5px" x="0" y="0" width="75" height="75"></rect>
-</svg>
Index: third_party/WebKit/LayoutTests/svg/css/root-shadow-offscreen.svg
diff --git
a/third_party/WebKit/LayoutTests/svg/css/root-shadow-offscreen.svg
b/third_party/WebKit/LayoutTests/svg/css/root-shadow-offscreen.svg
deleted file mode 100644
index
fed1b124185c70f4d82a6cddd3adce856fb2b771..0000000000000000000000000000000000000000
--- a/third_party/WebKit/LayoutTests/svg/css/root-shadow-offscreen.svg
+++ /dev/null
@@ -1,4 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg" style="-webkit-svg-shadow: #000
200px 200px 5px">
-<title>Test passes if the shadow is drawn.</title>
-<rect id="rect" x="-100" y="-100" width="75" height="75"></rect>
-</svg>
Index:
third_party/WebKit/LayoutTests/svg/filters/shadow-on-filter-expected.txt
diff --git
a/third_party/WebKit/LayoutTests/svg/filters/shadow-on-filter-expected.txt
b/third_party/WebKit/LayoutTests/svg/filters/shadow-on-filter-expected.txt
deleted file mode 100644
index
7ac4b9bffa57a164c91bd18d349897a883b4c777..0000000000000000000000000000000000000000
---
a/third_party/WebKit/LayoutTests/svg/filters/shadow-on-filter-expected.txt
+++ /dev/null
@@ -1,12 +0,0 @@
-layer at (0,0) size 800x600
- LayoutView at (0,0) size 800x600
-layer at (0,0) size 800x600
- LayoutSVGRoot {svg} at (50,50) size 480x480
- LayoutSVGHiddenContainer {defs} at (0,0) size 0x0
- LayoutSVGResourceFilter {filter} [id="filter"]
[filterUnits=objectBoundingBox] [primitiveUnits=objectBoundingBox]
- [feGaussianBlur stdDeviation="0.01, 0.01"]
- [feComposite operation="OVER"]
- [feFlood flood-color="#FF0000" flood-opacity="1.00"]
- [feFlood flood-color="#008000" flood-opacity="1.00"]
- LayoutSVGRect {rect} at (50,50) size 480x480 [fill={[type=SOLID]
[color=#008000]}] [x=200.00] [y=200.00] [width=300.00] [height=300.00]
- [filter="filter"] LayoutSVGResourceFilter {filter} at (50,50) size
480x480
Index: third_party/WebKit/LayoutTests/svg/filters/shadow-on-filter.svg
diff --git
a/third_party/WebKit/LayoutTests/svg/filters/shadow-on-filter.svg
b/third_party/WebKit/LayoutTests/svg/filters/shadow-on-filter.svg
deleted file mode 100644
index
ae82fddba446f240db6ff31ced959e186f9f61b9..0000000000000000000000000000000000000000
--- a/third_party/WebKit/LayoutTests/svg/filters/shadow-on-filter.svg
+++ /dev/null
@@ -1,11 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg">
-<defs>
-<filter primitiveUnits="objectBoundingBox" id="filter" x="-50%" y="-50%"
width="160%" height="160%" style="-webkit-svg-shadow:10px 10px 3px purple;">
-<feFlood x="-40%" y="-40%" width="50%" height="50%" flood-color="red"
style="-webkit-svg-shadow:-4px -4px 0px blue;" result="flood1"/>
-<feFlood x="-20%" y="-20%" width="50%" height="50%" flood-color="green"
result="flood2"/>
-<feComposite in="flood1" in2="flood2" width="120%" height="120%"
result="comp1" style="-webkit-svg-shadow:4px -1px 3px green;"/>
-<feGaussianBlur stdDeviation="0.0133" style="-webkit-svg-shadow: 6px 4px
8px yellow;"/>
-</filter>
-</defs>
-<rect x="200" y="200" width="300" height="300" fill="green"
style="filter:url(#filter);"/>
-</svg>


sche...@chromium.org

unread,
Oct 5, 2015, 11:36:07 AM10/5/15
to f...@opera.com, p...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
lgtm



https://codereview.chromium.org/1387823003/

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 5, 2015, 11:36:42 AM10/5/15
to f...@opera.com, sche...@chromium.org, p...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1387823003/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1387823003/1


https://codereview.chromium.org/1387823003/

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 5, 2015, 11:45:49 AM10/5/15
to f...@opera.com, sche...@chromium.org, p...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
Try jobs failed on following builders:
linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/78148)

https://codereview.chromium.org/1387823003/

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 5, 2015, 12:23:30 PM10/5/15
to f...@opera.com, sche...@chromium.org, p...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 5, 2015, 12:30:40 PM10/5/15
to f...@opera.com, sche...@chromium.org, p...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
Committed patchset #1 (id:1)

https://codereview.chromium.org/1387823003/

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 5, 2015, 12:31:36 PM10/5/15
to f...@opera.com, sche...@chromium.org, p...@chromium.org, commi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org
Patchset 1 (id:??) landed as
https://crrev.com/88e7842501ac875ace9c5cbf3975a94bd8b4e90c
Cr-Commit-Position: refs/heads/master@{#352332}

https://codereview.chromium.org/1387823003/
Reply all
Reply to author
Forward
0 new messages