Timeline: avoid 'Failed to find browser main thread' for an empty tracing model (issue 2379033005 by caseq@chromium.org)

0 views
Skip to first unread message

ca...@chromium.org

unread,
Sep 30, 2016, 9:53:53 PM9/30/16
to al...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, pfel...@chromium.org, kozyatins...@chromium.org
Reviewers: alph
CL: https://codereview.chromium.org/2379033005/

Description:
Timeline: avoid 'Failed to find browser main thread' for an empty tracing model

Affected files (+3, -0 lines):
M third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js


Index: third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js
index a5e281dc61eaa6c7422a155e730b0ef7e5ef7a9c..c854c6e2319ee1d9fd15e379cdbec5dbba38fecb 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js
@@ -127,6 +127,9 @@ WebInspector.TracingModel._extractId = function(payload)
WebInspector.TracingModel.browserMainThread = function(tracingModel)
{
var processes = tracingModel.sortedProcesses();
+ // Avoid warning for an empty model.
+ if (!processes.length)
+ return null;
var browserProcesses = [];
var crRendererMainThreads = [];
for (var process of processes) {


al...@chromium.org

unread,
Sep 30, 2016, 9:57:42 PM9/30/16
to ca...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, pfel...@chromium.org, kozyatins...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Sep 30, 2016, 9:58:02 PM9/30/16
to ca...@chromium.org, al...@chromium.org, commi...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, pfel...@chromium.org, kozyatins...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2016, 12:06:34 AM10/1/16
to ca...@chromium.org, al...@chromium.org, commi...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, pfel...@chromium.org, kozyatins...@chromium.org
Committed patchset #2 (id:20001)

https://codereview.chromium.org/2379033005/

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2016, 12:08:39 AM10/1/16
to ca...@chromium.org, al...@chromium.org, commi...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, pfel...@chromium.org, kozyatins...@chromium.org
Patchset 2 (id:??) landed as
https://crrev.com/ac3114f52cf885036b5848fda6f0ca760deadecc
Cr-Commit-Position: refs/heads/master@{#422296}

https://codereview.chromium.org/2379033005/
Reply all
Reply to author
Forward
0 new messages