[DevTools] Prepare inspector_protocol build to move. (issue 2282283002 by dgozman@chromium.org)

2 views
Skip to first unread message

dgo...@chromium.org

unread,
Aug 26, 2016, 9:24:08 PM8/26/16
to pfel...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, kozyatins...@chromium.org
Reviewers: pfeldman
CL: https://codereview.chromium.org/2282283002/

Message:
Take a look please.

Description:
[DevTools] Prepare inspector_protocol build to move.

- Do not list inspector_protocol files anywhere outside;
- Separate concatenation from compatibility check;
- Improve files layout;
- Pass path to jinja module to CodeGenerator.

BUG=637032

Affected files (+366, -3833 lines):
M third_party/WebKit/Source/core/inspector/BUILD.gn
M third_party/WebKit/Source/core/inspector/inspector.gyp
M third_party/WebKit/Source/platform/BUILD.gn
D third_party/WebKit/Source/platform/inspector_protocol/Allocator_h.template
D third_party/WebKit/Source/platform/inspector_protocol/Array_h.template
D third_party/WebKit/Source/platform/inspector_protocol/BackendCallback_h.template
A + third_party/WebKit/Source/platform/inspector_protocol/CheckProtocolCompatibility.py
M third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py
D third_party/WebKit/Source/platform/inspector_protocol/Collections_h.template
A third_party/WebKit/Source/platform/inspector_protocol/ConcatenateProtocols.py
D third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase_cpp.template
D third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase_h.template
D third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport_cpp.template
D third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport_h.template
D third_party/WebKit/Source/platform/inspector_protocol/Exported_h.template
D third_party/WebKit/Source/platform/inspector_protocol/Forward_h.template
D third_party/WebKit/Source/platform/inspector_protocol/FrontendChannel_h.template
D third_party/WebKit/Source/platform/inspector_protocol/Imported_h.template
D third_party/WebKit/Source/platform/inspector_protocol/Maybe_h.template
D third_party/WebKit/Source/platform/inspector_protocol/Object_cpp.template
D third_party/WebKit/Source/platform/inspector_protocol/Object_h.template
D third_party/WebKit/Source/platform/inspector_protocol/Parser_cpp.template
D third_party/WebKit/Source/platform/inspector_protocol/Parser_h.template
D third_party/WebKit/Source/platform/inspector_protocol/Protocol_cpp.template
D third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template
D third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template
D third_party/WebKit/Source/platform/inspector_protocol/ValueConversions_h.template
D third_party/WebKit/Source/platform/inspector_protocol/Values_cpp.template
D third_party/WebKit/Source/platform/inspector_protocol/Values_h.template
D third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version
A third_party/WebKit/Source/platform/inspector_protocol/inspector_protocol.gni
A third_party/WebKit/Source/platform/inspector_protocol/inspector_protocol.gypi
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Allocator_h.template
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Array_h.template
A + third_party/WebKit/Source/platform/inspector_protocol/lib/BackendCallback_h.template
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Collections_h.template
A + third_party/WebKit/Source/platform/inspector_protocol/lib/DispatcherBase_cpp.template
A + third_party/WebKit/Source/platform/inspector_protocol/lib/DispatcherBase_h.template
A + third_party/WebKit/Source/platform/inspector_protocol/lib/ErrorSupport_cpp.template
A + third_party/WebKit/Source/platform/inspector_protocol/lib/ErrorSupport_h.template
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Forward_h.template
A + third_party/WebKit/Source/platform/inspector_protocol/lib/FrontendChannel_h.template
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Maybe_h.template
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Object_cpp.template
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Object_h.template
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Parser_cpp.template
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Parser_h.template
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Protocol_cpp.template
A + third_party/WebKit/Source/platform/inspector_protocol/lib/ValueConversions_h.template
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Values_cpp.template
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Values_h.template
A third_party/WebKit/Source/platform/inspector_protocol/sample_expected_errors.json
A + third_party/WebKit/Source/platform/inspector_protocol/templates/Exported_h.template
A + third_party/WebKit/Source/platform/inspector_protocol/templates/Imported_h.template
A + third_party/WebKit/Source/platform/inspector_protocol/templates/TypeBuilder_cpp.template
A + third_party/WebKit/Source/platform/inspector_protocol/templates/TypeBuilder_h.template
M third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp


pfel...@chromium.org

unread,
Aug 26, 2016, 9:45:43 PM8/26/16
to dgo...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, kozyatins...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Aug 29, 2016, 1:31:15 AM8/29/16
to dgo...@chromium.org, pfel...@chromium.org, commi...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, kozyatins...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Aug 29, 2016, 3:12:37 AM8/29/16
to dgo...@chromium.org, pfel...@chromium.org, commi...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, kozyatins...@chromium.org
Try jobs failed on following builders:
linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/131683)

https://codereview.chromium.org/2282283002/

commit-bot@chromium.org via codereview.chromium.org

unread,
Aug 29, 2016, 9:56:22 AM8/29/16
to dgo...@chromium.org, pfel...@chromium.org, commi...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, kozyatins...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Aug 29, 2016, 10:33:21 AM8/29/16
to dgo...@chromium.org, pfel...@chromium.org, commi...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, kozyatins...@chromium.org
Try jobs failed on following builders:
linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,

commit-bot@chromium.org via codereview.chromium.org

unread,
Aug 29, 2016, 12:45:11 PM8/29/16
to dgo...@chromium.org, pfel...@chromium.org, commi...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, kozyatins...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Aug 29, 2016, 4:49:13 PM8/29/16
to dgo...@chromium.org, pfel...@chromium.org, commi...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, kozyatins...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Aug 29, 2016, 5:21:21 PM8/29/16
to dgo...@chromium.org, pfel...@chromium.org, commi...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, kozyatins...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Aug 29, 2016, 7:55:13 PM8/29/16
to dgo...@chromium.org, pfel...@chromium.org, commi...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, kozyatins...@chromium.org
CQ is trying da patch. Follow status at

commit-bot@chromium.org via codereview.chromium.org

unread,
Aug 30, 2016, 1:09:26 AM8/30/16
to dgo...@chromium.org, pfel...@chromium.org, commi...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, kozyatins...@chromium.org
Committed patchset #4 (id:60001)

https://codereview.chromium.org/2282283002/

commit-bot@chromium.org via codereview.chromium.org

unread,
Aug 30, 2016, 1:12:02 AM8/30/16
to dgo...@chromium.org, pfel...@chromium.org, commi...@chromium.org, chromium...@chromium.org, caseq...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, kozyatins...@chromium.org
Patchset 4 (id:??) landed as
https://crrev.com/a73483cd5dd6d569d079e7ea43210f8482d12552
Cr-Commit-Position: refs/heads/master@{#415137}

https://codereview.chromium.org/2282283002/
Reply all
Reply to author
Forward
0 new messages