[Binding] [Refactoring] Remove ScriptValueCompositeCreator (issue 2009233002 by peria@chromium.org)

1 view
Skip to first unread message

pe...@chromium.org

unread,
May 25, 2016, 10:34:35 PM5/25/16
to yukishiin...@chromium.org, har...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org
Reviewers: Yuki, haraken
CL: https://codereview.chromium.org/2009233002/

Message:
PTL

Description:
Remove ScriptValueCompositeCreator, which was used as an interface
for SerializedScriptValueReader.
We can replace it with ScriptValueDeserializer.


BUG=148757

Base URL: https://chromium.googlesource.com/chromium/src.git@master

Affected files (+67, -94 lines):
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp
M third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.h
M third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp


har...@chromium.org

unread,
May 25, 2016, 10:40:09 PM5/25/16
to pe...@chromium.org, yukishiin...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
May 25, 2016, 11:38:41 PM5/25/16
to pe...@chromium.org, yukishiin...@chromium.org, har...@chromium.org, commi...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org

yukis...@chromium.org

unread,
May 26, 2016, 2:07:47 AM5/26/16
to pe...@chromium.org, har...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
May 26, 2016, 4:08:53 AM5/26/16
to pe...@chromium.org, yukishiin...@chromium.org, har...@chromium.org, commi...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org
Committed patchset #1 (id:1)

https://codereview.chromium.org/2009233002/

commit-bot@chromium.org via codereview.chromium.org

unread,
May 26, 2016, 4:10:18 AM5/26/16
to pe...@chromium.org, yukishiin...@chromium.org, har...@chromium.org, commi...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org
Patchset 1 (id:??) landed as
https://crrev.com/a0543c3453a4c387f762070412e700b4b59fc584
Cr-Commit-Position: refs/heads/master@{#396144}

https://codereview.chromium.org/2009233002/
Reply all
Reply to author
Forward
0 new messages