[DevTools] Stop listening to WidgetWillClose [chromium/src : master]

Dmitry Gozman (Gerrit)

unread,

Dec 15, 2017, 6:20:46 PM12/15/17

to apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, creis...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, pfeldma...@chromium.org, Pavel Feldman, chromium...@chromium.org, devtools...@chromium.org, John Abd-El-Malek

Could you please take a look?

Patch set 2:Commit-Queue +1

View Change

To view, visit change 830977. To unsubscribe, or for help writing mail filters, visit settings.

Pavel Feldman (Gerrit)

unread,

Dec 15, 2017, 7:20:08 PM12/15/17

to Dmitry Gozman, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, creis...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, pfeldma...@chromium.org, Commit Bot, chromium...@chromium.org, devtools...@chromium.org, John Abd-El-Malek

Patch set 2:Code-Review +1

View Change

To view, visit change 830977. To unsubscribe, or for help writing mail filters, visit settings.

Dmitry Gozman (Gerrit)

unread,

Dec 15, 2017, 7:48:59 PM12/15/17

to apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, creis...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, pfeldma...@chromium.org, Pavel Feldman, Commit Bot, chromium...@chromium.org, devtools...@chromium.org, John Abd-El-Malek

Patch set 2:Commit-Queue +2

View Change

To view, visit change 830977. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Dec 15, 2017, 7:59:01 PM12/15/17

to Dmitry Gozman, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, creis...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, pfeldma...@chromium.org, Pavel Feldman, chromium...@chromium.org, devtools...@chromium.org, John Abd-El-Malek

Commit Bot merged this change.

View Change

Approvals:
  Pavel Feldman: Looks good to me
  Dmitry Gozman: Commit

[DevTools] Stop listening to WidgetWillClose

It was introduced to resume other pages in the same render process
when the page paused on breakpoint is closed.

This now works due to Mojo connection error handler triggering
detach automatically and unpausing as a result.

Removing content-specific code from DevToolsAgent unblocks
migrating it to blink.

Bug: 776009
Change-Id: I20113df99a947eeaeabfb59886a07fc3f866ea27
Reviewed-on: https://chromium-review.googlesource.com/830977
Reviewed-by: Pavel Feldman <pfel...@chromium.org>
Commit-Queue: Dmitry Gozman <dgo...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524541}
---
M content/renderer/devtools/devtools_agent.cc
M content/renderer/devtools/devtools_agent.h
M content/renderer/render_view_browsertest.cc
A third_party/WebKit/LayoutTests/http/tests/inspector-protocol/target/resume-on-close-expected.txt
A third_party/WebKit/LayoutTests/http/tests/inspector-protocol/target/resume-on-close.js
5 files changed, 50 insertions(+), 23 deletions(-)

To view, visit change 830977. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward