Rewrap comments to 80 columns in Source/platform/image-decoders/. (issue 2385993002 by pkasting@chromium.org)

0 views
Skip to first unread message

pkas...@chromium.org

unread,
Oct 1, 2016, 3:37:06 AM10/1/16
to scr...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, jz...@chromium.org, sk...@google.com, urv...@chromium.org
Reviewers: scroggo_chromium
CL: https://codereview.chromium.org/2385993002/

Description:
Rewrap comments to 80 columns in Source/platform/image-decoders/.

This also rewrites some comments for clarity or brevity.

BUG=563793
TEST=none

Affected files (+202, -149 lines):
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp
M third_party/WebKit/Source/platform/image-decoders/ImageDecoderTest.cpp
M third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp
M third_party/WebKit/Source/platform/image-decoders/ImageFrame.h
M third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.h
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp
M third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.h
M third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp
M third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
M third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoderTest.cpp
M third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.cpp
M third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h
M third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp
M third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoderTest.cpp


scr...@chromium.org

unread,
Oct 4, 2016, 11:36:19 AM10/4/16
to pkas...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, jz...@chromium.org, sk...@google.com, urv...@chromium.org
lgtm




https://codereview.chromium.org/2385993002/diff/1/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp
File
third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp
(right):

https://codereview.chromium.org/2385993002/diff/1/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp#newcode330
third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp:330:
// Performs decoding for this frame. frameDecoded will be true if the
entire
nit: This sentence feels awkward to me. Why not "Decode this frame"? (I
think it's less awkward above, when we are performing a specific
decoding algorithm.

https://codereview.chromium.org/2385993002/

pkas...@chromium.org

unread,
Oct 4, 2016, 12:01:58 PM10/4/16
to scr...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, jz...@chromium.org, sk...@google.com, urv...@chromium.org

https://codereview.chromium.org/2385993002/diff/1/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp
File
third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp
(right):

https://codereview.chromium.org/2385993002/diff/1/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp#newcode330
third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp:330:
// Performs decoding for this frame. frameDecoded will be true if the
entire
On 2016/10/04 15:36:00, scroggo_chromium wrote:
> nit: This sentence feels awkward to me. Why not "Decode this frame"?
(I think
> it's less awkward above, when we are performing a specific decoding
algorithm.

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 4, 2016, 12:02:40 PM10/4/16
to pkas...@chromium.org, scr...@chromium.org, commi...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, jz...@chromium.org, sk...@google.com, urv...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 4, 2016, 1:30:10 PM10/4/16
to pkas...@chromium.org, scr...@chromium.org, commi...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, jz...@chromium.org, sk...@google.com, urv...@chromium.org
Committed patchset #2 (id:20001)

https://codereview.chromium.org/2385993002/

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 4, 2016, 1:32:16 PM10/4/16
to pkas...@chromium.org, scr...@chromium.org, commi...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, jz...@chromium.org, sk...@google.com, urv...@chromium.org
Patchset 2 (id:??) landed as
https://crrev.com/e462f7cce1b45cc62a96abc33fe9961504c756d8
Cr-Commit-Position: refs/heads/master@{#422844}

https://codereview.chromium.org/2385993002/
Reply all
Reply to author
Forward
0 new messages