Enable PreloadDefaultIsMetadata by default. [chromium/src : master]
0 views
Skip to first unread message
apacible (Gerrit)
Oct 20, 2017, 7:08:48 PM10/20/17
to blink-...@chromium.org, kinuko...@chromium.org, Philip Jägenstedt, Mounir Lamouri, chromium...@chromium.org
This change is ready for review.
To view, visit change 731675. To unsubscribe, or for help writing mail filters, visit settings.
apacible (Gerrit)
Oct 20, 2017, 7:08:58 PM10/20/17
to blink-...@chromium.org, kinuko...@chromium.org, Philip Jägenstedt, Mounir Lamouri, chromium...@chromium.org
PTAL, thanks!
apacible (Gerrit)
Oct 20, 2017, 7:09:30 PM10/20/17
to Philip Jägenstedt, blink-...@chromium.org, kinuko...@chromium.org, Mounir Lamouri, chromium...@chromium.org
apacible uploaded patch set #3 to this change.
Enable PreloadDefaultIsMetadata by default.
Starting M64, set <video> and <audio> preload= default to metadata.
Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/5CDvJkdxyQ8
Bug: 310450
Change-Id: I681f532a688646523028f8cc8578d8da29ea1881
---
M third_party/WebKit/Source/platform/runtime_enabled_features.json5
1 file changed, 1 insertion(+), 1 deletion(-)
To view, visit change 731675. To unsubscribe, or for help writing mail filters, visit settings.
Mounir Lamouri (Gerrit)
Oct 21, 2017, 9:59:22 AM10/21/17
to apacible, blink-...@chromium.org, kinuko...@chromium.org, Philip Jägenstedt, chromium...@chromium.org
Maybe we should decouple with the Feature flag or also turn the Feature flag on by default? I wonder how this is behaving otherwise.
lgtm with this
Patch set 3:Code-Review +1
apacible (Gerrit)
Oct 23, 2017, 7:29:35 PM10/23/17
to amp+...@chromium.org, apacibl...@chromium.org, blink-...@chromium.org, creis...@chromium.org, dari...@chromium.org, erickun...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, mfoltz...@chromium.org, miu+...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, xjz+...@chromium.org, Mounir Lamouri, Philip Jägenstedt
apacible would like Dimitri Glazkov to review this change.
Enable PreloadDefaultIsMetadata by default.
Starting M64, set <video> and <audio> preload= default to metadata.
Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/5CDvJkdxyQ8
Bug: 310450
Change-Id: I681f532a688646523028f8cc8578d8da29ea1881
---
M content/renderer/render_view_impl.cc
M media/base/media_switches.cc
M media/base/media_switches.h
M media/blink/webmediaplayer_impl.cc
M third_party/WebKit/Source/platform/runtime_enabled_features.json5
5 files changed, 2 insertions(+), 12 deletions(-)
apacible (Gerrit)
Oct 23, 2017, 7:29:36 PM10/23/17
to amp+...@chromium.org, apacibl...@chromium.org, blink-...@chromium.org, creis...@chromium.org, dari...@chromium.org, erickun...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, mfoltz...@chromium.org, miu+...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, xjz+...@chromium.org, Commit Bot, John Abd-El-Malek, Mounir Lamouri, Philip Jägenstedt, chromium...@chromium.org
+dglazkov for everything
Patch Set 3: Code-Review+1
Maybe we should decouple with the Feature flag or also turn the Feature flag on by default? I wonder how this is behaving otherwise.
lgtm with this
Removed flag.
Dimitri Glazkov (Gerrit)
Oct 24, 2017, 11:34:12 AM10/24/17
to apacible, amp+...@chromium.org, apacibl...@chromium.org, blink-...@chromium.org, creis...@chromium.org, dari...@chromium.org, erickun...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, mfoltz...@chromium.org, miu+...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, xjz+...@chromium.org, Commit Bot, John Abd-El-Malek, Mounir Lamouri, Philip Jägenstedt, chromium...@chromium.org
Nice! I love removing flags! 🙌
Patch set 5:Code-Review +1
apacible (Gerrit)
Oct 25, 2017, 6:42:51 PM10/25/17
to amp+...@chromium.org, apacibl...@chromium.org, blink-...@chromium.org, creis...@chromium.org, dari...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, mfoltz...@chromium.org, miu+...@chromium.org, mlamouri+w...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, poscia...@chromium.org, xjz+...@chromium.org, srirama chandra sekhar, Commit Bot, John Abd-El-Malek, Mounir Lamouri, Philip Jägenstedt, chromium...@chromium.org
Patch set 7:Commit-Queue +2
Commit Bot (Gerrit)
Oct 25, 2017, 6:43:46 PM10/25/17
to apacible, amp+...@chromium.org, apacibl...@chromium.org, blink-...@chromium.org, creis...@chromium.org, dari...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, mfoltz...@chromium.org, miu+...@chromium.org, mlamouri+w...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, poscia...@chromium.org, xjz+...@chromium.org, srirama chandra sekhar, John Abd-El-Malek, Mounir Lamouri, Philip Jägenstedt, chromium...@chromium.org
CQ is trying da patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"Update tests" https://chromium-review.googlesource.com/c/731675/7
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/731675/7
Bot data: {"action": "start", "triggered_at": "2017-10-25T22:42:47.0Z", "cq_cfg_revision": "9a38c589b0e2b2b60016e0718cdc887f91afc5ed", "revision": "277da06261146daad3c846412886e113748eea35"}
Commit Bot (Gerrit)
Oct 25, 2017, 10:04:01 PM10/25/17
to apacible, amp+...@chromium.org, apacibl...@chromium.org, blink-...@chromium.org, creis...@chromium.org, dari...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, mfoltz...@chromium.org, miu+...@chromium.org, mlamouri+w...@chromium.org, mlamouri+wa...@chromium.org, nasko+c...@chromium.org, poscia...@chromium.org, xjz+...@chromium.org, srirama chandra sekhar, John Abd-El-Malek, Mounir Lamouri, Philip Jägenstedt, chromium...@chromium.org
Commit Bot merged this change.
Approvals:
Mounir Lamouri: Looks good to me
Dimitri Glazkov: Looks good to me
apacible: Commit
Enable PreloadDefaultIsMetadata by default.
Starting M64, set <video> and <audio> preload= default to metadata.
Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/5CDvJkdxyQ8
Bug: 310450
Change-Id: I681f532a688646523028f8cc8578d8da29ea1881
Reviewed-on: https://chromium-review.googlesource.com/731675
Commit-Queue: apacible <apac...@chromium.org>
Reviewed-by: Dimitri Glazkov <dgla...@chromium.org>
Reviewed-by: Mounir Lamouri <mlam...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511696}
---
M content/renderer/render_view_impl.cc
M media/base/media_switches.cc
M media/base/media_switches.h
M media/blink/webmediaplayer_impl.cc
M third_party/WebKit/LayoutTests/fast/dom/element-attribute-js-null-expected.txt
M third_party/WebKit/LayoutTests/fast/dom/element-attribute-js-null.html
M third_party/WebKit/LayoutTests/http/tests/media/preload-conditions.html
M third_party/WebKit/LayoutTests/media/W3C/audio/preload/preload_reflects_bogus_value-expected.txt
M third_party/WebKit/LayoutTests/media/W3C/audio/preload/preload_reflects_bogus_value.html
M third_party/WebKit/LayoutTests/media/W3C/audio/preload/preload_reflects_no_value-expected.txt
M third_party/WebKit/LayoutTests/media/W3C/audio/preload/preload_reflects_no_value.html
M third_party/WebKit/LayoutTests/media/W3C/video/preload/preload_reflects_bogus_value-expected.txt
M third_party/WebKit/LayoutTests/media/W3C/video/preload/preload_reflects_bogus_value.html
M third_party/WebKit/LayoutTests/media/W3C/video/preload/preload_reflects_no_value-expected.txt
M third_party/WebKit/LayoutTests/media/W3C/video/preload/preload_reflects_no_value.html
M third_party/WebKit/LayoutTests/media/media-ended.html
M third_party/WebKit/LayoutTests/media/video-playbackrate.html
M third_party/WebKit/Source/platform/runtime_enabled_features.json5
18 files changed, 28 insertions(+), 37 deletions(-)
Reply all
Reply to author
Forward
0 new messages