Rename Blink API codegen bits to BlinkAPI. (issue 2648173002 by dglazkov@chromium.org)

dgla...@chromium.org

unread,

Jan 24, 2017, 12:04:30 PM1/24/17

to ba...@chromium.org, yukishiin...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, chromium...@chromium.org, dpr...@chromium.org

Reviewers: bashi, Yuki
CL: https://codereview.chromium.org/2648173002/

Message:
PTAL.

Description:
Rename Blink API codegen bits to BlinkAPI.

Replace all references to webmodules with new terminology.

R=bashi,yukishiino
BUG=683740

Affected files (+24, -390 lines):
M third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt
A + third_party/WebKit/Source/bindings/scripts/code_generator_blink_api.py
A + third_party/WebKit/Source/bindings/scripts/code_generator_blink_api_test.py
D third_party/WebKit/Source/bindings/scripts/code_generator_web_module.py
D third_party/WebKit/Source/bindings/scripts/code_generator_web_module_test.py
M third_party/WebKit/Source/bindings/scripts/scripts.gni
A + third_party/WebKit/Source/bindings/templates/blink_api_interface.cpp.tmpl
A + third_party/WebKit/Source/bindings/templates/blink_api_interface.h.tmpl
M third_party/WebKit/Source/bindings/templates/templates.gni
D third_party/WebKit/Source/bindings/templates/web_module_interface.cpp.tmpl
D third_party/WebKit/Source/bindings/templates/web_module_interface.h.tmpl
M third_party/WebKit/Source/bindings/tests/idls/core/TestInterface3.idl
M third_party/WebKit/Source/bindings/tests/results/core/WebTestInterface3.h
M third_party/WebKit/Source/bindings/tests/results/core/WebTestInterface3.cpp
M third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py

har...@chromium.org

unread,

Jan 24, 2017, 4:00:22 PM1/24/17

to dgla...@chromium.org, ba...@chromium.org, yukishiin...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, chromium...@chromium.org, dpr...@chromium.org

"Blink API" sounds a bit too vague to me. For example, we have "public APIs" and
"web-exposed APIs", which are also Blink's APIs.

Is there any reason you wanted to avoid something like "WebAgent API"?

https://codereview.chromium.org/2648173002/diff/1/third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt
File third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt
(right):

https://codereview.chromium.org/2648173002/diff/1/third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt#newcode103
third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt:103:
BlinkAPI

alphabetical order

https://codereview.chromium.org/2648173002/

ba...@chromium.org

unread,

Jan 25, 2017, 6:57:14 PM1/25/17

to dgla...@chromium.org, yukishiin...@chromium.org, har...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, chromium...@chromium.org, dpr...@chromium.org

yukis...@chromium.org

unread,

Jan 26, 2017, 3:17:19 AM1/26/17

to dgla...@chromium.org, ba...@chromium.org, har...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, chromium...@chromium.org, dpr...@chromium.org

I agree that "Blink API" is too vague, or unfriendly to code readers.
[BlinkAPI] in .idl files doesn't look crystal clear about what it means.

https://codereview.chromium.org/2648173002/

Reply all

Reply to author

Forward