probe: Qualify #includes in generated code. [chromium/src : master]

Kent Tamura (Gerrit)

unread,

Apr 24, 2018, 5:07:34 AM4/24/18

to Kent Tamura, blink-...@chromium.org, kinuko...@chromium.org, Alexei Filippov, Commit Bot, chromium...@chromium.org

alph@, would you review this please?

View Change

To view, visit change 1025233. To unsubscribe, or for help writing mail filters, visit settings.

Kent Tamura (Gerrit)

unread,

Apr 24, 2018, 5:07:34 AM4/24/18

to Alexei Filippov, blink-...@chromium.org, kinuko...@chromium.org, Kent Tamura

Kent Tamura would like Alexei Filippov to review this change.

View Change

probe: Qualify #includes in generated code.

* Add "third_party/blink/renderer/" to some values in CoreProbes.json5
  and PlatformProbes.json5.

* make_instrumenting_probes.py passes a directory name relative to
  out/$config/gen/, and a template uses it to generate #includes.

Bug: 836071
Change-Id: I31ac5efaba5b96914e342d5c4f54a236b5c3fab1
---
M third_party/blink/renderer/build/scripts/make_instrumenting_probes.py
M third_party/blink/renderer/build/scripts/templates/InstrumentingProbesImpl.cpp.tmpl
M third_party/blink/renderer/core/probe/CoreProbes.json5
M third_party/blink/renderer/platform/probe/PlatformProbes.json5
4 files changed, 21 insertions(+), 15 deletions(-)

To view, visit change 1025233. To unsubscribe, or for help writing mail filters, visit settings.

Alexei Filippov (Gerrit)

unread,

Apr 24, 2018, 2:24:05 PM4/24/18

to Kent Tamura, blink-...@chromium.org, kinuko...@chromium.org, Commit Bot, chromium...@chromium.org

LGTM. Thanks

Patch set 2:Code-Review +1

View Change

To view, visit change 1025233. To unsubscribe, or for help writing mail filters, visit settings.

Kent Tamura (Gerrit)

unread,

Apr 24, 2018, 7:12:59 PM4/24/18

to Kent Tamura, blink-...@chromium.org, kinuko...@chromium.org, Alexei Filippov, Commit Bot, chromium...@chromium.org

Patch set 2:Commit-Queue +2

View Change

To view, visit change 1025233. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Apr 24, 2018, 7:20:05 PM4/24/18

to Kent Tamura, blink-...@chromium.org, kinuko...@chromium.org, Alexei Filippov, chromium...@chromium.org

Commit Bot merged this change.

View Change

Approvals:
  Alexei Filippov: Looks good to me
  Kent Tamura: Commit

probe: Qualify #includes in generated code.

* Add "third_party/blink/renderer/" to some values in CoreProbes.json5
  and PlatformProbes.json5.

* make_instrumenting_probes.py passes a directory name relative to
  out/$config/gen/, and a template uses it to generate #includes.

Bug: 836071
Change-Id: I31ac5efaba5b96914e342d5c4f54a236b5c3fab1

Reviewed-on: https://chromium-review.googlesource.com/1025233
Reviewed-by: Alexei Filippov <al...@chromium.org>
Commit-Queue: Kent Tamura <tk...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553351}


---
M third_party/blink/renderer/build/scripts/make_instrumenting_probes.py
M third_party/blink/renderer/build/scripts/templates/InstrumentingProbesImpl.cpp.tmpl
M third_party/blink/renderer/core/probe/CoreProbes.json5
M third_party/blink/renderer/platform/probe/PlatformProbes.json5
4 files changed, 21 insertions(+), 15 deletions(-)

To view, visit change 1025233. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward