Add W3C encrypted-media tests (issue 2546853003 by jrummell@chromium.org)

[jrum...@chromium.org]

Reviewers: xhwang, qyearsley
CL: https://codereview.chromium.org/2546853003/

Message:
PTAL.

qyearsley@: I see that you've submitted a few updates attempting to get the
auto-roller working again, so I'll wait until that succeeds. If there is a
better way to do this (presubmit complains about missing paths so I had to use
--bypass-hooks), like including the encrypted-media files from my local running
of the script, please let me know.

Description:
Add W3C encrypted-media tests

BUG=664193
TEST=imported tests pass

Affected files (+100, -1 lines):
M third_party/WebKit/LayoutTests/NeverFixTests
M third_party/WebKit/LayoutTests/W3CImportExpectations

[xhw...@chromium.org]

lg % nit, I'll defer to qyearsley for the final review.


https://codereview.chromium.org/2546853003/diff/1/third_party/WebKit/LayoutTests/NeverFixTests
File third_party/WebKit/LayoutTests/NeverFixTests (right):

https://codereview.chromium.org/2546853003/diff/1/third_party/WebKit/LayoutTests/NeverFixTests#newcode194
third_party/WebKit/LayoutTests/NeverFixTests:194: # These tests require
a DRM system that is not provided with Chromium.
here and below, s/Chromium/content_shell

https://codereview.chromium.org/2546853003/

[qyea...@chromium.org]

On 2016/12/02 at 00:58:25, jrummell wrote:
> PTAL.
>
> qyearsley@: I see that you've submitted a few updates attempting to get the
auto-roller working again, so I'll wait until that succeeds. If there is a
better way to do this (presubmit complains about missing paths so I had to use
--bypass-hooks), like including the encrypted-media files from my local running
of the script, please let me know.

The auto-roller did an update this morning
(https://codereview.chromium.org/2547023002) so this should be good to go I
believe.

Including the encrypted-media files with this CL would be one way to avoid
having to use --bypass-hooks, and would also provide extra assurance that things
will work correctly on all platforms if it can pass all of the blink try bots,
so that might be preferable.

Also: if upstream web-platform-tests/encrypted-media were split into
sub-directories by dependencies (e.g. drm/, clearkey/, ...) then listing the
directories in NeverFixTests would be a little cleaner -- you could just list a
couple of directories, e.g. imported/wpt/encrypted-media/clearkey and
imported/wpt/encrypted-media/drm, instead of listing every test. Does that sound
like something that may be reasonable to do anyway?

In any case, LGTM to land if you want to land this now; after landing, I could
star the autoroller to fetch the tests; but if you want to add the files in this
CL itself that would also be good, I think.

https://codereview.chromium.org/2546853003/

[commit-bot@chromium.org via codereview.chromium.org]

CQ is trying da patch. Follow status at

https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546853003/60001


https://codereview.chromium.org/2546853003/

[commit-bot@chromium.org via codereview.chromium.org]

Committed patchset #4 (id:60001)

https://codereview.chromium.org/2546853003/

[commit-bot@chromium.org via codereview.chromium.org]

Patchset 4 (id:??) landed as
https://crrev.com/3a21b9ef6a2bee40813b39bc1cd8911a29dc28f6
Cr-Commit-Position: refs/heads/master@{#437343}

https://codereview.chromium.org/2546853003/