[devtools] Also update emulation if viewport scale changes. [chromium/src : master]
0 views
Skip to first unread message
Eric Seckler (Gerrit)
Oct 21, 2017, 3:10:04 PM10/21/17
to apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Pavel Feldman, chromium...@chromium.org, devtools...@chromium.org
Pavel, PTAL. Should be a quick one :)
Patch set 1:Commit-Queue +1
To view, visit change 732107. To unsubscribe, or for help writing mail filters, visit settings.
Pavel Feldman (Gerrit)
Oct 23, 2017, 5:30:35 PM10/23/17
to Eric Seckler, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Commit Bot, chromium...@chromium.org, devtools...@chromium.org
Patch set 1:Code-Review +1
Eric Seckler (Gerrit)
Oct 24, 2017, 2:55:26 AM10/24/17
to apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Pavel Feldman, Commit Bot, chromium...@chromium.org, devtools...@chromium.org
Patch set 1:Commit-Queue +2
Commit Bot (Gerrit)
Oct 24, 2017, 3:40:25 AM10/24/17
to Eric Seckler, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Pavel Feldman, chromium...@chromium.org, devtools...@chromium.org
Try jobs failed on following builders:
mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/572561)
Eric Seckler (Gerrit)
Oct 24, 2017, 3:42:20 AM10/24/17
to apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Pavel Feldman, Commit Bot, chromium...@chromium.org, devtools...@chromium.org
Patch set 1:Commit-Queue +2
Commit Bot (Gerrit)
Oct 24, 2017, 4:24:56 AM10/24/17
to Eric Seckler, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Pavel Feldman, chromium...@chromium.org, devtools...@chromium.org
Commit Bot merged this change.
Approvals:
Pavel Feldman: Looks good to me
Eric Seckler: Commit
[devtools] Also update emulation if viewport scale changes.
Early out was missing a case.
Change-Id: I4976b807399f3c485fb152065d9cc8884a5aa919
Reviewed-on: https://chromium-review.googlesource.com/732107
Reviewed-by: Pavel Feldman <pfel...@chromium.org>
Commit-Queue: Eric Seckler <esec...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511060}
---
M third_party/WebKit/Source/core/inspector/DevToolsEmulator.cpp
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/third_party/WebKit/Source/core/inspector/DevToolsEmulator.cpp b/third_party/WebKit/Source/core/inspector/DevToolsEmulator.cpp
index ff7960a..2c17ccb 100644
--- a/third_party/WebKit/Source/core/inspector/DevToolsEmulator.cpp
+++ b/third_party/WebKit/Source/core/inspector/DevToolsEmulator.cpp
@@ -208,7 +208,8 @@
emulation_params_.screen_position == params.screen_position &&
emulation_params_.device_scale_factor == params.device_scale_factor &&
emulation_params_.scale == params.scale &&
- emulation_params_.viewport_offset == params.viewport_offset) {
+ emulation_params_.viewport_offset == params.viewport_offset &&
+ emulation_params_.viewport_scale == params.viewport_scale) {
return;
}
if (emulation_params_.device_scale_factor != params.device_scale_factor ||
To view, visit change 732107. To unsubscribe, or for help writing mail filters, visit settings.
Reply all
Reply to author
Forward
0 new messages