Reviewers: yhirano
CL:
https://codereview.chromium.org/2224713002/https://codereview.chromium.org/2224713002/diff/180001/third_party/WebKit/Source/modules/modules.gypiFile third_party/WebKit/Source/modules/modules.gypi (right):
https://codereview.chromium.org/2224713002/diff/180001/third_party/WebKit/Source/modules/modules.gypi#newcode2096third_party/WebKit/Source/modules/modules.gypi:2096:
'websockets/WebSocketHandle.cpp',
This is here because DocumentWebSocketChannelTest now has a dependency
on WebSocketHandle. That used to be an interface w/ just a bunch of pure
virtual methods. Now, instead, it is the real concrete class with
virtual methods that can be overridden for the sake of testing. I did
that because it seemed better to have less code (i.e., no
WebSocketHandleImpl class), but it seems like an uncommon approach, so
flagging here for consideration.
Description:
Move WebSocketHandleImpl into Blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@masterAffected files (+407, -1108 lines):
M content/browser/DEPS
M content/browser/websockets/websocket_impl.h
M content/browser/websockets/websocket_impl.cc
M content/browser/websockets/websocket_manager.h
M content/browser/websockets/websocket_manager.cc
M content/browser/websockets/websocket_manager_unittest.cc
M content/common/BUILD.gn
D content/common/websocket.mojom
M content/content_common_mojo_bindings.gyp
M content/content_renderer.gypi
M content/renderer/render_frame_impl.h
M content/renderer/render_frame_impl.cc
M content/renderer/renderer_blink_platform_impl.h
M content/renderer/renderer_blink_platform_impl.cc
D content/renderer/websockethandle_impl.h
D content/renderer/websockethandle_impl.cc
M third_party/WebKit/Source/core/loader/FrameLoaderClient.h
M third_party/WebKit/Source/modules/modules.gypi
M third_party/WebKit/Source/modules/websockets/DEPS
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp
A + third_party/WebKit/Source/modules/websockets/WebSocketHandle.h
A third_party/WebKit/Source/modules/websockets/WebSocketHandle.cpp
A + third_party/WebKit/Source/modules/websockets/WebSocketHandleClient.h
M third_party/WebKit/Source/platform/blink_platform.gypi
D third_party/WebKit/Source/platform/exported/WebSocketHandshakeRequestInfo.cpp
D third_party/WebKit/Source/platform/exported/WebSocketHandshakeResponseInfo.cpp
M third_party/WebKit/Source/web/FrameLoaderClientImpl.h
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
M third_party/WebKit/Source/web/WebSharedWorkerImpl.h
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
M third_party/WebKit/public/BUILD.gn
M third_party/WebKit/public/blink_headers.gypi
M third_party/WebKit/public/platform/Platform.h
M third_party/WebKit/public/platform/modules/websockets/OWNERS
D third_party/WebKit/public/platform/modules/websockets/WebSocketHandle.h
D third_party/WebKit/public/platform/modules/websockets/WebSocketHandleClient.h
D third_party/WebKit/public/platform/modules/websockets/WebSocketHandshakeRequestInfo.h
D third_party/WebKit/public/platform/modules/websockets/WebSocketHandshakeResponseInfo.h
A + third_party/WebKit/public/platform/modules/websockets/websocket.mojom
M third_party/WebKit/public/web/WebFrameClient.h