Worker: Add OWNERS to core/workers (issue 2175243005 by nhiroki@chromium.org)

0 views
Skip to first unread message

nhi...@chromium.org

unread,
Jul 26, 2016, 5:59:35 AM7/26/16
to kin...@chromium.org, har...@chromium.org, chromium...@chromium.org, aba...@chromium.org, fal...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, blink-work...@chromium.org
Reviewers: kinuko, haraken
CL: https://codereview.chromium.org/2175243005/

Message:
Hi core/ owners,

I'd like to nominate myself for an owner of core/workers. I think I have enough
knowledge and experiences to take ownership. These are samples of my changes
under the directory:

Implemented WorkerThread graceful shutdown:
- https://codereview.chromium.org/1978163002
- https://codereview.chromium.org/2011763002
- https://codereview.chromium.org/2015823002

Implemented a mechanism to detect worker thread shutdown from main thread:
- https://codereview.chromium.org/2025783002

Refined/Refining the entire worker infrastructure:
-
https://docs.google.com/document/d/1c9XJuByGN92IqUsovR4DRap_rQSvxg1NJSItbuUnZio/edit?usp=sharing
-
https://docs.google.com/document/d/1IWgnaDMkEZq1TSXCywE9LwxfvNgtZ9-O76JhDzWI1Bg/edit?usp=sharing
- https://codereview.chromium.org/1888703002
- https://codereview.chromium.org/1897193002

Fixed crash bugs:
- https://codereview.chromium.org/2041753002
- https://codereview.chromium.org/2046483002
- https://codereview.chromium.org/2075243002

Now fixing GC logic for dedicated workers:
- https://codereview.chromium.org/2124693002

I'm an owner of ServiceWorker that is a big client of core/workers
infrastructure:
-
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/serviceworkers/OWNERS
-
https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/modules/serviceworker/OWNERS

Please let me know if you have any questions/concerns. Thanks!

Description:
Worker: Add OWNERS to core/workers

BUG=n/a

Base URL: https://chromium.googlesource.com/chromium/src.git@master

Affected files (+0, -1 lines):
A + third_party/WebKit/Source/core/workers/OWNERS


Index: third_party/WebKit/Source/core/workers/OWNERS
diff --git a/storage/browser/fileapi/OWNERS b/third_party/WebKit/Source/core/workers/OWNERS
similarity index 53%
copy from storage/browser/fileapi/OWNERS
copy to third_party/WebKit/Source/core/workers/OWNERS
index 232db84c296c464a174d7421e9a2f86531aeb7cf..25402fda5d8c43afd3856c6a940e35bd19f29f40 100644
--- a/storage/browser/fileapi/OWNERS
+++ b/third_party/WebKit/Source/core/workers/OWNERS
@@ -1,2 +1 @@
-t...@chromium.org
nhi...@chromium.org


har...@chromium.org

unread,
Jul 26, 2016, 6:06:45 AM7/26/16
to nhi...@chromium.org, kin...@chromium.org, chromium...@chromium.org, aba...@chromium.org, fal...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, blink-work...@chromium.org
LGTM

(Nit: IMHO I'm not really happy about having sub-directory owners in core/, but
that's a separate discussion -- we haven't reached consensus yet.)


https://codereview.chromium.org/2175243005/

kin...@chromium.org

unread,
Jul 26, 2016, 8:54:52 AM7/26/16
to nhi...@chromium.org, har...@chromium.org, chromium...@chromium.org, aba...@chromium.org, fal...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, blink-work...@chromium.org

nhi...@chromium.org

unread,
Jul 26, 2016, 9:19:20 AM7/26/16
to kin...@chromium.org, har...@chromium.org, chromium...@chromium.org, aba...@chromium.org, fal...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, blink-work...@chromium.org
Thank you!


On 2016/07/26 10:06:44, haraken wrote:
> (Nit: IMHO I'm not really happy about having sub-directory owners in core/,
but
> that's a separate discussion -- we haven't reached consensus yet.)

commit-bot@chromium.org via codereview.chromium.org

unread,
Jul 26, 2016, 9:26:53 AM7/26/16
to nhi...@chromium.org, kin...@chromium.org, har...@chromium.org, commi...@chromium.org, chromium...@chromium.org, aba...@chromium.org, fal...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, blink-work...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Jul 26, 2016, 9:28:01 AM7/26/16
to nhi...@chromium.org, kin...@chromium.org, har...@chromium.org, commi...@chromium.org, chromium...@chromium.org, aba...@chromium.org, fal...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, blink-work...@chromium.org, ikilp...@chromium.org, yhi...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Jul 26, 2016, 10:28:43 AM7/26/16
to nhi...@chromium.org, kin...@chromium.org, har...@chromium.org, commi...@chromium.org, chromium...@chromium.org, aba...@chromium.org, fal...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, blink-work...@chromium.org, ikilp...@chromium.org, yhi...@chromium.org
Committed patchset #1 (id:1)

https://codereview.chromium.org/2175243005/

commit-bot@chromium.org via codereview.chromium.org

unread,
Jul 26, 2016, 10:30:00 AM7/26/16
to nhi...@chromium.org, kin...@chromium.org, har...@chromium.org, commi...@chromium.org, chromium...@chromium.org, aba...@chromium.org, fal...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, blink-work...@chromium.org, ikilp...@chromium.org, yhi...@chromium.org
Patchset 1 (id:??) landed as
https://crrev.com/a87f0f1544db6e2e2eca8469ff03e86c03354a28
Cr-Commit-Position: refs/heads/master@{#407788}

https://codereview.chromium.org/2175243005/
Reply all
Reply to author
Forward
0 new messages