[DevTools] hide blackboxed frames in stack trace popover [chromium/src : master]
Aleksey Kozyatinskiy (Gerrit)
Andrey, please take a look!
Patch set 2:Commit-Queue +1
To view, visit change 874785. To unsubscribe, or for help writing mail filters, visit settings.
Andrey Lushnikov (Gerrit)
Patch set 2:Code-Review +1Commit-Queue +1
2 comments:
File third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js:
Patch Set #2, Line 311:
Common.UIStringls
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js:
Patch Set #2, Line 544:
() => popover.setSizeBehavior(UI.GlassPane.SizeBehavior.MeasureContent@dgozman might suggest a better approach to deal with glasspane
To view, visit change 874785. To unsubscribe, or for help writing mail filters, visit settings.
Aleksey Kozyatinskiy (Gerrit)
Dmitry, please suggest something amazing for glass pane.
Aleksey Kozyatinskiy (Gerrit)
Aleksey Kozyatinskiy would like Dmitry Gozman to review this change.
[DevTools] hide blackboxed frames in stack trace popover
We hide blackboxed frames the same way as in call stack sidebar pane
with Show link to unhide frames.
Screenshot: https://imgur.com/a/3nA1p
Bug:chromium:550453,chromium:740632
Change-Id: I46dc4bcf0ce738a01c3d56870e609f4d1e04f82a
R=lush...@chromium.org
---
M third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js
M third_party/WebKit/Source/devtools/front_end/components/domUtils.css
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
3 files changed, 48 insertions(+), 4 deletions(-)
Dmitry Gozman (Gerrit)
Could you please add screenshots of performance and console usages of buildStackTracePreviewContents?
1 comment:
Patch Set #2, Line 544:
() => popover.setSizeBehavior(UI.GlassPane.SizeBehavior.MeasureContent@dgozman might suggest a better approach to deal with glasspane
This is fine.
To view, visit change 874785. To unsubscribe, or for help writing mail filters, visit settings.
Aleksey Kozyatinskiy (Gerrit)
Aleksey Kozyatinskiy uploaded patch set #3 to this change.
[DevTools] hide blackboxed frames in stack trace popover
We hide blackboxed frames the same way as in call stack sidebar pane
with Show link to unhide frames.
Screenshot: https://imgur.com/a/3nA1p
Screenshot console: https://imgur.com/a/0iygW
Bug:chromium:550453,chromium:740632
Change-Id: I46dc4bcf0ce738a01c3d56870e609f4d1e04f82a
R=lush...@chromium.org
---
M third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js
M third_party/WebKit/Source/devtools/front_end/components/domUtils.css
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
3 files changed, 48 insertions(+), 4 deletions(-)
To view, visit change 874785. To unsubscribe, or for help writing mail filters, visit settings.
Aleksey Kozyatinskiy (Gerrit)
Aleksey Kozyatinskiy uploaded patch set #4 to this change.
[DevTools] hide blackboxed frames in stack trace popover
We hide blackboxed frames the same way as in call stack sidebar pane
with Show link to unhide frames.
Screenshot: https://imgur.com/a/3nA1p
Screenshot console and timeline: https://imgur.com/a/0iygW
Bug:chromium:550453,chromium:740632
Change-Id: I46dc4bcf0ce738a01c3d56870e609f4d1e04f82a
R=lush...@chromium.org
---
M third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js
M third_party/WebKit/Source/devtools/front_end/components/domUtils.css
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
3 files changed, 48 insertions(+), 4 deletions(-)
To view, visit change 874785. To unsubscribe, or for help writing mail filters, visit settings.
Aleksey Kozyatinskiy (Gerrit)
Screenshot added, Dmitry please take another look!
Patch set 4:Commit-Queue +1
2 comments:
Patch Set #2, Line 311:
Common.UIStringls
Patch Set #2, Line 544:
() => popover.setSizeBehavior(UI.GlassPane.SizeBehavior.MeasureContent
This is fine.
Done
To view, visit change 874785. To unsubscribe, or for help writing mail filters, visit settings.
Aleksey Kozyatinskiy (Gerrit)
Aleksey Kozyatinskiy uploaded patch set #5 to this change.
[DevTools] hide blackboxed frames in stack trace popover
We hide blackboxed frames the same way as in call stack sidebar pane
with Show link to unhide frames.
Screenshots: https://imgur.com/a/xKjsJ
Bug:chromium:550453,chromium:740632
Change-Id: I46dc4bcf0ce738a01c3d56870e609f4d1e04f82a
R=lush...@chromium.org
---
M third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js
M third_party/WebKit/Source/devtools/front_end/components/domUtils.css
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
3 files changed, 48 insertions(+), 4 deletions(-)
To view, visit change 874785. To unsubscribe, or for help writing mail filters, visit settings.
Aleksey Kozyatinskiy (Gerrit)
Uploaded better UX and updated screenshot, Dmitry, please take another look.
Aleksey Kozyatinskiy (Gerrit)
Aleksey Kozyatinskiy uploaded patch set #7 to this change.
[DevTools] hide blackboxed frames in stack trace popover
We hide blackboxed frames the same way as in call stack sidebar pane
with Show link to unhide frames.
Screenshots: https://imgur.com/a/DOEt7
Bug:chromium:550453,chromium:740632
Change-Id: I46dc4bcf0ce738a01c3d56870e609f4d1e04f82a
R=lush...@chromium.org
---
M third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js
M third_party/WebKit/Source/devtools/front_end/components/domUtils.css
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
3 files changed, 49 insertions(+), 4 deletions(-)
To view, visit change 874785. To unsubscribe, or for help writing mail filters, visit settings.
Aleksey Kozyatinskiy (Gerrit)
Dmitry, please take another look on screenshots.
Patch set 8:Commit-Queue +1
Aleksey Kozyatinskiy (Gerrit)
Patch set 8:Commit-Queue +2
Commit Bot (Gerrit)
CQ is trying the patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"another ux attempt" https://chromium-review.googlesource.com/c/874785/8
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/874785/8
Bot data: {"action": "start", "triggered_at": "2018-01-22T22:38:08.0Z", "cq_cfg_revision": "a668b5363cd374a29ca0f46124c226e2e2aa21d9", "revision": "c22b082f0f90a5c114984c46142597817b083dc8"}
Commit Bot (Gerrit)
Commit Bot merged this change.
[DevTools] hide blackboxed frames in stack trace popover
We hide blackboxed frames the same way as in call stack sidebar pane
with Show link to unhide frames.
Screenshots: https://imgur.com/a/xKjsJ
R=lush...@chromium.org
Bug: chromium:550453,chromium:740632
Change-Id: I46dc4bcf0ce738a01c3d56870e609f4d1e04f82a
Reviewed-on: https://chromium-review.googlesource.com/874785
Commit-Queue: Aleksey Kozyatinskiy <kozyat...@chromium.org>
Reviewed-by: Andrey Lushnikov <lush...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531094}
---
M third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js
M third_party/WebKit/Source/devtools/front_end/components/domUtils.css
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
M third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
4 files changed, 54 insertions(+), 6 deletions(-)