Add missing ZWNJ to complex-joining-using-gpos.html (issue 1373473002 by drott@chromium.org)

0 views
Skip to first unread message

dr...@chromium.org

unread,
Sep 25, 2015, 5:09:45 AM9/25/15
to beh...@chromium.org, e...@chromium.org, ko...@chromium.org, blink-...@chromium.org
Reviewers: behdad, eae, kojii,

Description:
Add missing ZWNJ to complex-joining-using-gpos.html

Fix the rendering of the test case by avoiding combining the plus sign
with the diacritic with fonts that support it.

BUG=535897
R=eae,kojii,behdad

Please review this at https://codereview.chromium.org/1373473002/

Base URL: https://chromium.googlesource.com/chromium/src.git@master

Affected files (+4, -2 lines):
M third_party/WebKit/LayoutTests/TestExpectations
M
third_party/WebKit/LayoutTests/fast/text/international/complex-joining-using-gpos.html


Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations
b/third_party/WebKit/LayoutTests/TestExpectations
index
5b8a7ad17c9bf603c3321c78451a6489762eec14..2a773598f91f310447d9cae07e177c8039fa47e0
100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -661,6 +661,8 @@ crbug.com/505151
imported/csswg-test/css-writing-modes-3/abs-pos-non-replaced-vr
crbug.com/505151
imported/csswg-test/css-writing-modes-3/abs-pos-non-replaced-vrl-220.xht [
ImageOnlyFailure ]
crbug.com/505151
imported/csswg-test/css-writing-modes-3/abs-pos-non-replaced-vrl-224.xht [
ImageOnlyFailure ]

+crbug.com/535897 [ Mac ]
fast/text/international/complex-joining-using-gpos.html [ NeedsRebaseline ]
+
crbug.com/492664
imported/csswg-test/css-writing-modes-3/inline-block-alignment-003.xht [
ImageOnlyFailure ]
crbug.com/492664
imported/csswg-test/css-writing-modes-3/inline-block-alignment-005.xht [
ImageOnlyFailure ]
crbug.com/492664
imported/csswg-test/css-writing-modes-3/inline-block-alignment-009.xht [
ImageOnlyFailure ]
Index:
third_party/WebKit/LayoutTests/fast/text/international/complex-joining-using-gpos.html
diff --git
a/third_party/WebKit/LayoutTests/fast/text/international/complex-joining-using-gpos.html
b/third_party/WebKit/LayoutTests/fast/text/international/complex-joining-using-gpos.html
index
e3be1ba74c59f2d9e7c304490882cac30295344e..ffc2edef55d15067460d88eeb53191a339f904c6
100644
---
a/third_party/WebKit/LayoutTests/fast/text/international/complex-joining-using-gpos.html
+++
b/third_party/WebKit/LayoutTests/fast/text/international/complex-joining-using-gpos.html
@@ -8,8 +8,8 @@
<p>This pixel test verifies that we position combining characters
properly.</p>

<p>The backslash-looking mark should connect into the the character on the
center, not be positioned off to the side.</p>
-<div class=big>क+े = के</div>
-<div class=med>क+े = के</div>
+<div class="big">क+&zwnj;े = के</div>
+<div class="med">क+&zwnj;े = के</div>

<p>The three words should be separated by spaces, and there should be no
marks above the spaces.</p>


e...@chromium.org

unread,
Sep 25, 2015, 12:18:22 PM9/25/15
to drott...@chromium.org, beh...@chromium.org, ko...@chromium.org, blink-...@chromium.org
LGTM

https://codereview.chromium.org/1373473002/

commit-bot@chromium.org via codereview.chromium.org

unread,
Sep 25, 2015, 1:29:48 PM9/25/15
to drott...@chromium.org, beh...@chromium.org, e...@chromium.org, ko...@chromium.org, commi...@chromium.org, blink-...@chromium.org
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1373473002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1373473002/1


https://codereview.chromium.org/1373473002/

commit-bot@chromium.org via codereview.chromium.org

unread,
Sep 25, 2015, 2:52:12 PM9/25/15
to drott...@chromium.org, beh...@chromium.org, e...@chromium.org, ko...@chromium.org, commi...@chromium.org, blink-...@chromium.org
Try jobs failed on following builders:
linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/118638)

https://codereview.chromium.org/1373473002/

beh...@chromium.org

unread,
Sep 29, 2015, 10:56:46 AM9/29/15
to drott...@chromium.org, e...@chromium.org, ko...@chromium.org, blink-...@chromium.org
Technically there's no guarantee that your fix works. In fact, if we do
everything right, it shouldn't! You probably want a &nbsp; as the base for
the
mark, NOT a &zwnj;.

https://codereview.chromium.org/1373473002/

dr...@chromium.org

unread,
Sep 29, 2015, 1:34:42 PM9/29/15
to beh...@chromium.org, e...@chromium.org, ko...@chromium.org, blink-...@chromium.org
On 2015/09/29 14:56:46, behdad wrote:
> Technically there's no guarantee that your fix works. In fact, if we do
> everything right, it shouldn't! You probably want a &nbsp; as the base
> for
the
> mark, NOT a &zwnj;.

Thanks - yes, I was considering a &nbsp; and probably I had a misconception
about the &zwnj; use. I'll update.

https://codereview.chromium.org/1373473002/

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2015, 7:17:10 AM10/1/15
to drott...@chromium.org, beh...@chromium.org, e...@chromium.org, ko...@chromium.org, commi...@chromium.org, blink-...@chromium.org
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1373473002/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1373473002/20001


https://codereview.chromium.org/1373473002/

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 1, 2015, 8:37:05 AM10/1/15
to drott...@chromium.org, beh...@chromium.org, e...@chromium.org, ko...@chromium.org, commi...@chromium.org, blink-...@chromium.org
Try jobs failed on following builders:
linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/121000)

https://codereview.chromium.org/1373473002/

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 5, 2015, 4:42:32 AM10/5/15
to drott...@chromium.org, beh...@chromium.org, e...@chromium.org, ko...@chromium.org, commi...@chromium.org, blink-...@chromium.org
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1373473002/40001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1373473002/40001


https://codereview.chromium.org/1373473002/

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 5, 2015, 5:41:03 AM10/5/15
to drott...@chromium.org, beh...@chromium.org, e...@chromium.org, ko...@chromium.org, commi...@chromium.org, blink-...@chromium.org
Try jobs failed on following builders:
win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/116319)

https://codereview.chromium.org/1373473002/

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 5, 2015, 5:41:45 AM10/5/15
to drott...@chromium.org, beh...@chromium.org, e...@chromium.org, ko...@chromium.org, commi...@chromium.org, blink-...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 5, 2015, 6:14:07 AM10/5/15
to drott...@chromium.org, beh...@chromium.org, e...@chromium.org, ko...@chromium.org, commi...@chromium.org, blink-...@chromium.org
Try jobs failed on following builders:
mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/122006)

https://codereview.chromium.org/1373473002/

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 5, 2015, 6:15:03 AM10/5/15
to drott...@chromium.org, beh...@chromium.org, e...@chromium.org, ko...@chromium.org, commi...@chromium.org, blink-...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 5, 2015, 6:50:05 AM10/5/15
to drott...@chromium.org, beh...@chromium.org, e...@chromium.org, ko...@chromium.org, commi...@chromium.org, blink-...@chromium.org
Try jobs failed on following builders:
mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/122018)

https://codereview.chromium.org/1373473002/

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 7, 2015, 8:52:27 AM10/7/15
to drott...@chromium.org, beh...@chromium.org, e...@chromium.org, ko...@chromium.org, commi...@chromium.org, blink-...@chromium.org
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1373473002/60001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1373473002/60001


https://codereview.chromium.org/1373473002/

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 7, 2015, 10:26:03 AM10/7/15
to drott...@chromium.org, beh...@chromium.org, e...@chromium.org, ko...@chromium.org, commi...@chromium.org, blink-...@chromium.org
Committed patchset #4 (id:60001)

https://codereview.chromium.org/1373473002/

commit-bot@chromium.org via codereview.chromium.org

unread,
Oct 7, 2015, 10:27:25 AM10/7/15
to drott...@chromium.org, beh...@chromium.org, e...@chromium.org, ko...@chromium.org, commi...@chromium.org, blink-...@chromium.org
Patchset 4 (id:??) landed as
https://crrev.com/94fbc0d481b8e55c2544e859774c438798280384
Cr-Commit-Position: refs/heads/master@{#352833}

https://codereview.chromium.org/1373473002/
Reply all
Reply to author
Forward
0 new messages