Fix compositing/overflow/do-not-repaint-if-scrolling-composited-layers.html [chromium/src : master]

0 views
Skip to first unread message

Xianzhu Wang (Gerrit)

unread,
Oct 18, 2017, 8:39:33 PM10/18/17
to blink-...@chromium.org, Stephen Chenney, Commit Bot, chromium...@chromium.org

This change is ready for review.

View Change

    To view, visit change 726974. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: master
    Gerrit-MessageType: comment
    Gerrit-Change-Id: Icc051f653baca28de6e4c4094525bd4efd4eb2de
    Gerrit-Change-Number: 726974
    Gerrit-PatchSet: 1
    Gerrit-Owner: Xianzhu Wang <wangx...@chromium.org>
    Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
    Gerrit-Reviewer: Xianzhu Wang <wangx...@chromium.org>
    Gerrit-CC: Commit Bot <commi...@chromium.org>
    Gerrit-Comment-Date: Thu, 19 Oct 2017 00:39:28 +0000
    Gerrit-HasComments: No
    Gerrit-HasLabels: No

    Stephen Chenney (Gerrit)

    unread,
    Oct 19, 2017, 8:51:45 AM10/19/17
    to Xianzhu Wang, blink-...@chromium.org, Commit Bot, chromium...@chromium.org

    Thanks for helping reduce test expectations.

    Patch set 4:Code-Review +1

    View Change

      To view, visit change 726974. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: master
      Gerrit-MessageType: comment
      Gerrit-Change-Id: Icc051f653baca28de6e4c4094525bd4efd4eb2de
      Gerrit-Change-Number: 726974
      Gerrit-PatchSet: 4
      Gerrit-Owner: Xianzhu Wang <wangx...@chromium.org>
      Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
      Gerrit-Reviewer: Xianzhu Wang <wangx...@chromium.org>
      Gerrit-CC: Commit Bot <commi...@chromium.org>
      Gerrit-Comment-Date: Thu, 19 Oct 2017 12:51:40 +0000
      Gerrit-HasComments: No
      Gerrit-HasLabels: Yes

      Xianzhu Wang (Gerrit)

      unread,
      Oct 19, 2017, 12:10:50 PM10/19/17
      to blink-...@chromium.org, Stephen Chenney, Commit Bot, chromium...@chromium.org

      Patch set 4:Commit-Queue +2

      View Change

        To view, visit change 726974. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: master
        Gerrit-MessageType: comment
        Gerrit-Change-Id: Icc051f653baca28de6e4c4094525bd4efd4eb2de
        Gerrit-Change-Number: 726974
        Gerrit-PatchSet: 4
        Gerrit-Owner: Xianzhu Wang <wangx...@chromium.org>
        Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
        Gerrit-Reviewer: Xianzhu Wang <wangx...@chromium.org>
        Gerrit-CC: Commit Bot <commi...@chromium.org>
        Gerrit-Comment-Date: Thu, 19 Oct 2017 16:10:45 +0000
        Gerrit-HasComments: No
        Gerrit-HasLabels: Yes

        Commit Bot (Gerrit)

        unread,
        Oct 19, 2017, 12:27:39 PM10/19/17
        to Xianzhu Wang, blink-...@chromium.org, Stephen Chenney, chromium...@chromium.org

        Commit Bot merged this change.

        View Change

        Approvals: Stephen Chenney: Looks good to me Xianzhu Wang: Commit
        Fix compositing/overflow/do-not-repaint-if-scrolling-composited-layers.html

        The test was broken because of changed layer tree dump format.
        Updated according to the current format and composited scrolling
        behavior.

        Bug: 639427
        Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
        Change-Id: Icc051f653baca28de6e4c4094525bd4efd4eb2de
        Reviewed-on: https://chromium-review.googlesource.com/726974
        Reviewed-by: Stephen Chenney <sche...@chromium.org>
        Commit-Queue: Xianzhu Wang <wangx...@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#510104}
        ---
        M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
        M third_party/WebKit/LayoutTests/compositing/overflow/do-not-repaint-if-scrolling-composited-layers-expected.txt
        M third_party/WebKit/LayoutTests/compositing/overflow/do-not-repaint-if-scrolling-composited-layers.html
        3 files changed, 73 insertions(+), 113 deletions(-)


        To view, visit change 726974. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: master
        Gerrit-MessageType: merged
        Gerrit-Change-Id: Icc051f653baca28de6e4c4094525bd4efd4eb2de
        Gerrit-Change-Number: 726974
        Gerrit-PatchSet: 5
        Gerrit-Owner: Xianzhu Wang <wangx...@chromium.org>
        Gerrit-Reviewer: Commit Bot <commi...@chromium.org>
        Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
        Gerrit-Reviewer: Xianzhu Wang <wangx...@chromium.org>
        Reply all
        Reply to author
        Forward
        0 new messages