Re-enable deep query-selector PerformanceTests (issue 1880383002 by ericwilligers@chromium.org)

ericwi...@chromium.org

unread,

Jun 29, 2016, 2:11:47 AM6/29/16

to alanc...@chromium.org, blink-...@chromium.org, chromium...@chromium.org

Reviewers: alancutter
CL: https://codereview.chromium.org/1880383002/

Description:
Re-enable deep query-selector PerformanceTests

Reduce the depth used by PerformanceTests/Parser/
query-selector-deep.html and query-selector-id-deep.html

These performance tests have been disabled since June 2013 as they were
observed to crash "on 6 of the last 9 runs"

BUG=245702

Base URL: https://chromium.googlesource.com/chromium/src.git@master

Affected files (+3, -7 lines):
M third_party/WebKit/PerformanceTests/Parser/query-selector-deep.html
M third_party/WebKit/PerformanceTests/Parser/query-selector-id-deep.html
M third_party/WebKit/PerformanceTests/Skipped

Index: third_party/WebKit/PerformanceTests/Parser/query-selector-deep.html
diff --git a/third_party/WebKit/PerformanceTests/Parser/query-selector-deep.html b/third_party/WebKit/PerformanceTests/Parser/query-selector-deep.html
index 605355f53762e40f7cd16e0cbc9b9d9de51b6c9b..e0a10b9c3cbca30f97285d93a06e687626f38115 100644
--- a/third_party/WebKit/PerformanceTests/Parser/query-selector-deep.html
+++ b/third_party/WebKit/PerformanceTests/Parser/query-selector-deep.html
@@ -4,7 +4,7 @@
<script src="../resources/runner.js"></script>
<script>
var parentDiv = document.body;
-for (var i = 0; i < 1000; i++) {
+for (var i = 0; i < 100; i++) {
var div = document.createElement("div");
div.id = "foo" + i;
div.className = "bar" + i;
Index: third_party/WebKit/PerformanceTests/Parser/query-selector-id-deep.html
diff --git a/third_party/WebKit/PerformanceTests/Parser/query-selector-id-deep.html b/third_party/WebKit/PerformanceTests/Parser/query-selector-id-deep.html
index 3b9fc1aa75ab8732f238dac65af46c8e8fdd17d7..51f4e829d6bb5ead19d7bad5644636066ff4a8f5 100644
--- a/third_party/WebKit/PerformanceTests/Parser/query-selector-id-deep.html
+++ b/third_party/WebKit/PerformanceTests/Parser/query-selector-id-deep.html
@@ -4,7 +4,7 @@
<script src="../resources/runner.js"></script>
<script>
var parentDiv = document.body;
-for (var i = 0; i < 1000; i++) {
+for (var i = 0; i < 100; i++) {
var div = document.createElement("div");
div.id = "foo" + i;
div.className = "bar" + i;
@@ -21,7 +21,7 @@ PerfTestRunner.measureRunsPerSecond({
description: "This benchmark tests querySelector() for an element that appears in the depths in the document, and is a descendant of an element with a given id",
run: function() {
for (var i = 0; i < 100; i++) {
- var res = document.querySelector("#foo998 h1");
+ var res = document.querySelector("#foo98 h1");
}
}});
</script>
Index: third_party/WebKit/PerformanceTests/Skipped
diff --git a/third_party/WebKit/PerformanceTests/Skipped b/third_party/WebKit/PerformanceTests/Skipped
index 8eec9a452d906b7691ad66980687950e4374cf58..c6d285bf8ce87849fc737cd3a00d17dfff6e1b28 100644
--- a/third_party/WebKit/PerformanceTests/Skipped
+++ b/third_party/WebKit/PerformanceTests/Skipped
@@ -39,10 +39,6 @@ Replay
# Requires manual intervention.
Bindings/event-target-wrapper.html

-# Crashy, crbug.com/245702
-Parser/query-selector-deep.html
-Parser/query-selector-id-deep.html
-
# Microbenchmark that we aren't interested in monitoring.
Bindings/gc-forest.html
Bindings/gc-mini-tree.html

alanc...@chromium.org

unread,

Jun 30, 2016, 12:32:39 AM6/30/16

to ericwi...@chromium.org, blink-...@chromium.org, chromium...@chromium.org

lgtm

https://codereview.chromium.org/1880383002/