[Payment Request] Remove PaymentAddress.languageCode. [chromium/src : master]

Rouslan Solomakhin (Gerrit)

no leída,

13 feb 2019, 12:59:46 p.m.13/2/19

para Danyao Wang,anthonyvd+p...@chromium.org,blink-...@chromium.org,gogerald+pa...@chromium.org,ios-revie...@chromium.org,ios-r...@chromium.org,ipc-securi...@chromium.org,jmedle...@chromium.org,mahmadi+paym...@chromium.org,mahmadi+pa...@chromium.org,marq+...@chromium.org,rouslan+...@chromium.org

Rouslan Solomakhin would like Danyao Wang to review this change.

View Change

[Payment Request] Remove PaymentAddress.languageCode.

Intent to deprecate:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/ma2J2RumrmM/nmhnTmB5CAAJ
(Consensus on the thread is that removal is OK.)

Chrome status dashboard entry:
https://www.chromestatus.com/feature/4992562146312192

Bug: 877521
Change-Id: I5dc1cce6d313f2b4138b784899cff00078ee2abe
---
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
M chrome/browser/ui/views/payments/payment_request_payment_response_browsertest.cc
M components/payments/content/payment_request_state_unittest.cc
M components/payments/content/payment_response_helper_unittest.cc
M components/payments/core/payment_address.cc
M components/payments/core/payment_address_unittest.cc
M components/payments/core/payment_request_data_util.cc
M components/payments/core/payment_request_data_util_unittest.cc
M components/payments/core/payments_validators.cc
M components/payments/core/payments_validators.h
M components/payments/core/payments_validators_unittest.cc
M components/payments/mojom/payment_request_data.mojom
M ios/chrome/browser/payments/payment_request_util_unittest.mm
M ios/chrome/browser/payments/payment_response_helper_unittest.mm
M ios/chrome/browser/ui/payments/payment_request_payment_response_egtest.mm
M ios/chrome/browser/web/resources/payment_request.js
M third_party/blink/renderer/modules/payments/address_errors.idl
M third_party/blink/renderer/modules/payments/on_payment_response_test.cc
M third_party/blink/renderer/modules/payments/payment_address.cc
M third_party/blink/renderer/modules/payments/payment_address.h
M third_party/blink/renderer/modules/payments/payment_address.idl
M third_party/blink/renderer/modules/payments/payment_address_test.cc
M third_party/blink/renderer/modules/payments/payment_request.cc
M third_party/blink/renderer/modules/payments/payment_response_test.cc
M third_party/blink/renderer/modules/payments/payments_validators.cc
M third_party/blink/renderer/modules/payments/payments_validators.h
M third_party/blink/renderer/modules/payments/payments_validators_test.cc
28 files changed, 22 insertions(+), 445 deletions(-)

To view, visit change 1464225. To unsubscribe, or for help writing mail filters, visit settings.

Rouslan Solomakhin (Gerrit)

no leída,

13 feb 2019, 12:59:48 p.m.13/2/19

para anthonyvd+p...@chromium.org,blink-...@chromium.org,gogerald+pa...@chromium.org,ios-revie...@chromium.org,ios-r...@chromium.org,ipc-securi...@chromium.org,jmedle...@chromium.org,mahmadi+paym...@chromium.org,mahmadi+pa...@chromium.org,marq+...@chromium.org,rouslan+...@chromium.org,Danyao Wang,Commit Bot,chromium...@chromium.org,Darin Fisher,Kentaro Hara

Danyao, PTAL.

View Change

To view, visit change 1464225. To unsubscribe, or for help writing mail filters, visit settings.

Danyao Wang (Gerrit)

no leída,

13 feb 2019, 1:12:38 p.m.13/2/19

para Rouslan Solomakhin,anthonyvd+p...@chromium.org,blink-...@chromium.org,gogerald+pa...@chromium.org,ios-revie...@chromium.org,ios-r...@chromium.org,ipc-securi...@chromium.org,jmedle...@chromium.org,mahmadi+paym...@chromium.org,mahmadi+pa...@chromium.org,marq+...@chromium.org,rouslan+...@chromium.org,Commit Bot,chromium...@chromium.org,Darin Fisher,Kentaro Hara

LGTM!

Patch set 5:Code-Review +1

View Change

To view, visit change 1464225. To unsubscribe, or for help writing mail filters, visit settings.

Rouslan Solomakhin (Gerrit)

no leída,

13 feb 2019, 2:57:09 p.m.13/2/19

para blink-revie...@chromium.org,anthonyvd+p...@chromium.org,blink-...@chromium.org,gogerald+pa...@chromium.org,ios-revie...@chromium.org,ios-r...@chromium.org,ipc-securi...@chromium.org,jmedle...@chromium.org,mahmadi+paym...@chromium.org,mahmadi+pa...@chromium.org,marq+...@chromium.org,rouslan+...@chromium.org,Tom Sepez,Danyao Wang,Commit Bot,chromium...@chromium.org,Darin Fisher,Kentaro Hara

Tom, security owners PTAL:

components/payments/mojom/payment_request_data.mojom

View Change

To view, visit change 1464225. To unsubscribe, or for help writing mail filters, visit settings.

Rouslan Solomakhin (Gerrit)

no leída,

13 feb 2019, 2:57:56 p.m.13/2/19

para blink-revie...@chromium.org,anthonyvd+p...@chromium.org,blink-...@chromium.org,gogerald+pa...@chromium.org,ios-revie...@chromium.org,ios-r...@chromium.org,ipc-securi...@chromium.org,jmedle...@chromium.org,mahmadi+paym...@chromium.org,mahmadi+pa...@chromium.org,marq+...@chromium.org,rouslan+...@chromium.org,Moe Ahmadi,Tom Sepez,Danyao Wang,Commit Bot,chromium...@chromium.org,Darin Fisher,Kentaro Hara

Moe, owners PTAL ios/*

View Change

To view, visit change 1464225. To unsubscribe, or for help writing mail filters, visit settings.

Tom Sepez (Gerrit)

no leída,

13 feb 2019, 3:02:46 p.m.13/2/19

para Rouslan Solomakhin,blink-revie...@chromium.org,anthonyvd+p...@chromium.org,blink-...@chromium.org,gogerald+pa...@chromium.org,ios-revie...@chromium.org,ios-r...@chromium.org,ipc-securi...@chromium.org,jmedle...@chromium.org,mahmadi+paym...@chromium.org,mahmadi+pa...@chromium.org,marq+...@chromium.org,rouslan+...@chromium.org,Moe Ahmadi,Danyao Wang,Commit Bot,chromium...@chromium.org,Darin Fisher,Kentaro Hara

OWNERS stamp.

Patch set 6:Code-Review +1

View Change

To view, visit change 1464225. To unsubscribe, or for help writing mail filters, visit settings.

Moe Ahmadi (Gerrit)

no leída,

15 feb 2019, 10:19:42 a.m.15/2/19

para Rouslan Solomakhin,blink-revie...@chromium.org,anthonyvd+p...@chromium.org,blink-...@chromium.org,gogerald+pa...@chromium.org,ios-revie...@chromium.org,ios-r...@chromium.org,ipc-securi...@chromium.org,jmedle...@chromium.org,mahmadi+paym...@chromium.org,mahmadi+pa...@chromium.org,marq+...@chromium.org,rouslan+...@chromium.org,Tom Sepez,Danyao Wang,Commit Bot,chromium...@chromium.org,Darin Fisher,Kentaro Hara

LGTM

Patch set 6:Code-Review +1

View Change

To view, visit change 1464225. To unsubscribe, or for help writing mail filters, visit settings.

Rouslan Solomakhin (Gerrit)

no leída,

15 feb 2019, 10:20:20 a.m.15/2/19

para blink-revie...@chromium.org,anthonyvd+p...@chromium.org,blink-...@chromium.org,gogerald+pa...@chromium.org,ios-revie...@chromium.org,ios-r...@chromium.org,ipc-securi...@chromium.org,jmedle...@chromium.org,mahmadi+paym...@chromium.org,mahmadi+pa...@chromium.org,marq+...@chromium.org,rouslan+...@chromium.org,Moe Ahmadi,Tom Sepez,Danyao Wang,Commit Bot,chromium...@chromium.org,Darin Fisher,Kentaro Hara

Patch set 6:Commit-Queue +2

View Change

To view, visit change 1464225. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

no leída,

15 feb 2019, 10:37:40 a.m.15/2/19

para Rouslan Solomakhin,blink-revie...@chromium.org,anthonyvd+p...@chromium.org,blink-...@chromium.org,gogerald+pa...@chromium.org,ios-revie...@chromium.org,ios-r...@chromium.org,ipc-securi...@chromium.org,jmedle...@chromium.org,mahmadi+paym...@chromium.org,mahmadi+pa...@chromium.org,marq+...@chromium.org,rouslan+...@chromium.org,Moe Ahmadi,Tom Sepez,Danyao Wang,chromium...@chromium.org,Darin Fisher,Kentaro Hara

Try jobs failed on following builders:
  chromium_presubmit on luci.chromium.try (JOB_FAILED, https://ci.chromium.org/b/8921444824897146240)

View Change

To view, visit change 1464225. To unsubscribe, or for help writing mail filters, visit settings.

Rouslan Solomakhin (Gerrit)

no leída,

15 feb 2019, 10:41:58 a.m.15/2/19

para blink-revie...@chromium.org,anthonyvd+p...@chromium.org,blink-...@chromium.org,gogerald+pa...@chromium.org,ios-revie...@chromium.org,ios-r...@chromium.org,ipc-securi...@chromium.org,jmedle...@chromium.org,mahmadi+paym...@chromium.org,mahmadi+pa...@chromium.org,marq+...@chromium.org,rouslan+...@chromium.org,Chris Harrelson,Moe Ahmadi,Tom Sepez,Danyao Wang,Commit Bot,chromium...@chromium.org,Darin Fisher,Kentaro Hara

Chris: Blink API owners PTAL.

View Change

To view, visit change 1464225. To unsubscribe, or for help writing mail filters, visit settings.

Chris Harrelson (Gerrit)

no leída,

15 feb 2019, 12:32:20 p.m.15/2/19

para Rouslan Solomakhin,blink-revie...@chromium.org,anthonyvd+p...@chromium.org,blink-...@chromium.org,gogerald+pa...@chromium.org,ios-revie...@chromium.org,ios-r...@chromium.org,ipc-securi...@chromium.org,jmedle...@chromium.org,mahmadi+paym...@chromium.org,mahmadi+pa...@chromium.org,marq+...@chromium.org,rouslan+...@chromium.org,Moe Ahmadi,Tom Sepez,Danyao Wang,Commit Bot,chromium...@chromium.org,Darin Fisher,Kentaro Hara

Patch set 6:Code-Review +1

View Change

To view, visit change 1464225. To unsubscribe, or for help writing mail filters, visit settings.

Rouslan Solomakhin (Gerrit)

no leída,

15 feb 2019, 3:53:02 p.m.15/2/19

para blink-revie...@chromium.org,anthonyvd+p...@chromium.org,blink-...@chromium.org,gogerald+pa...@chromium.org,ios-revie...@chromium.org,ios-r...@chromium.org,ipc-securi...@chromium.org,jmedle...@chromium.org,mahmadi+paym...@chromium.org,mahmadi+pa...@chromium.org,marq+...@chromium.org,rouslan+...@chromium.org,Chris Harrelson,Moe Ahmadi,Tom Sepez,Danyao Wang,Commit Bot,chromium...@chromium.org,Darin Fisher,Kentaro Hara

Patch set 6:Commit-Queue +2

View Change

To view, visit change 1464225. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

no leída,

15 feb 2019, 3:56:08 p.m.15/2/19

para Rouslan Solomakhin,blink-revie...@chromium.org,anthonyvd+p...@chromium.org,blink-...@chromium.org,gogerald+pa...@chromium.org,ios-revie...@chromium.org,ios-r...@chromium.org,ipc-securi...@chromium.org,jmedle...@chromium.org,mahmadi+paym...@chromium.org,mahmadi+pa...@chromium.org,marq+...@chromium.org,rouslan+...@chromium.org,Chris Harrelson,Moe Ahmadi,Tom Sepez,Danyao Wang,chromium...@chromium.org,Darin Fisher,Kentaro Hara

Commit Bot merged this change.

View Change

Approvals:
  Chris Harrelson: Looks good to me
  Tom Sepez: Looks good to me
  Moe Ahmadi: Looks good to me
  Danyao Wang: Looks good to me
  Rouslan Solomakhin: Commit

[Payment Request] Remove PaymentAddress.languageCode.

Intent to deprecate:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/ma2J2RumrmM/nmhnTmB5CAAJ
(Consensus on the thread is that removal is OK.)

Chrome status dashboard entry:
https://www.chromestatus.com/feature/4992562146312192

Bug: 877521
Change-Id: I5dc1cce6d313f2b4138b784899cff00078ee2abe

Reviewed-on: https://chromium-review.googlesource.com/c/1464225
Reviewed-by: Tom Sepez <tse...@chromium.org>
Reviewed-by: Moe Ahmadi <mah...@chromium.org>
Reviewed-by: Chris Harrelson <chri...@chromium.org>
Reviewed-by: Danyao Wang <dan...@chromium.org>
Commit-Queue: Rouslan Solomakhin <rou...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632757}

D third_party/blink/web_tests/external/wpt/payment-request/historical.https-expected.txt
M third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt
M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
31 files changed, 22 insertions(+), 459 deletions(-)

To view, visit change 1464225. To unsubscribe, or for help writing mail filters, visit settings.

Responder a todos

Responder al autor

Reenviar