Remove the dependency on CSSInterpolationTypes from PropertyRegistration [chromium/src : master]
Alan Cutter (Gerrit)
Alan Cutter uploaded patch set #4 to this change.
Remove the dependency on CSSInterpolationTypes from PropertyRegistration
The existing construction code for PropertyRegistration required that
every InterpolationType was a CSSInterpolationType so that the
PropertyRegistration object could pass a reference to itself to the
CSSInterpolationTypes.
This change has the PropertyRegistration pass the reference to itself
to CreateInterpolationTypesForSyntax() so it can pass it in the
constructor parameters for specific CSSInterpolationTypes.
This allows CreateInterpolationTypesForSyntax() to return
InterpolationTypes that don't inherit from CSSInterpolationType
removing a prohibitive constraint that's getting in the way of
implementing var() reference cycle detection for animations.
This patch is a refactor and introduces no changes in behaviour.
Bug: 671904
Change-Id: I38f99c769c72711deec16e0330d5c92bbd39b7e8
---
M third_party/WebKit/Source/core/animation/CSSAngleInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSClipInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSColorInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSFilterListInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSFontVariationSettingsInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSImageInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSImageSliceInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp
M third_party/WebKit/Source/core/animation/CSSInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp
M third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.h
M third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp
M third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp
M third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSLengthPairInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSOffsetRotateInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSPathInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSPositionAxisListInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSPositionInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSResolutionInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSSizeListInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSTimeInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSTransformOriginInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSValueInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.h
M third_party/WebKit/Source/core/css/PropertyRegistration.cpp
M third_party/WebKit/Source/core/css/PropertyRegistration.h
M third_party/WebKit/Source/core/css/PropertyRegistry.cpp
M third_party/WebKit/Source/core/css/PropertyRegistry.h
43 files changed, 168 insertions(+), 142 deletions(-)
To view, visit change 538443. To unsubscribe, visit settings.
Alan Cutter (Gerrit)
Alan Cutter would like Eric Willigers to review this change.
Alan Cutter (Gerrit)
Alan Cutter uploaded patch set #6 to this change.
Remove the dependency on CSSInterpolationTypes from PropertyRegistration
The existing construction code for PropertyRegistration required that
every InterpolationType was a CSSInterpolationType so that the
PropertyRegistration object could pass a reference to itself to the
CSSInterpolationTypes via the
CSSInterpolationType::SetCustomPropertyRegistration() method.
This change has the PropertyRegistration pass the reference to itself
to CreateInterpolationTypesForSyntax() so it can pass it in the
constructor parameters for specific CSSInterpolationTypes instead of
using SetCustomPropertyRegistration() to make the association between
the two objects.
Bugs Nash (Gerrit)
Bugs Nash posted comments on this change.
Patch set 7:
I'm not familiar with this code so I may be off with my interpretation here, but from what i can see it seems like:
previously: PropertyRegistration had an InterpolationTypes member, but it was always a CSSInterpolationTypes (I don't know why the member wasn't of CSSInterpolationTypes type to be more clear?)
with this patch: PropertyRegistration has an InterpolationTypes member that is always an InterpolationTypes, but the InterpolationType objects inside this vector are always of CSSInterpolationType. Again, I feel like it's clearer to just have CSSInterpolationTypes as the type?
what exactly about CSSInterpolationTypes is blocking you from implementiong var() reference cycle detection for animations?
Bugs Nash (Gerrit)
(3 comments)
File third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp:
Patch Set #7, Line 102:
const PropertyRegistration* registration)why not have this PropertyRegistration default to nullptr too rather than adding nullptr passes to heaps of sub classes?
File third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.h:
Patch Set #7, Line 25:
static InterpolationTypes CreateInterpolationTypesForSyntax(perhaps CreateInterpolationTypesForCSSSyntax? at first this read to me like it should be moved to InterpolationTypesMap.
File third_party/WebKit/Source/core/css/PropertyRegistration.cpp:
Patch Set #7, Line 145:
registry.RegisterProperty(yas removing duplicate code
To view, visit change 538443. To unsubscribe, visit settings.
Alan Cutter (Gerrit)
Alan Cutter posted comments on this change.
Patch set 7:
what exactly about CSSInterpolationTypes is blocking you from implementiong var() reference cycle detection for animations?
CSSInterpolationType has a ton of code that doesn't always apply in every case. I want the flexibility to have classes without code that doesn't apply to them in these vectors.
Alan Cutter (Gerrit)
(3 comments)
Patch Set #7, Line 102:
const PropertyRegistration* registration)why not have this PropertyRegistration default to nullptr too rather than a
Somehow I didn't realise this was a possibility, thanks!
File third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.h:
Patch Set #7, Line 25:
static InterpolationTypes CreateInterpolationTypesForSyntax(perhaps CreateInterpolationTypesForCSSSyntax? at first this read to me like
Much better name.
File third_party/WebKit/Source/core/css/PropertyRegistration.cpp:
Patch Set #7, Line 145:
registry.RegisterProperty(yas removing duplicate code
Yasyasyaysayapyapyapyapyyapyapapap.
To view, visit change 538443. To unsubscribe, visit settings.
Bugs Nash (Gerrit)
Bugs Nash posted comments on this change.
Patch set 8:Code-Review +1
Alan Cutter (Gerrit)
Alan Cutter posted comments on this change.
Patch set 8:Commit-Queue +2
Commit Bot (Gerrit)
Commit Bot merged this change.
Remove the dependency on CSSInterpolationTypes from PropertyRegistration
The existing construction code for PropertyRegistration required that
every InterpolationType was a CSSInterpolationType so that the
PropertyRegistration object could pass a reference to itself to the
CSSInterpolationTypes via the
CSSInterpolationType::SetCustomPropertyRegistration() method.
This change has the PropertyRegistration pass the reference to itself
to CreateInterpolationTypesForSyntax() so it can pass it in the
constructor parameters for specific CSSInterpolationTypes instead of
using SetCustomPropertyRegistration() to make the association between
the two objects.
This allows CreateInterpolationTypesForSyntax() to return
InterpolationTypes that don't inherit from CSSInterpolationType
removing a prohibitive constraint that's getting in the way of
implementing var() reference cycle detection for animations.
This patch is a refactor and introduces no changes in behaviour.
Bug: 671904
Change-Id: I38f99c769c72711deec16e0330d5c92bbd39b7e8
Reviewed-on: https://chromium-review.googlesource.com/538443
Reviewed-by: Bugs Nash <bugs...@chromium.org>
Commit-Queue: Alan Cutter <alanc...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482210}
---
M third_party/WebKit/Source/core/animation/CSSAngleInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSColorInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp
M third_party/WebKit/Source/core/animation/CSSInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp
M third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.h
M third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp
M third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSResolutionInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSTimeInterpolationType.h
M third_party/WebKit/Source/core/animation/CSSValueInterpolationType.h
M third_party/WebKit/Source/core/css/PropertyRegistration.cpp
M third_party/WebKit/Source/core/css/PropertyRegistration.h
M third_party/WebKit/Source/core/css/PropertyRegistry.cpp
M third_party/WebKit/Source/core/css/PropertyRegistry.h
16 files changed, 75 insertions(+), 93 deletions(-)