Roll SwiftShader e8d42ae..0def102 [chromium/src : master]

1 view
Skip to first unread message

Alexis Hétu (Gerrit)

unread,
Aug 17, 2017, 2:48:47 PM8/17/17
to blink-...@chromium.org, Commit Bot, Kenneth Russell, chromium...@chromium.org

This change is ready for review.

View Change

    To view, visit change 619494. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: master
    Gerrit-MessageType: comment
    Gerrit-Change-Id: Iedce552dd4f92e2fcbfcd2ba2e4ffba81865d9b6
    Gerrit-Change-Number: 619494
    Gerrit-PatchSet: 1
    Gerrit-Owner: Alexis Hétu <su...@chromium.org>
    Gerrit-Reviewer: Alexis Hétu <su...@chromium.org>
    Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
    Gerrit-CC: Commit Bot <commi...@chromium.org>
    Gerrit-Comment-Date: Thu, 17 Aug 2017 18:48:42 +0000
    Gerrit-HasComments: No
    Gerrit-HasLabels: No

    Kenneth Russell (Gerrit)

    unread,
    Aug 17, 2017, 3:06:45 PM8/17/17
    to Alexis Hétu, blink-...@chromium.org, Commit Bot, chromium...@chromium.org

    lgtm

    Patch set 1:Code-Review +1

    View Change

      To view, visit change 619494. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: master
      Gerrit-MessageType: comment
      Gerrit-Change-Id: Iedce552dd4f92e2fcbfcd2ba2e4ffba81865d9b6
      Gerrit-Change-Number: 619494
      Gerrit-PatchSet: 1
      Gerrit-Owner: Alexis Hétu <su...@chromium.org>
      Gerrit-Reviewer: Alexis Hétu <su...@chromium.org>
      Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
      Gerrit-CC: Commit Bot <commi...@chromium.org>
      Gerrit-Comment-Date: Thu, 17 Aug 2017 19:06:42 +0000
      Gerrit-HasComments: No
      Gerrit-HasLabels: Yes

      Alexis Hétu (Gerrit)

      unread,
      Aug 17, 2017, 9:48:17 PM8/17/17
      to blink-...@chromium.org, Kenneth Russell, Commit Bot, chromium...@chromium.org

      Self-approving for TBR

      View Change

        To view, visit change 619494. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: master
        Gerrit-MessageType: comment
        Gerrit-Change-Id: Iedce552dd4f92e2fcbfcd2ba2e4ffba81865d9b6
        Gerrit-Change-Number: 619494
        Gerrit-PatchSet: 2
        Gerrit-Owner: Alexis Hétu <su...@chromium.org>
        Gerrit-Reviewer: Alexis Hétu <su...@chromium.org>
        Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
        Gerrit-CC: Commit Bot <commi...@chromium.org>
        Gerrit-Comment-Date: Fri, 18 Aug 2017 01:48:13 +0000
        Gerrit-HasComments: No
        Gerrit-HasLabels: No

        Alexis Hétu (Gerrit)

        unread,
        Aug 17, 2017, 10:12:50 PM8/17/17
        to blink-...@chromium.org, Kenneth Russell, Commit Bot, chromium...@chromium.org

        Self-approving for TBR

        View Change

          To view, visit change 619494. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Project: chromium/src
          Gerrit-Branch: master
          Gerrit-MessageType: comment
          Gerrit-Change-Id: Iedce552dd4f92e2fcbfcd2ba2e4ffba81865d9b6
          Gerrit-Change-Number: 619494
          Gerrit-PatchSet: 3
          Gerrit-Owner: Alexis Hétu <su...@chromium.org>
          Gerrit-Reviewer: Alexis Hétu <su...@chromium.org>
          Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
          Gerrit-CC: Commit Bot <commi...@chromium.org>
          Gerrit-Comment-Date: Fri, 18 Aug 2017 02:12:42 +0000
          Gerrit-HasComments: No
          Gerrit-HasLabels: No

          Alexis Hétu (Gerrit)

          unread,
          Aug 17, 2017, 11:43:20 PM8/17/17
          to blink-...@chromium.org, Kenneth Russell, Commit Bot, chromium...@chromium.org

          Self-approving for TBR

          View Change

            To view, visit change 619494. To unsubscribe, or for help writing mail filters, visit settings.

            Gerrit-Project: chromium/src
            Gerrit-Branch: master
            Gerrit-MessageType: comment
            Gerrit-Change-Id: Iedce552dd4f92e2fcbfcd2ba2e4ffba81865d9b6
            Gerrit-Change-Number: 619494
            Gerrit-PatchSet: 4
            Gerrit-Owner: Alexis Hétu <su...@chromium.org>
            Gerrit-Reviewer: Alexis Hétu <su...@chromium.org>
            Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
            Gerrit-CC: Commit Bot <commi...@chromium.org>
            Gerrit-Comment-Date: Fri, 18 Aug 2017 03:43:17 +0000
            Gerrit-HasComments: No
            Gerrit-HasLabels: No

            Alexis Hétu (Gerrit)

            unread,
            Aug 18, 2017, 8:18:41 AM8/18/17
            to blink-...@chromium.org, Kenneth Russell, Commit Bot, chromium...@chromium.org

            Patch set 4:Commit-Queue +2

            View Change

              To view, visit change 619494. To unsubscribe, or for help writing mail filters, visit settings.

              Gerrit-Project: chromium/src
              Gerrit-Branch: master
              Gerrit-MessageType: comment
              Gerrit-Change-Id: Iedce552dd4f92e2fcbfcd2ba2e4ffba81865d9b6
              Gerrit-Change-Number: 619494
              Gerrit-PatchSet: 4
              Gerrit-Owner: Alexis Hétu <su...@chromium.org>
              Gerrit-Reviewer: Alexis Hétu <su...@chromium.org>
              Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
              Gerrit-CC: Commit Bot <commi...@chromium.org>
              Gerrit-Comment-Date: Fri, 18 Aug 2017 12:18:37 +0000
              Gerrit-HasComments: No
              Gerrit-HasLabels: Yes

              Commit Bot (Gerrit)

              unread,
              Aug 18, 2017, 8:18:56 AM8/18/17
              to Alexis Hétu, blink-...@chromium.org, Kenneth Russell, chromium...@chromium.org

              CQ is trying da patch.

              Note: The patchset sent to CQ was uploaded after this CL was approved.
              "Added missing Linux expectation" https://chromium-review.googlesource.com/c/619494/4

              Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/619494/4

              Bot data: {"action": "start", "triggered_at": "2017-08-18T12:18:37.0Z", "cq_cfg_revision": "5668c9aae8391d95373bdc16d23f5833b4e5ff37", "revision": "9d289dc83207109983be60518108d043f00cc289"}

              View Change

                To view, visit change 619494. To unsubscribe, or for help writing mail filters, visit settings.

                Gerrit-Project: chromium/src
                Gerrit-Branch: master
                Gerrit-MessageType: comment
                Gerrit-Change-Id: Iedce552dd4f92e2fcbfcd2ba2e4ffba81865d9b6
                Gerrit-Change-Number: 619494
                Gerrit-PatchSet: 4
                Gerrit-Owner: Alexis Hétu <su...@chromium.org>
                Gerrit-Reviewer: Alexis Hétu <su...@chromium.org>
                Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
                Gerrit-CC: Commit Bot <commi...@chromium.org>
                Gerrit-Comment-Date: Fri, 18 Aug 2017 12:18:50 +0000
                Gerrit-HasComments: No
                Gerrit-HasLabels: No

                Commit Bot (Gerrit)

                unread,
                Aug 18, 2017, 8:26:25 AM8/18/17
                to Alexis Hétu, blink-...@chromium.org, Kenneth Russell, chromium...@chromium.org

                Commit Bot merged this change.

                View Change

                Approvals: Alexis Hétu: Looks good to me; Commit Kenneth Russell: Looks good to me
                Roll SwiftShader e8d42ae..0def102

                https://swiftshader.googlesource.com/SwiftShader.git/+log/e8d42ae..0def102

                This is a special roll of SwiftShader, which enables Chromium to
                create OpenGL ES 3.0 contexts from SwiftShader. This requires
                re-verifying Layout Tests for pixel differences or timeouts.

                Note that this change does NOT enable WebGL 2 when using
                "--disable-gpu" or when falling back to SwiftShader for WebGL,
                but does allow WebGL 2 content to be displayed when using
                "--use-gl=swiftshader" (kGLImplementationSwiftShaderGL),
                which is what Layout Tests currently use on Windows.

                BUG=chromium:726075

                TBR=k...@chromium.org

                Change-Id: Iedce552dd4f92e2fcbfcd2ba2e4ffba81865d9b6
                Reviewed-on: https://chromium-review.googlesource.com/619494
                Commit-Queue: Alexis Hétu <su...@chromium.org>
                Reviewed-by: Alexis Hétu <su...@chromium.org>
                Reviewed-by: Kenneth Russell <k...@chromium.org>
                Cr-Commit-Position: refs/heads/master@{#495530}
                ---
                M DEPS
                M third_party/WebKit/LayoutTests/SlowTests
                M third_party/WebKit/LayoutTests/TestExpectations
                A third_party/WebKit/LayoutTests/platform/linux/external/wpt/offscreen-canvas/the-offscreen-canvas/offscreencanvas.getcontext-expected.txt
                A third_party/WebKit/LayoutTests/platform/win/external/wpt/offscreen-canvas/the-offscreen-canvas/offscreencanvas.getcontext-expected.txt
                5 files changed, 25 insertions(+), 12 deletions(-)


                To view, visit change 619494. To unsubscribe, or for help writing mail filters, visit settings.

                Gerrit-Project: chromium/src
                Gerrit-Branch: master
                Gerrit-MessageType: merged
                Gerrit-Change-Id: Iedce552dd4f92e2fcbfcd2ba2e4ffba81865d9b6
                Gerrit-Change-Number: 619494
                Gerrit-PatchSet: 5
                Gerrit-Owner: Alexis Hétu <su...@chromium.org>
                Gerrit-Reviewer: Alexis Hétu <su...@chromium.org>
                Gerrit-Reviewer: Commit Bot <commi...@chromium.org>
                Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
                Reply all
                Reply to author
                Forward
                0 new messages