Re: We fixed stringifier behavior in geometry. (issue 2846523002 by gogag2@gmail.com)

0 views
Skip to first unread message

foo...@chromium.org

unread,
Apr 26, 2017, 9:50:01 AM4/26/17
to gog...@gmail.com, jinho...@samsung.com, caba...@adobe.com, chromium...@chromium.org, blink-...@chromium.org
I started a dry run. If no tests fail, then please add tests that exercise the
change. You can add them in LayoutTests/external/wpt/css/geometry-1/, which
should soon be imported due to https://codereview.chromium.org/2841823002

https://codereview.chromium.org/2846523002/

foo...@chromium.org

unread,
Apr 26, 2017, 9:54:19 AM4/26/17
to gog...@gmail.com, jinho...@samsung.com, caba...@adobe.com, chromium...@chromium.org, blink-...@chromium.org
(I updated the description)

https://codereview.chromium.org/2846523002/

foo...@chromium.org

unread,
Apr 26, 2017, 9:55:18 AM4/26/17
to gog...@gmail.com, jinho...@samsung.com, caba...@adobe.com, chromium...@chromium.org, blink-...@chromium.org
If you are on GitHub, can you please comment on
https://github.com/w3c/fxtf-drafts/issues/120 to say that you'd like to change
Blink and thus match the spec?

https://codereview.chromium.org/2846523002/

jinho...@samsung.com

unread,
Apr 26, 2017, 10:46:15 AM4/26/17
to gog...@gmail.com, foo...@chromium.org, caba...@adobe.com, chromium...@chromium.org, blink-...@chromium.org
On 2017/04/26 14:18:29, Byoungkwon Ko wrote:

> On 2017/04/26 13:55:17, foolip OOO until May 2 wrote:
> > If you are on GitHub, can you please comment on
> > https://github.com/w3c/fxtf-drafts/issues/120 to say that you'd like to
change
> > Blink and thus match the spec?
>
> I updated comment to the link :)
> thanks.

You should use String::Format() instead of format().

Reformatting happened recently. :)

https://codereview.chromium.org/2846523002/
Reply all
Reply to author
Forward
0 new messages