DevTools: fix, rebaseline & enable console-dir.js test [chromium/src : master]

Will Chen (Gerrit)

unread,

Aug 17, 2017, 9:21:30 PM8/17/17

to apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Igor Sheludko, Erik Luo, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

ptal

Patch set 1:Commit-Queue +1

View Change

To view, visit change 620191. To unsubscribe, or for help writing mail filters, visit settings.

Igor Sheludko (Gerrit)

unread,

Aug 18, 2017, 3:05:00 AM8/18/17

to Will Chen, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Commit Bot, Erik Luo, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

lgtm, although I don't have the code-review permission

View Change

To view, visit change 620191. To unsubscribe, or for help writing mail filters, visit settings.

Igor Sheludko (Gerrit)

unread,

Aug 18, 2017, 3:11:50 AM8/18/17

to Will Chen, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Commit Bot, Erik Luo, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Please also add v8:6529 to the "Bug:" line.

View Change

To view, visit change 620191. To unsubscribe, or for help writing mail filters, visit settings.

Erik Luo (Gerrit)

unread,

Aug 21, 2017, 2:55:35 PM8/21/17

to Will Chen, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Igor Sheludko, Commit Bot, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

lgtm

Patch set 1:Code-Review +1

View Change

1 comment:

File third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-expected.txt:
- Patch Set #1, Line 48:
  For reference, it looks like this was added as part of a V8 roll:
  https://chromium.googlesource.com/chromium/src/+/0b07200c644f3b7147b3720a35bda0d16842ada8
  Suspect CL:
  https://chromium.googlesource.com/v8/v8/+/c5e9416b1d2e55a4d052e8dcd9848c18e4f3d8a5

To view, visit change 620191. To unsubscribe, or for help writing mail filters, visit settings.

Will Chen (Gerrit)

unread,

Aug 21, 2017, 3:06:17 PM8/21/17

to Igor Sheludko, Erik Luo, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, devtools...@chromium.org, chromium...@chromium.org, Commit Bot, Pavel Feldman

Will Chen uploaded patch set #2 to this change.

View Change

DevTools: fix, rebaseline & enable console-dir.js test

When I transformed this test, there was a couple of issues but I didn't
catch it because this test was disabled.

I've fixed the issue and have rebaselined and enabled the test.

Bug: 667560, v8:6529
Change-Id: I28b186562d965f6c1de936370b31e5cc2700d001
---
M third_party/WebKit/LayoutTests/TestExpectations
M third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-expected.txt
M third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir.js
3 files changed, 47 insertions(+), 63 deletions(-)

To view, visit change 620191. To unsubscribe, or for help writing mail filters, visit settings.

Will Chen (Gerrit)

unread,

Aug 21, 2017, 3:08:39 PM8/21/17

to Aleksey Kozyatinskiy, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Erik Luo, Igor Sheludko

Will Chen would like Aleksey Kozyatinskiy to review this change.

View Change

DevTools: fix, rebaseline & enable console-dir.js test

When I transformed this test, there was a couple of issues but I didn't
catch it because this test was disabled.

I've fixed the issue and have rebaselined and enabled the test.

Bug: 667560, v8:6529
Change-Id: I28b186562d965f6c1de936370b31e5cc2700d001
---
M third_party/WebKit/LayoutTests/TestExpectations
M third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-expected.txt
M third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir.js
3 files changed, 47 insertions(+), 63 deletions(-)

To view, visit change 620191. To unsubscribe, or for help writing mail filters, visit settings.

Will Chen (Gerrit)

unread,

Aug 21, 2017, 3:08:39 PM8/21/17

to apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Aleksey Kozyatinskiy, Erik Luo, Igor Sheludko, Commit Bot, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

@kozy - please take a look.

View Change

To view, visit change 620191. To unsubscribe, or for help writing mail filters, visit settings.

Aleksey Kozyatinskiy (Gerrit)

unread,

Aug 21, 2017, 5:51:32 PM8/21/17

to Will Chen, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Erik Luo, Igor Sheludko, Commit Bot, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Patch set 2:Code-Review +1

View Change

To view, visit change 620191. To unsubscribe, or for help writing mail filters, visit settings.

Will Chen (Gerrit)

unread,

Aug 21, 2017, 7:33:35 PM8/21/17

to apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Aleksey Kozyatinskiy, Erik Luo, Igor Sheludko, Commit Bot, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Patch set 2:Commit-Queue +2

View Change

To view, visit change 620191. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Aug 21, 2017, 9:15:18 PM8/21/17

to Will Chen, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Aleksey Kozyatinskiy, Erik Luo, Igor Sheludko, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Commit Bot merged this change.

View Change

Approvals:
  Aleksey Kozyatinskiy: Looks good to me
  Erik Luo: Looks good to me
  Will Chen: Commit

DevTools: fix, rebaseline & enable console-dir.js test

When I transformed this test, there was a couple of issues but I didn't
catch it because this test was disabled.

I've fixed the issue and have rebaselined and enabled the test.

Bug: 667560, v8:6529
Change-Id: I28b186562d965f6c1de936370b31e5cc2700d001

Reviewed-on: https://chromium-review.googlesource.com/620191
Reviewed-by: Aleksey Kozyatinskiy <kozyat...@chromium.org>
Reviewed-by: Erik Luo <lu...@chromium.org>
Commit-Queue: Will Chen <chenw...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496161}


---
M third_party/WebKit/LayoutTests/TestExpectations
M third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-expected.txt
M third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir.js
3 files changed, 47 insertions(+), 63 deletions(-)

To view, visit change 620191. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward