Use CanvasResource as a vehicle for OffscreenCanvas placeholder frames [chromium/src : master]

Justin Novosad (Gerrit)

unread,

May 25, 2018, 2:32:28 PM5/25/18

to Fernando Serboncini, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, pdr+graphi...@chromium.org

Justin Novosad would like Fernando Serboncini to review this change.

View Change

Use CanvasResource as a vehicle for OffscreenCanvas placeholder frames

This is an incrmental step toward unifying <canvas> and OffscreenCanvas
around CanvasResource.

BUG=788439

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2445e5cbe63f4ae329afd13cb07d3211e0f4de56
---
M third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
M third_party/blink/renderer/core/html/canvas/html_canvas_element.h
M third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image.cc
M third_party/blink/renderer/platform/graphics/canvas_resource.cc
M third_party/blink/renderer/platform/graphics/canvas_resource.h
M third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.cc
M third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.h
M third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher_test.cc
M third_party/blink/renderer/platform/graphics/offscreen_canvas_placeholder.cc
M third_party/blink/renderer/platform/graphics/offscreen_canvas_placeholder.h
10 files changed, 56 insertions(+), 29 deletions(-)

To view, visit change 1073634. To unsubscribe, or for help writing mail filters, visit settings.

Justin Novosad (Gerrit)

unread,

May 25, 2018, 2:32:29 PM5/25/18

to blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, pdr+graphi...@chromium.org, Fernando Serboncini, chromium...@chromium.org, Dongseong Hwang, Dirk Schulze, Stephen Chenney

This change is ready for review.

View Change

To view, visit change 1073634. To unsubscribe, or for help writing mail filters, visit settings.

Fernando Serboncini (Gerrit)

unread,

May 25, 2018, 3:26:28 PM5/25/18

to Justin Novosad, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, pdr+graphi...@chromium.org, Stephen Chenney, chromium...@chromium.org, Dongseong Hwang, Commit Bot, Dirk Schulze

Fernando Serboncini uploaded patch set #3 to the change originally created by Justin Novosad.

View Change

Use CanvasResource as a vehicle for OffscreenCanvas placeholder frames

This is an incremental step toward unifying <canvas> and OffscreenCanvas


around CanvasResource.

BUG=788439

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2445e5cbe63f4ae329afd13cb07d3211e0f4de56
---
M third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
M third_party/blink/renderer/core/html/canvas/html_canvas_element.h
M third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image.cc
M third_party/blink/renderer/platform/graphics/canvas_resource.cc
M third_party/blink/renderer/platform/graphics/canvas_resource.h
M third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.cc
M third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.h
M third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher_test.cc
M third_party/blink/renderer/platform/graphics/offscreen_canvas_placeholder.cc
M third_party/blink/renderer/platform/graphics/offscreen_canvas_placeholder.h
10 files changed, 56 insertions(+), 29 deletions(-)

To view, visit change 1073634. To unsubscribe, or for help writing mail filters, visit settings.

Fernando Serboncini (Gerrit)

unread,

May 25, 2018, 3:26:44 PM5/25/18

to Justin Novosad, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, pdr+graphi...@chromium.org, Stephen Chenney, chromium...@chromium.org, Dongseong Hwang, Commit Bot, Dirk Schulze

Fernando Serboncini uploaded patch set #4 to the change originally created by Justin Novosad.

View Change

Use CanvasResource as a vehicle for OffscreenCanvas placeholder frames

This is an incremental step toward unifying <canvas> and


OffscreenCanvas around CanvasResource.

BUG=788439

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2445e5cbe63f4ae329afd13cb07d3211e0f4de56
---
M third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
M third_party/blink/renderer/core/html/canvas/html_canvas_element.h
M third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image.cc
M third_party/blink/renderer/platform/graphics/canvas_resource.cc
M third_party/blink/renderer/platform/graphics/canvas_resource.h
M third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.cc
M third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.h
M third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher_test.cc
M third_party/blink/renderer/platform/graphics/offscreen_canvas_placeholder.cc
M third_party/blink/renderer/platform/graphics/offscreen_canvas_placeholder.h
10 files changed, 56 insertions(+), 29 deletions(-)

To view, visit change 1073634. To unsubscribe, or for help writing mail filters, visit settings.

Fernando Serboncini (Gerrit)

unread,

May 25, 2018, 3:30:22 PM5/25/18

to Justin Novosad, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, pdr+graphi...@chromium.org, Commit Bot, chromium...@chromium.org, Dongseong Hwang, Dirk Schulze, Stephen Chenney

Patch set 4:Code-Review +1

View Change

1 comment:

File third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.cc:
- Patch Set #4, Line 170: scoped_refptr<CanvasResource> canvas_resource = CanvasResourceBitmap::Create(
  80chars?

To view, visit change 1073634. To unsubscribe, or for help writing mail filters, visit settings.

Justin Novosad (Gerrit)

unread,

May 25, 2018, 3:38:05 PM5/25/18

to Fernando Serboncini, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, pdr+graphi...@chromium.org, Commit Bot, chromium...@chromium.org, Dongseong Hwang, Dirk Schulze, Stephen Chenney

Patch set 4:Commit-Queue +2

View Change

1 comment:

File third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.cc:

- Patch Set #4, Line 170: scoped_refptr<CanvasResource> canvas_resource = CanvasResourceBitmap::Create(
  80chars?

- We're fine. presubmit is not complaining

To view, visit change 1073634. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

May 25, 2018, 6:08:06 PM5/25/18

to Justin Novosad, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, pdr+graphi...@chromium.org, Fernando Serboncini, chromium...@chromium.org, Dongseong Hwang, Dirk Schulze, Stephen Chenney

Try jobs failed on following builders:
  mac_chromium_rel_ng on luci.chromium.try (JOB_FAILED, https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/55986)

View Change

To view, visit change 1073634. To unsubscribe, or for help writing mail filters, visit settings.

Justin Novosad (Gerrit)

unread,

May 28, 2018, 1:46:35 PM5/28/18

to blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, pdr+graphi...@chromium.org, Fernando Serboncini, Commit Bot, chromium...@chromium.org, Dongseong Hwang, Dirk Schulze, Stephen Chenney

Patch set 6:Commit-Queue +2

View Change

To view, visit change 1073634. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

May 28, 2018, 1:47:50 PM5/28/18

to Justin Novosad, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, pdr+graphi...@chromium.org, Fernando Serboncini, chromium...@chromium.org, Dongseong Hwang, Dirk Schulze, Stephen Chenney

CQ is trying the patch.

Note: The patchset sent to CQ was uploaded after this CL was approved.
"better version" https://chromium-review.googlesource.com/c/1073634/6

Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/1073634/6

Bot data: {"action": "start", "triggered_at": "2018-05-28T17:46:33.0Z", "cq_cfg_revision": "6a25833cb93164fb378d8087f9dae5fc28fc9b1e", "revision": "e89d3e1e7f880abcdce434d903a4639cd83ed4d2"}

View Change

To view, visit change 1073634. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

May 28, 2018, 2:14:11 PM5/28/18

to Justin Novosad, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, pdr+graphi...@chromium.org, Fernando Serboncini, chromium...@chromium.org, Dongseong Hwang, Dirk Schulze, Stephen Chenney

Try jobs failed on following builders:

  chromeos-daisy-rel on luci.chromium.try (JOB_FAILED, https://ci.chromium.org/p/chromium/builders/luci.chromium.try/chromeos-daisy-rel/10799)

View Change

To view, visit change 1073634. To unsubscribe, or for help writing mail filters, visit settings.

Justin Novosad (Gerrit)

unread,

May 28, 2018, 2:31:34 PM5/28/18

to blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, pdr+graphi...@chromium.org, Fernando Serboncini, Commit Bot, chromium...@chromium.org, Dongseong Hwang, Dirk Schulze, Stephen Chenney

Patch set 7:Commit-Queue +2

View Change

To view, visit change 1073634. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

May 28, 2018, 2:31:43 PM5/28/18

to Justin Novosad, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, pdr+graphi...@chromium.org, Fernando Serboncini, chromium...@chromium.org, Dongseong Hwang, Dirk Schulze, Stephen Chenney

CQ is trying the patch.

Note: The patchset sent to CQ was uploaded after this CL was approved.

"dcheck fix" https://chromium-review.googlesource.com/c/1073634/7

Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/1073634/7

Bot data: {"action": "start", "triggered_at": "2018-05-28T18:31:32.0Z", "cq_cfg_revision": "6a25833cb93164fb378d8087f9dae5fc28fc9b1e", "revision": "74760a5182ac75f880b6e56525a783b9df4de70d"}

View Change

To view, visit change 1073634. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

May 28, 2018, 2:44:54 PM5/28/18

to Justin Novosad, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, pdr+graphi...@chromium.org, Fernando Serboncini, chromium...@chromium.org, Dongseong Hwang, Dirk Schulze, Stephen Chenney

Try jobs failed on following builders:

  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/builds/30030)

View Change

To view, visit change 1073634. To unsubscribe, or for help writing mail filters, visit settings.

Justin Novosad (Gerrit)

unread,

May 28, 2018, 2:55:10 PM5/28/18

to blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, pdr+graphi...@chromium.org, Fernando Serboncini, Commit Bot, chromium...@chromium.org, Dongseong Hwang, Dirk Schulze, Stephen Chenney

Patch set 8:Commit-Queue +2

View Change

To view, visit change 1073634. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

May 28, 2018, 2:55:15 PM5/28/18

to Justin Novosad, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, pdr+graphi...@chromium.org, Fernando Serboncini, chromium...@chromium.org, Dongseong Hwang, Dirk Schulze, Stephen Chenney

CQ is trying the patch.

Note: The patchset sent to CQ was uploaded after this CL was approved.

"dcheck fix" https://chromium-review.googlesource.com/c/1073634/8

Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/1073634/8

Bot data: {"action": "start", "triggered_at": "2018-05-28T18:55:08.0Z", "cq_cfg_revision": "6a25833cb93164fb378d8087f9dae5fc28fc9b1e", "revision": "096f6fedc42e19ed48d5c074ac46078c2c5712b7"}

View Change

To view, visit change 1073634. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

May 28, 2018, 4:14:03 PM5/28/18

to Justin Novosad, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, pdr+graphi...@chromium.org, Fernando Serboncini, chromium...@chromium.org, Dongseong Hwang, Dirk Schulze, Stephen Chenney

Commit Bot merged this change.

View Change

Approvals:
  Fernando Serboncini: Looks good to me
  Justin Novosad: Commit

Use CanvasResource as a vehicle for OffscreenCanvas placeholder frames

This is an incremental step toward unifying <canvas> and


OffscreenCanvas around CanvasResource.

BUG=788439

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2445e5cbe63f4ae329afd13cb07d3211e0f4de56

Reviewed-on: https://chromium-review.googlesource.com/1073634
Commit-Queue: Justin Novosad <ju...@chromium.org>
Reviewed-by: Fernando Serboncini <fs...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562304}


---
M third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
M third_party/blink/renderer/core/html/canvas/html_canvas_element.h
M third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image.cc
M third_party/blink/renderer/platform/graphics/canvas_resource.cc
M third_party/blink/renderer/platform/graphics/canvas_resource.h
M third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.cc
M third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.h
M third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher_test.cc
M third_party/blink/renderer/platform/graphics/offscreen_canvas_placeholder.cc
M third_party/blink/renderer/platform/graphics/offscreen_canvas_placeholder.h

10 files changed, 116 insertions(+), 42 deletions(-)

To view, visit change 1073634. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward