Make text selection work with barrel selection. [chromium/src : master]
Dave Tapuska (Gerrit)
This change is ready for review.
To view, visit change 615540. To unsubscribe, or for help writing mail filters, visit settings.
David Bokan (Gerrit)
Seems like we should have some test coverage here, could you add one?
1 comment:
File third_party/WebKit/Source/core/input/MouseEventManager.cpp:
Patch Set #1, Line 783:
event.Event().button != WebPointerProperties::Button::kRightIs "barrel" the button on the pen? Is it represented by Button::kRight? If I'm understanding correctly, could you add a kBarrel to the enum that uses the same value to make it clearer?
To view, visit change 615540. To unsubscribe, or for help writing mail filters, visit settings.
Dave Tapuska (Gerrit)
1 comment:
File third_party/WebKit/Source/core/input/MouseEventManager.cpp:
Patch Set #1, Line 783:
event.Event().button != WebPointerProperties::Button::kBarreIs "barrel" the button on the pen? Is it represented by Button::kRight? If I'm understanding correct […]
Done
To view, visit change 615540. To unsubscribe, or for help writing mail filters, visit settings.
David Bokan (Gerrit)
lgtm
Patch set 2:Code-Review +1
1 comment:
File third_party/WebKit/LayoutTests/fast/events/selectstart-by-drag-stylus.html:
Supernit: is this pink because of a space?
To view, visit change 615540. To unsubscribe, or for help writing mail filters, visit settings.
Dave Tapuska (Gerrit)
Patch set 3:Commit-Queue +2
Commit Bot (Gerrit)
CQ is trying da patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"Rebase" https://chromium-review.googlesource.com/c/615540/3
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/615540/3
Bot data: {"action": "start", "triggered_at": "2017-08-18T18:55:38.0Z", "cq_cfg_revision": "5668c9aae8391d95373bdc16d23f5833b4e5ff37", "revision": "8ac9f93056fbe55278083f54f6b711d9f94398a6"}
Commit Bot (Gerrit)
Try jobs failed on following builders:
chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/520464)
Bot data: {"action": "cancel", "triggered_at": "2017-08-18T18:55:38.0Z", "cq_cfg_revision": "5668c9aae8391d95373bdc16d23f5833b4e5ff37", "revision": "8ac9f93056fbe55278083f54f6b711d9f94398a6"}
Dave Tapuska (Gerrit)
Dave Tapuska would like Rick Byers to review this change.
Make text selection work with barrel selection.
Select text with the barrel button with stylus. Text selection will no
longer work with the tip of the stylus but the barrel button needs to be
pressed.
BUG=746581
Change-Id: I65b50a68f816b39cfe183c8fc7fbd0e1003053b6
---
A third_party/WebKit/LayoutTests/fast/events/selectstart-by-drag-stylus.html
M third_party/WebKit/Source/core/input/MouseEventManager.cpp
M third_party/WebKit/public/platform/WebPointerProperties.h
3 files changed, 33 insertions(+), 4 deletions(-)
Rick Byers (Gerrit)
LGTM
But as we discussed offline, as you add the about:flags entry to disable the new mode, please also plumb through a setting to revert blink to the prior behavior. I'm wondering if there are some users who, for accessibility reasons, rely on dragging a stylus (perhaps one that has no barrel button) to select text. So I'd like to ensure that, for now, the flag can be used to return the behavior to exactly what it is today.
Patch set 3:Code-Review +1
Dave Tapuska (Gerrit)
Patch set 4:Commit-Queue +2
Commit Bot (Gerrit)
CQ is trying da patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"Adjust expectations on Linux Mac" https://chromium-review.googlesource.com/c/615540/4
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/615540/4
Bot data: {"action": "start", "triggered_at": "2017-08-18T23:06:51.0Z", "cq_cfg_revision": "5668c9aae8391d95373bdc16d23f5833b4e5ff37", "revision": "5eecfa5506caf70bd2af0aeba5b89d7e699a6448"}
Commit Bot (Gerrit)
Try jobs failed on following builders:
linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/528710)
Bot data: {"action": "cancel", "triggered_at": "2017-08-18T23:06:51.0Z", "cq_cfg_revision": "dfe947bde1f01d705ae0b14a31b09e087e8bf046", "revision": "5eecfa5506caf70bd2af0aeba5b89d7e699a6448"}
To view, visit change 615540. To unsubscribe, or for help writing mail filters, visit settings.
Dave Tapuska (Gerrit)
Commit Bot (Gerrit)
CQ is trying da patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"Adjust expectations on Linux Mac" https://chromium-review.googlesource.com/c/615540/4
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/615540/4
Bot data: {"action": "start", "triggered_at": "2017-08-19T13:18:35.0Z", "cq_cfg_revision": "dfe947bde1f01d705ae0b14a31b09e087e8bf046", "revision": "5eecfa5506caf70bd2af0aeba5b89d7e699a6448"}
To view, visit change 615540. To unsubscribe, or for help writing mail filters, visit settings.
Commit Bot (Gerrit)
Commit Bot merged this change.
Make text selection work with barrel selection.
Select text with the barrel button with stylus. Text selection will no
longer work with the tip of the stylus but the barrel button needs to be
pressed.
BUG=746581
Change-Id: I65b50a68f816b39cfe183c8fc7fbd0e1003053b6
Reviewed-on: https://chromium-review.googlesource.com/615540
Commit-Queue: Dave Tapuska <dtap...@chromium.org>
Reviewed-by: Rick Byers <rby...@chromium.org>
Reviewed-by: David Bokan <bo...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495815}
---
A third_party/WebKit/LayoutTests/fast/events/selectstart-by-drag-stylus.html
M third_party/WebKit/Source/core/input/MouseEventManager.cpp
M third_party/WebKit/public/platform/WebPointerProperties.h
3 files changed, 37 insertions(+), 4 deletions(-)