[LayoutNG] UpdateMargins is no longer needed by LayoutNGBlockFlow [chromium/src : master]
1 view
Skip to first unread message
Aleks Totic (Gerrit)
Dec 15, 2017, 2:59:23 PM12/15/17
to atotic+...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, eae+bli...@chromium.org, glebl+...@chromium.org, jchaffraix...@chromium.org, lchoi+...@chromium.org, leviw+re...@chromium.org, ojan+...@chromium.org, pdr+renderi...@chromium.org, szager+la...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Ian Kilpatrick, Christian Biesinger, chromium...@chromium.org
PTAL, the marginupdate removal CL
To view, visit change 830474. To unsubscribe, or for help writing mail filters, visit settings.
Ian Kilpatrick (Gerrit)
Dec 15, 2017, 3:46:28 PM12/15/17
to Aleks Totic, atotic+...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, eae+bli...@chromium.org, glebl+...@chromium.org, jchaffraix...@chromium.org, lchoi+...@chromium.org, leviw+re...@chromium.org, ojan+...@chromium.org, pdr+renderi...@chromium.org, szager+la...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Christian Biesinger, chromium...@chromium.org
Patch set 2:Code-Review +1Commit-Queue +2
Commit Bot (Gerrit)
Dec 15, 2017, 5:01:03 PM12/15/17
to Aleks Totic, atotic+...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, eae+bli...@chromium.org, glebl+...@chromium.org, jchaffraix...@chromium.org, lchoi+...@chromium.org, leviw+re...@chromium.org, ojan+...@chromium.org, pdr+renderi...@chromium.org, szager+la...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Ian Kilpatrick, Christian Biesinger, chromium...@chromium.org
Try jobs failed on following builders:
linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/218020)
Aleks Totic (Gerrit)
Dec 15, 2017, 7:34:57 PM12/15/17
to atotic+...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, eae+bli...@chromium.org, glebl+...@chromium.org, jchaffraix...@chromium.org, lchoi+...@chromium.org, leviw+re...@chromium.org, ojan+...@chromium.org, pdr+renderi...@chromium.org, szager+la...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Ian Kilpatrick, Commit Bot, Christian Biesinger, chromium...@chromium.org
Patch set 2:Commit-Queue +2
Commit Bot (Gerrit)
Dec 15, 2017, 7:41:44 PM12/15/17
to Aleks Totic, atotic+...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, eae+bli...@chromium.org, glebl+...@chromium.org, jchaffraix...@chromium.org, lchoi+...@chromium.org, leviw+re...@chromium.org, ojan+...@chromium.org, pdr+renderi...@chromium.org, szager+la...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Ian Kilpatrick, Christian Biesinger, chromium...@chromium.org
Commit Bot merged this change.
Approvals:
Ian Kilpatrick: Looks good to me
Aleks Totic: Commit
[LayoutNG] UpdateMargins is no longer needed by LayoutNGBlockFlow
After CL 827548, margins are always copied to Legacy.
Additional copy in LayoutNGBlockFlow is no longer needed.
Ian says so.
Bug: 740993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: If1aee4b15a966d58bd62f66190fdf00f035ed0b4
Reviewed-on: https://chromium-review.googlesource.com/830474
Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
Commit-Queue: Aleks Totic <ato...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524538}
---
M third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc
M third_party/WebKit/Source/core/layout/ng/layout_ng_mixin.cc
M third_party/WebKit/Source/core/layout/ng/layout_ng_mixin.h
3 files changed, 0 insertions(+), 16 deletions(-)
Reply all
Reply to author
Forward
0 new messages