Remove FileSystem runtime flag for blink (issue 1117063005 by qiankun.miao@intel.com)

1 view
Skip to first unread message

qianku...@intel.com

unread,
May 4, 2015, 2:31:00 AM5/4/15
to mk...@chromium.org, mich...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, loislo...@chromium.org, tz...@chromium.org, yurys...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, dglazko...@chromium.org, apavlo...@chromium.org, nhi...@chromium.org, devtools...@chromium.org, sergey...@chromium.org, aandre...@chromium.org, kinuko+...@chromium.org, kozyatins...@chromium.org
Reviewers: Mike West (traveling. slow.), michaeln,

Message:
PTAL.

Description:
Remove FileSystem runtime flag for blink

This feature is in stable status since 2013. It should be fine to remove
this runtime flag.

BUG=402536

Please review this at https://codereview.chromium.org/1117063005/

Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Affected files (+9, -21 lines):
M Source/modules/filesystem/DevToolsHostFileSystem.idl
M Source/modules/filesystem/HTMLInputElementFileSystem.idl
M Source/modules/filesystem/WindowFileSystem.idl
M Source/modules/filesystem/WorkerGlobalScopeFileSystem.idl
M Source/platform/RuntimeEnabledFeatures.in
M Source/web/WebRuntimeFeatures.cpp
M public/web/WebRuntimeFeatures.h


Index: Source/modules/filesystem/DevToolsHostFileSystem.idl
diff --git a/Source/modules/filesystem/DevToolsHostFileSystem.idl
b/Source/modules/filesystem/DevToolsHostFileSystem.idl
index
c0a283af70711f3f5ac9307701565e3d895f3e29..59c9268f5e07da8ba0e79f71e6f7357f248c9048
100644
--- a/Source/modules/filesystem/DevToolsHostFileSystem.idl
+++ b/Source/modules/filesystem/DevToolsHostFileSystem.idl
@@ -2,9 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

-[
- RuntimeEnabled=FileSystem,
-] partial interface DevToolsHost {
+partial interface DevToolsHost {
DOMFileSystem isolatedFileSystem(DOMString fileSystemId, DOMString
registeredName);
void upgradeDraggedFileSystemPermissions(DOMFileSystem domFileSystem);
};
Index: Source/modules/filesystem/HTMLInputElementFileSystem.idl
diff --git a/Source/modules/filesystem/HTMLInputElementFileSystem.idl
b/Source/modules/filesystem/HTMLInputElementFileSystem.idl
index
c55dcd9167481963a74430e7ef0e306008d51bd2..92d80c1e22d6f70474436feb6fa0ed900a449b4f
100644
--- a/Source/modules/filesystem/HTMLInputElementFileSystem.idl
+++ b/Source/modules/filesystem/HTMLInputElementFileSystem.idl
@@ -28,8 +28,6 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/

-[
- RuntimeEnabled=FileSystem,
-] partial interface HTMLInputElement {
+partial interface HTMLInputElement {
[CallWith=ExecutionContext] readonly attribute Entry[] webkitEntries;
};
Index: Source/modules/filesystem/WindowFileSystem.idl
diff --git a/Source/modules/filesystem/WindowFileSystem.idl
b/Source/modules/filesystem/WindowFileSystem.idl
index
4d98026140b3d5c484fd3d2aa237d41ce50d8c9e..814e83c48cdecb0d18fdf6732530a4e6fda52a40
100644
--- a/Source/modules/filesystem/WindowFileSystem.idl
+++ b/Source/modules/filesystem/WindowFileSystem.idl
@@ -30,8 +30,8 @@
const unsigned short TEMPORARY = 0;
const unsigned short PERSISTENT = 1;

- [RuntimeEnabled=FileSystem, MeasureAs=RequestFileSystem] void
webkitRequestFileSystem(unsigned short type, long long size,
+ [MeasureAs=RequestFileSystem] void webkitRequestFileSystem(unsigned
short type, long long size,
FileSystemCallback successCallback, optional ErrorCallback
errorCallback);
- [RuntimeEnabled=FileSystem] void
webkitResolveLocalFileSystemURL(DOMString url,
+ void webkitResolveLocalFileSystemURL(DOMString url,
EntryCallback successCallback, optional ErrorCallback
errorCallback);
};
Index: Source/modules/filesystem/WorkerGlobalScopeFileSystem.idl
diff --git a/Source/modules/filesystem/WorkerGlobalScopeFileSystem.idl
b/Source/modules/filesystem/WorkerGlobalScopeFileSystem.idl
index
f01817aa4de0dda351e709f10c6b475fd4f7a255..7359a690b7f0081c8a69ec3715aac7c83118ee28
100644
--- a/Source/modules/filesystem/WorkerGlobalScopeFileSystem.idl
+++ b/Source/modules/filesystem/WorkerGlobalScopeFileSystem.idl
@@ -28,10 +28,10 @@ partial interface WorkerGlobalScope {
const unsigned short TEMPORARY = 0;
const unsigned short PERSISTENT = 1;

- [RuntimeEnabled=FileSystem, MeasureAs=RequestFileSystemWorker] void
webkitRequestFileSystem(unsigned short type, long long size, optional
FileSystemCallback successCallback, optional ErrorCallback errorCallback);
- [RuntimeEnabled=FileSystem, RaisesException,
MeasureAs=RequestFileSystemSyncWorker] DOMFileSystemSync
webkitRequestFileSystemSync(unsigned short type, long long size);
- [RuntimeEnabled=FileSystem] void
webkitResolveLocalFileSystemURL(DOMString url, EntryCallback
successCallback, optional ErrorCallback errorCallback);
- [RuntimeEnabled=FileSystem, RaisesException] EntrySync
webkitResolveLocalFileSystemSyncURL(DOMString url);
+ [MeasureAs=RequestFileSystemWorker] void
webkitRequestFileSystem(unsigned short type, long long size, optional
FileSystemCallback successCallback, optional ErrorCallback errorCallback);
+ [RaisesException, MeasureAs=RequestFileSystemSyncWorker]
DOMFileSystemSync webkitRequestFileSystemSync(unsigned short type, long
long size);
+ void webkitResolveLocalFileSystemURL(DOMString url, EntryCallback
successCallback, optional ErrorCallback errorCallback);
+ [RaisesException] EntrySync
webkitResolveLocalFileSystemSyncURL(DOMString url);

- [RuntimeEnabled=FileSystem] attribute FileErrorConstructor FileError;
+ attribute FileErrorConstructor FileError;
};
Index: Source/platform/RuntimeEnabledFeatures.in
diff --git a/Source/platform/RuntimeEnabledFeatures.in
b/Source/platform/RuntimeEnabledFeatures.in
index
7644b4f82781546d5ec930b272e09b0f7a5e4af5..b69d9f1420b82a14353e01342491931367ece93d
100644
--- a/Source/platform/RuntimeEnabledFeatures.in
+++ b/Source/platform/RuntimeEnabledFeatures.in
@@ -61,7 +61,6 @@ ExperimentalCanvasFeatures status=test
ExperimentalContentSecurityPolicyFeatures status=experimental
FastMobileScrolling
FileAPIBlobClose status=experimental
-FileSystem status=stable
FormDataNewMethods status=experimental
FullscreenUnprefixed status=test
Geofencing status=experimental
Index: Source/web/WebRuntimeFeatures.cpp
diff --git a/Source/web/WebRuntimeFeatures.cpp
b/Source/web/WebRuntimeFeatures.cpp
index
fb5988610e43d9d091632df9cf4df8b24070a30a..655d87ed1e91813203633730cc64ecead3409400
100644
--- a/Source/web/WebRuntimeFeatures.cpp
+++ b/Source/web/WebRuntimeFeatures.cpp
@@ -133,11 +133,6 @@ void
WebRuntimeFeatures::enableFastMobileScrolling(bool enable)
RuntimeEnabledFeatures::setFastMobileScrollingEnabled(enable);
}

-void WebRuntimeFeatures::enableFileSystem(bool enable)
-{
- RuntimeEnabledFeatures::setFileSystemEnabled(enable);
-}
-
void WebRuntimeFeatures::enableImageColorProfiles(bool enable)
{
RuntimeEnabledFeatures::setImageColorProfilesEnabled(enable);
Index: public/web/WebRuntimeFeatures.h
diff --git a/public/web/WebRuntimeFeatures.h
b/public/web/WebRuntimeFeatures.h
index
d90a8b961106277d76a5b3e20726f1be35ac0772..2b0b2773ae1f8ed9c4877ab605d40c2d85813285
100644
--- a/public/web/WebRuntimeFeatures.h
+++ b/public/web/WebRuntimeFeatures.h
@@ -75,8 +75,6 @@ public:

BLINK_EXPORT static void enableFastMobileScrolling(bool);

- BLINK_EXPORT static void enableFileSystem(bool);
-
BLINK_EXPORT static void enableImageColorProfiles(bool);

BLINK_EXPORT static void enableMediaPlayer(bool);


mk...@chromium.org

unread,
May 4, 2015, 10:18:12 AM5/4/15
to qianku...@intel.com, mich...@chromium.org, aandre...@chromium.org, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, kinuko+...@chromium.org, kozyatins...@chromium.org, loislo...@chromium.org, lushnik...@chromium.org, nhi...@chromium.org, pfeldma...@chromium.org, sergey...@chromium.org, tz...@chromium.org, yurys...@chromium.org
LGTM.

https://codereview.chromium.org/1117063005/

to...@chromium.org

unread,
May 5, 2015, 4:48:49 AM5/5/15
to qianku...@intel.com, mk...@chromium.org, mich...@chromium.org, aandre...@chromium.org, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, kinuko+...@chromium.org, kozyatins...@chromium.org, loislo...@chromium.org, lushnik...@chromium.org, nhi...@chromium.org, pfeldma...@chromium.org, sergey...@chromium.org, tz...@chromium.org, yurys...@chromium.org
not LGTM, see my comments on chromium side patch
(https://codereview.chromium.org/1117953005/) - this is still used by
webview.

https://codereview.chromium.org/1117063005/
Reply all
Reply to author
Forward
0 new messages