Revert of Don't lower priority for scripts inserted by doc.write (issue 2843013002 by pmeenan@chromium.org)

0 views
Skip to first unread message

pme...@chromium.org

unread,
Apr 26, 2017, 9:22:37 AM4/26/17
to yo...@yoav.ws, kin...@chromium.org, csharriso...@chromium.org, chromium...@chromium.org, yo...@yoav.ws, blink-rev...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, dglazko...@chromium.org, fuz...@chromium.org, gavinp...@chromium.org, blink-...@chromium.org, loading-re...@chromium.org, kinuko...@chromium.org, jap...@chromium.org, tyoshin...@chromium.org
Reviewers: Yoav Weiss, kinuko, Charlie Harrison
CL: https://codereview.chromium.org/2843013002/

Message:
Created Revert of Don't lower priority for scripts inserted by doc.write

Description:
Revert of Don't lower priority for scripts inserted by doc.write (patchset #5
id:70001 of https://codereview.chromium.org/2826213003/ )

Reason for revert:
The layout test was broken and racy (http://crbug.com/715528). SHould be
trivial to fix (use the same query param for the preloaded and real image) but
best to revert, fix and re-land separately.

Original issue's description:
> Don't lower priority for scripts inserted by doc.write
>
> HTML Chunks inserted by document.write() are run through a separate
> instance of the preload scanner from the main document. If the main
> document scanner has already discovered an image then all scripts
> discovered by any preload scanner regardless of where they came from
> would be considered late-body.
>
> This behavior causes a regression where a document.write() in the head
> that includes multiple script tags will discover them but treat them as
> late-body scripts and only load them one at a time.
>
> BUG=713727,712338
>
> Review-Url: https://codereview.chromium.org/2826213003
> Cr-Commit-Position: refs/heads/master@{#467029}
> Committed:
https://chromium.googlesource.com/chromium/src/+/1e0d3cbbf60c67ba9856eadcb9e829b3c4bec6c7

TBR=yo...@yoav.ws,kin...@chromium.org,cshar...@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=713727,712338

Affected files (+66, -150 lines):
M third_party/WebKit/LayoutTests/http/tests/inspector/network/resource-priority.html
M third_party/WebKit/LayoutTests/http/tests/inspector/network/resource-priority-expected.txt
D third_party/WebKit/LayoutTests/http/tests/inspector/network/resources/docwrite.js
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.h
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerFuzzer.cpp
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp
M third_party/WebKit/Source/core/html/parser/PreloadRequest.h
M third_party/WebKit/Source/core/html/parser/PreloadRequest.cpp
M third_party/WebKit/Source/platform/loader/fetch/FetchParameters.h
M third_party/WebKit/Source/platform/loader/fetch/FetchParameters.cpp
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp


commit-bot@chromium.org via codereview.chromium.org

unread,
Apr 26, 2017, 9:22:58 AM4/26/17
to pme...@chromium.org, yo...@yoav.ws, kin...@chromium.org, csharriso...@chromium.org, commi...@chromium.org, chromium...@chromium.org, yo...@yoav.ws, blink-rev...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, dglazko...@chromium.org, fuz...@chromium.org, gavinp...@chromium.org, blink-...@chromium.org, loading-re...@chromium.org, kinuko...@chromium.org, jap...@chromium.org, tyoshin...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Apr 26, 2017, 9:23:49 AM4/26/17
to pme...@chromium.org, yo...@yoav.ws, kin...@chromium.org, csharriso...@chromium.org, commi...@chromium.org, chromium...@chromium.org, yo...@yoav.ws, blink-rev...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, dglazko...@chromium.org, fuz...@chromium.org, gavinp...@chromium.org, blink-...@chromium.org, loading-re...@chromium.org, kinuko...@chromium.org, jap...@chromium.org, tyoshin...@chromium.org
Reply all
Reply to author
Forward
0 new messages