[Devtools] Show contrast UI for gradients. [chromium/src : master]
Alice Boxhall (Gerrit)
This change is ready for review.
To view, visit change 620608. To unsubscribe, or for help writing mail filters, visit settings.
Dmitry Gozman (Gerrit)
lgtm with comments
Patch set 2:Code-Review +1
2 comments:
File third_party/WebKit/Source/devtools/front_end/color_picker/Contrast.js:
Patch Set #2, Line 135:
&& !this._gradientIIUC, no need to check for gradient here.
Patch Set #2, Line 244:
_bgColorForCurrentLineWhy do you store this as a string as opposite to Common.Color ?
To view, visit change 620608. To unsubscribe, or for help writing mail filters, visit settings.
Alice Boxhall (Gerrit)
2 comments:
Patch Set #2, Line 135:
&& !this._gradientIIUC, no need to check for gradient here.
Will remove.
Patch Set #2, Line 244:
_bgColorForCurrentLine
Why do you store this as a string as opposite to Common. […]
Because all I want to do with it is compare for exact equality on line 358.
To view, visit change 620608. To unsubscribe, or for help writing mail filters, visit settings.
Alice Boxhall (Gerrit)
Patch set 3:Commit-Queue +2
Commit Bot (Gerrit)
CQ is trying da patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"No need to check for this gradient in updateContrastRatio" https://chromium-review.googlesource.com/c/620608/3
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/620608/3
Bot data: {"action": "start", "triggered_at": "2017-08-18T22:02:05.0Z", "cq_cfg_revision": "5668c9aae8391d95373bdc16d23f5833b4e5ff37", "revision": "5a8c998f2f04a386f4517c44c918cc64540a1538"}
Commit Bot (Gerrit)
Commit Bot merged this change.
[Devtools] Show contrast UI for gradients.
- Choose the gradient stop closest in color to the text to measure contrast against.
- Show a swatch of the full gradient in the color swatch.
- Users can use the background color picker to choose a representative color from the page.
(Screenshot in bug. https://uigradients.com/ makes a good test page.)
Bug: 514674
Change-Id: I4571b690f5ecc74ce473eb2c120fac9d4717a080
Reviewed-on: https://chromium-review.googlesource.com/620608
Commit-Queue: Alice Boxhall <abox...@chromium.org>
Reviewed-by: Dmitry Gozman <dgo...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495760}
---
M third_party/WebKit/Source/devtools/front_end/color_picker/Contrast.js
M third_party/WebKit/Source/devtools/front_end/color_picker/Spectrum.js
M third_party/WebKit/Source/devtools/front_end/color_picker/spectrum.css
3 files changed, 121 insertions(+), 37 deletions(-)