Make startOfParagraph() not to use Position::deprecatedEditingOffset() (issue 1258313006 by yosin@chromium.org)

yo...@chromium.org

unread,

Aug 3, 2015, 2:47:16 AM8/3/15

to tk...@chromium.org, yoi...@chromium.org, hajim...@chromium.org, blink-...@chromium.org

Reviewers: tkent, yoichio, hajimehoshi,

Message:
PTAL

Description:
Make startOfParagraph() not to use Position::deprecatedEditingOffset()

This patch replaces |Position::deprecatedEditingOffset()| call in
|startOfParagraph()| by |Position::computeEditingOffset()|, since it is used
for computing offset of |VisiblePosition| which can not be middle of editing
ignore content, for improving code health.

This patch is a preparation of getting rid of legacy editing position.

BUG=513114
TEST=n/a; no behavior changes

Please review this at https://codereview.chromium.org/1258313006/

Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Affected files (+1, -1 lines):
M Source/core/editing/VisibleUnits.cpp

Index: Source/core/editing/VisibleUnits.cpp
diff --git a/Source/core/editing/VisibleUnits.cpp
b/Source/core/editing/VisibleUnits.cpp
index
4c03e8fab0de25c63ecc2e239e140271133931ed..85e53447330db0dff5f7f90a58207eec9249f634
100644
--- a/Source/core/editing/VisibleUnits.cpp
+++ b/Source/core/editing/VisibleUnits.cpp
@@ -1135,7 +1135,7 @@ VisiblePosition startOfParagraph(const
VisiblePosition& c, EditingBoundaryCrossi

Node* node = startNode;
ContainerNode* highestRoot = highestEditableRoot(p);
- int offset = p.deprecatedEditingOffset();
+ int offset = p.computeEditingOffset();
PositionAnchorType type = p.anchorType();

Node* n = startNode;