Fold away ImageResourceContent::ImageSize [chromium/src : master]

Fredrik Söderquist (Gerrit)

unread,

Oct 18, 2017, 1:46:34 PM10/18/17

to blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eae+bli...@chromium.org, gavinp...@chromium.org, jchaffraix...@chromium.org, leviw+re...@chromium.org, loading...@chromium.org, pdr+renderi...@chromium.org, szager+la...@chromium.org, tyoshin...@chromium.org, zol...@webkit.org, Stephen Chenney, Commit Bot, chromium...@chromium.org, Nate Chapin

Follow-up to the IntrinsicSize review.

View Change

To view, visit change 726087. To unsubscribe, or for help writing mail filters, visit settings.

Stephen Chenney (Gerrit)

unread,

Oct 18, 2017, 4:10:58 PM10/18/17

to Fredrik Söderquist, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eae+bli...@chromium.org, gavinp...@chromium.org, jchaffraix...@chromium.org, leviw+re...@chromium.org, loading...@chromium.org, pdr+renderi...@chromium.org, szager+la...@chromium.org, tyoshin...@chromium.org, zol...@webkit.org, Commit Bot, chromium...@chromium.org, Nate Chapin

Great. Thanks. Just one nit.

Patch set 1:Code-Review +1

View Change

1 comment:

File third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp:
- Patch Set #1, Line 96: LayoutSize scaled_image_size(
  It's a bit confusing to initialize "scaled_image_size" like this. Maybe have another temp "natural_image_size" or something like that. Or wrap this line into the next one.

To view, visit change 726087. To unsubscribe, or for help writing mail filters, visit settings.

Fredrik Söderquist (Gerrit)

unread,

Oct 19, 2017, 4:04:28 AM10/19/17

to blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eae+bli...@chromium.org, gavinp...@chromium.org, jchaffraix...@chromium.org, leviw+re...@chromium.org, loading...@chromium.org, pdr+renderi...@chromium.org, szager+la...@chromium.org, tyoshin...@chromium.org, zol...@webkit.org, Stephen Chenney, Commit Bot, chromium...@chromium.org, Nate Chapin

View Change

1 comment:

File third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp:
- Patch Set #1, Line 96: LayoutSize natural_size(
  It's a bit confusing to initialize "scaled_image_size" like this. […]
  Did the former.

To view, visit change 726087. To unsubscribe, or for help writing mail filters, visit settings.

Fredrik Söderquist (Gerrit)

unread,

Oct 19, 2017, 6:50:57 AM10/19/17

to blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eae+bli...@chromium.org, gavinp...@chromium.org, jchaffraix...@chromium.org, leviw+re...@chromium.org, loading...@chromium.org, pdr+renderi...@chromium.org, szager+la...@chromium.org, tyoshin...@chromium.org, zol...@webkit.org, Stephen Chenney, Commit Bot, chromium...@chromium.org, Nate Chapin

Patch set 2:Commit-Queue +2

View Change

To view, visit change 726087. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Oct 19, 2017, 6:51:00 AM10/19/17

to Fredrik Söderquist, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eae+bli...@chromium.org, gavinp...@chromium.org, jchaffraix...@chromium.org, leviw+re...@chromium.org, loading...@chromium.org, pdr+renderi...@chromium.org, szager+la...@chromium.org, tyoshin...@chromium.org, zol...@webkit.org, Stephen Chenney, chromium...@chromium.org, Nate Chapin

CQ is trying da patch.

Note: The patchset sent to CQ was uploaded after this CL was approved.
"Rename temporaries in StyleFetchedImageSetImageSize" https://chromium-review.googlesource.com/c/726087/2

Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/726087/2

Bot data: {"action": "start", "triggered_at": "2017-10-19T10:50:51.0Z", "cq_cfg_revision": "2d3a62b279d3f647091bba3d1ee978f0ca0d8e45", "revision": "b20fb8260eac379b01cb281ab414f76de108dc25"}

View Change

To view, visit change 726087. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Oct 19, 2017, 8:44:22 AM10/19/17

to Fredrik Söderquist, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eae+bli...@chromium.org, gavinp...@chromium.org, jchaffraix...@chromium.org, leviw+re...@chromium.org, loading...@chromium.org, pdr+renderi...@chromium.org, szager+la...@chromium.org, tyoshin...@chromium.org, zol...@webkit.org, Stephen Chenney, chromium...@chromium.org, Nate Chapin

Commit Bot merged this change.

View Change

Approvals:
  Stephen Chenney: Looks good to me
  Fredrik Söderquist: Commit

Fold away ImageResourceContent::ImageSize

This moves scale-handling out into the (now former) consumers of the
ImageResourceContent::ImageSize method.

Bug: 773272
Change-Id: I08760b181a48f8a5dcc5ceff68a19c67eba3601a
Reviewed-on: https://chromium-review.googlesource.com/726087
Commit-Queue: Fredrik Söderquist <f...@opera.com>
Reviewed-by: Stephen Chenney <sche...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510061}
---
M third_party/WebKit/Source/core/layout/LayoutImageResource.cpp
M third_party/WebKit/Source/core/loader/resource/ImageResourceContent.cpp
M third_party/WebKit/Source/core/loader/resource/ImageResourceContent.h
M third_party/WebKit/Source/core/style/StyleFetchedImage.cpp
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp
M third_party/WebKit/Source/core/style/StyleImage.cpp
M third_party/WebKit/Source/core/style/StyleImage.h
7 files changed, 20 insertions(+), 36 deletions(-)

To view, visit change 726087. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward