AtomicStringTable should not be initialized lazily (issue 1370113006 by mikhail.pozdnyakov@intel.com)

12 views
Skip to first unread message

mikhail.p...@intel.com

unread,
Oct 2, 2015, 9:49:38 AM10/2/15
to tk...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org
Reviewers: tkent,

Message:
PTAL

Description:
This patch removes lazy initialization for both AtomicThreadTable and
WTFThreadData. Therefore (1) two unneeded 'if' conditions have been removed
from
the 'atomicStringTable()' function which is used extremely intensively in
blink
and (2) the related code has been significantly simplified.

Please review this at https://codereview.chromium.org/1370113006/

Base URL:
https://chromium.googlesource.com/chromium/src.git@AtomitStringTable

Affected files (+46, -58 lines):
M third_party/WebKit/Source/wtf/ThreadingPthreads.cpp
M third_party/WebKit/Source/wtf/ThreadingWin.cpp
M third_party/WebKit/Source/wtf/WTFThreadData.h
M third_party/WebKit/Source/wtf/WTFThreadData.cpp
M third_party/WebKit/Source/wtf/text/AtomicString.h
M third_party/WebKit/Source/wtf/text/AtomicString.cpp


tk...@chromium.org

unread,
Oct 4, 2015, 6:47:48 PM10/4/15
to mikhail.p...@intel.com, blink-...@chromium.org, blink-re...@chromium.org, chromium...@chromium.org, mikhail.p...@intel.com

https://codereview.chromium.org/1370113006/diff/20001/third_party/WebKit/Source/wtf/text/AtomicString.h
File third_party/WebKit/Source/wtf/text/AtomicString.h (right):

https://codereview.chromium.org/1370113006/diff/20001/third_party/WebKit/Source/wtf/text/AtomicString.h#newcode185
third_party/WebKit/Source/wtf/text/AtomicString.h:185: static
AtomicStringTable* createAtomicStringTable();
I wonder why createAtomicStringTable and destroyAtomicStringTable are
functions of AtomciString, not AtomicStringTable.

https://codereview.chromium.org/1370113006/

mikhail.p...@intel.com

unread,
Oct 5, 2015, 5:59:11 AM10/5/15
to tk...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, chromium...@chromium.org
AtomicStringTable has not yet been exported, fixed now.

https://codereview.chromium.org/1370113006/

mikhail.p...@intel.com

unread,
Oct 7, 2015, 1:58:02 AM10/7/15
to tk...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, chromium...@chromium.org
Does the patch look ok now?

https://codereview.chromium.org/1370113006/

mikhail.p...@intel.com

unread,
Oct 12, 2015, 5:43:11 AM10/12/15
to tk...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, chromium...@chromium.org
Reply all
Reply to author
Forward
0 new messages